From patchwork Tue Apr 11 11:48:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 81925 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2520583vqo; Tue, 11 Apr 2023 05:10:10 -0700 (PDT) X-Google-Smtp-Source: AKy350ZdZPAbUnniga2XvdHMQn9crnnBjek+GvT8QwIz+6rxl8yoZHdEZ7+t/TrSGSclXcj3uoJA X-Received: by 2002:a17:90a:1903:b0:23f:7ff6:eba with SMTP id 3-20020a17090a190300b0023f7ff60ebamr17430834pjg.0.1681215010240; Tue, 11 Apr 2023 05:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681215010; cv=none; d=google.com; s=arc-20160816; b=LkdKD6TGba6rINOnNhxuA7djLpj5S9q75qCliCSBOZnrsdu4OwJGymvH0CClG5PJeI 4XMWxcGsddyr4Ekn0xqx9cCly7wbg6zh+B0ad744nI5zb2VvHj+HjE4MHDUAGOgTMspA Ud+0+JMqUB/1cje4/+D16Fq5SdZyGBlMedxPyMFBXeG2+jSHaTrsg2KZ5E8phv0R8m3B Cg/MIEUnfp+JnlbJQATVynN7GrwD5hRyWm2DpcUTsPKfM4kJKbSvlRjfj9I80k6nSWDM Es9HcbzfQ0g6wHc6cBirSZSUOP03woofIUuPE3N+waBj8SmY9armT9ooHUFCvkTcyb4O AZww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dAEaIL3DVRQgdxtmwxOflLs84+RlxZ1ItlHOdYNdRak=; b=AY1yIH4oPbM6Fnzfmg9rNl6RsYoHgsyRaoxL7ALpOgSC49kt677XuLHdUZd3t1vVFi KUv7TWgZ2qdu7HzQuCok/eFOkHcz05uzk6kAqKaDSV1y9HPOq9Rr6jyEUSrsJXJz095d qtjSPUbw/or1YVbCVSdxtxRSiBdQB7utv6cPzIrgWKCCCsiwofeWcSoAPKQz/or5e9oG idWOMCTECOWJoGXwzin+JaZ36ugCxX76y8bXeVnNRIAJli4eQnSgr1xG/NnPfQ76WMUa 1WaQ21rUWCIu2pqKCsBXUrW5pxMXNt2mlvHsy2xB/ZcuBLzqYk+Boxr2NZJ8vFcC8u87 e91g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WWZZhQFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id np4-20020a17090b4c4400b002467a036c62si9189471pjb.45.2023.04.11.05.09.57; Tue, 11 Apr 2023 05:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WWZZhQFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjDKLtL (ORCPT + 99 others); Tue, 11 Apr 2023 07:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbjDKLtD (ORCPT ); Tue, 11 Apr 2023 07:49:03 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D6DA3 for ; Tue, 11 Apr 2023 04:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213735; x=1712749735; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Gdags1M6Medyo7CL5SRzy4P8BpRShQdkhod4NJbc6wU=; b=WWZZhQFkwZw+vohf/mLTxvkNt9+eK3UTMCL+1yeUq60bP6pOf31dQqad TRrUn3NgEbXghbLmA4e0V6+eX9RMl4V4KyeEDh6rq7PeUujBI+lGigMve 4AhaWl+1irPpXTl9vei6MARwpZJx8kF5Bte5uZbdQ/uyf2BAz/FuZ4gU8 HM59YBLERCdEzoV6ZmXcBCqMoLXOvu6LMM1BAW6skZBMZOrmR9AlzzM7P D46noATzZuHcT/RmJnINoJ0itTSe3J/f/M7+wKcXJPXB/XDp9qtNK92Oj 1H3uiMeRAZ5ZPiCeLhOk3KnJrt/Xihzb9A379amIJG60PGUr17xYuLYG3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="343600836" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="343600836" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="777888102" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="777888102" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 11 Apr 2023 04:48:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4F7306FC; Tue, 11 Apr 2023 14:48:26 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v3 3/3] extcon: Drop unneeded assignments Date: Tue, 11 Apr 2023 14:48:24 +0300 Message-Id: <20230411114824.82960-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> References: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762881710445139119?= X-GMAIL-MSGID: =?utf-8?q?1762881710445139119?= In one case the assignment is duplicative, in the other, it's better to move it into the loop — the user of it. Signed-off-by: Andy Shevchenko Acked-by: Chanwoo Choi --- drivers/extcon/extcon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 76dc41e8f250..6f7a60d2ed91 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -245,7 +245,7 @@ static DEFINE_MUTEX(extcon_dev_list_lock); static int check_mutually_exclusive(struct extcon_dev *edev, u32 new_state) { - int i = 0; + int i; if (!edev->mutually_exclusive) return 0; @@ -1246,7 +1246,7 @@ static int extcon_alloc_groups(struct extcon_dev *edev) */ int extcon_dev_register(struct extcon_dev *edev) { - int ret, index = 0; + int ret, index; ret = create_extcon_class(); if (ret < 0) @@ -1255,7 +1255,7 @@ int extcon_dev_register(struct extcon_dev *edev) if (!edev || !edev->supported_cable) return -EINVAL; - for (; edev->supported_cable[index] != EXTCON_NONE; index++); + for (index = 0; edev->supported_cable[index] != EXTCON_NONE; index++); edev->max_supported = index; if (index > SUPPORTED_CABLE_MAX) {