From patchwork Tue Apr 11 11:48:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 81912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2518021vqo; Tue, 11 Apr 2023 05:06:23 -0700 (PDT) X-Google-Smtp-Source: AKy350bXIuaH0w7W+6aOAzJmMuL/PgPffZ94o2qTxYILIv/x9uyCZiUBiWQ/JA6uAC+SObuh4FZc X-Received: by 2002:a17:906:4e95:b0:94a:5c39:fdce with SMTP id v21-20020a1709064e9500b0094a5c39fdcemr8303930eju.24.1681214783099; Tue, 11 Apr 2023 05:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681214783; cv=none; d=google.com; s=arc-20160816; b=SFRVomOv9UdBHbFmpdHSd2hnlTmlBWtvDbSiWBfvNfJscPC5s7I22ZOjqm3HzqgsR2 7aeFk+b4woZHboW/igRlJzTx5MZ0zKlE/kRJ2XbGB8iogfAytlflDpJTOKxlqSodTQg8 Skzhd3G6JAG5hSL8XLgEfB3sUNTF3rw4lThJsMOs0tytekvo2mQ3g+dy/D6mwMUIFNbj x8cQx71PtmPlH9Y5TCMI++6DkQcSFVcEZJdwJ8xS3HZcE0f/m8EoBGQmPJ8DhZhjMBLf +BOLrDVN2NiWzkQyGXKOBSNSrYnCbi64ZNxtL8Z283VLu7UCZ5DHA01giXWEdZfB/tsz rowA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c+M6gR65IXjqClfufgBh3Jrwe3URPvV11d8M+yoGl7c=; b=PsE2eBcj9xyV1lpkdHfa03Zkhds6IJMr4RmDPMqgH/Bf44kmiddRl96wwkq9q1d2YA 0Z60LE5isnGVk5d3dBq5s9Hcsg1ONK5EHu9fIRl6s5oiO92gUm6Se96yC4i7y0yycPcV lZP0TdazO73vpSZVipbK3mxnKkPlRq1N9RnM0YPG4tGZGFe2FPBbgh71Qka04Au+2gxN C/e2NmekYgq9Fqn92UJ4Dxbmi2+nW6kklIdyrE7bXfIWAficzRqj3G13kv+bFq9R8jGc fhmtguiEt+gO4/7413cZHkRDZfnNkJfARuAQC/YcFfBvwwj1QqjBgnFQjc+PED3RYfja 7fpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PkeYAusF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y9-20020a17090668c900b0093331f16cffsi1318269ejr.159.2023.04.11.05.05.47; Tue, 11 Apr 2023 05:06:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PkeYAusF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjDKLtA (ORCPT + 99 others); Tue, 11 Apr 2023 07:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbjDKLsz (ORCPT ); Tue, 11 Apr 2023 07:48:55 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1772135B5 for ; Tue, 11 Apr 2023 04:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213720; x=1712749720; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7VrN3slwc1LQogRpZmTA8V/KyyDIUcLvvghnWCubjmI=; b=PkeYAusFpIqhkYH7lfkYZvzuD5i/0vD0ZLQU2XB0aRKu5i7iDMZ/HzbB Oby/72x1npTHlsZW4Gpu7cLNKPINmU6uLA9Z4usUtoDITskTvOh+Yi6aV a0Fl7Fy8vO1X/GZisDdKcm/z0LUQ9fEVsL52DAJ9TOklxIxknbVo5q2MT jhSKe/1fx3y55D4S4qcHeXM3/xh1OqX4fZWaz7V6l76oolzeBE2T3K333 39KnHKgW+asSdADCGvRUTDyR6YUjgUT7SBFOQYJkjFriXQ5iNPTqs49Yp +VltqbdS51s7hydh0uMQq+dz2qIhjt6xNfJSI+gC/3truN4UNDILX0SGy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="343600835" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="343600835" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="777888100" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="777888100" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 11 Apr 2023 04:48:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 40F5869A; Tue, 11 Apr 2023 14:48:26 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v3 2/3] extcon: Use sizeof(*pointer) instead of sizeof(type) Date: Tue, 11 Apr 2023 14:48:23 +0300 Message-Id: <20230411114824.82960-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> References: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762881472529774451?= X-GMAIL-MSGID: =?utf-8?q?1762881472529774451?= It is preferred to use sizeof(*pointer) instead of sizeof(type). The type of the variable can change and one needs not change the former (unlike the latter). No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 5da1cc60582a..76dc41e8f250 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1098,8 +1098,7 @@ static int extcon_alloc_cables(struct extcon_dev *edev) if (!edev->max_supported) return 0; - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), + edev->cables = kcalloc(edev->max_supported, sizeof(*edev->cables), GFP_KERNEL); if (!edev->cables) return -ENOMEM; @@ -1161,14 +1160,12 @@ static int extcon_alloc_muex(struct extcon_dev *edev) for (index = 0; edev->mutually_exclusive[index]; index++) ; - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), + edev->attrs_muex = kcalloc(index + 1, sizeof(*edev->attrs_muex), GFP_KERNEL); if (!edev->attrs_muex) return -ENOMEM; - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), + edev->d_attrs_muex = kcalloc(index, sizeof(*edev->d_attrs_muex), GFP_KERNEL); if (!edev->d_attrs_muex) { kfree(edev->attrs_muex); @@ -1214,8 +1211,8 @@ static int extcon_alloc_groups(struct extcon_dev *edev) return 0; edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); + sizeof(*edev->extcon_dev_type.groups), + GFP_KERNEL); if (!edev->extcon_dev_type.groups) return -ENOMEM;