From patchwork Tue Apr 11 06:48:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolu Lu X-Patchwork-Id: 81778 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2380484vqo; Tue, 11 Apr 2023 00:11:38 -0700 (PDT) X-Google-Smtp-Source: AKy350YMWQxlJthaHm0O0hlPhkCiVG80P6a6EQkqoxssJEgrKXlJV8W0xeZpiz1FulsOVeY7lbaa X-Received: by 2002:a17:90a:1150:b0:240:1014:a1b3 with SMTP id d16-20020a17090a115000b002401014a1b3mr2199970pje.35.1681197097690; Tue, 11 Apr 2023 00:11:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681197097; cv=none; d=google.com; s=arc-20160816; b=d14E6m5Zi0lzNdnjOsFOt3axoNvUGHAX0tl2oSVGk0DpFgjh3IPsBNYc0+YPmoG13Z QM2HFu4SDWeBqRJapwQ0cQuVTzpOImoRl/p/U+5lOU45e/K88IyDZEYqbz/55575sjQ/ khAlX1AChCUl4M2HVHI+rZ2cKbElf+elLifJ21janw23PM1uceoRv1dBtk1ryRUN8gtQ /t2c25d1cDQqFXMP4QQ7twiV08aAWPU8xHGTeAGeQn6Qr82gvClMWVW19R2mJt1s0pAk n4glJ3ADWl5fMrYoV2JlksbsV6+45+3GbqBWukoh05F96BPidD1Guw7OV+wsw/G+LMa4 /Hvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gtm8RkT0yxwe71dbqxBAk2+ojNT/TWjrefqo1SdVU6I=; b=l+KwBsY2jURtRpcHWcB2q9RdklAp0PhdpTmVyudRPYLFtKI4sF/dZAPBe6sqp6vyl2 6eR7sttuXSg85Lsz2LdZQXygGRZGxYXqgikPAxd7SuW2APRD9m6D2B/sh2AuPD/FUQGK uh1MIxQaBT2ARexkhVoaryTARkQj52c8Qc5M4t1IEfnaqRGk23X2hp7YdjlqfLqe8ayv 0fVil6Hqyns0mAOgrGJ/9G2NS5oWdELv2acbafsXOHK2iUwNmKTMxi9aYqD5qZR8Nlsg IspZayeGeBJ2QEw3w5GamRRbA8jjVxpBqE5SMPIrR8hhsdCL5ujMrHK5Ts2xB9MiZWsD aRHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mMWV0gZF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pg3-20020a17090b1e0300b00230ca3efcf3si13018779pjb.158.2023.04.11.00.11.24; Tue, 11 Apr 2023 00:11:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mMWV0gZF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbjDKGuC (ORCPT + 99 others); Tue, 11 Apr 2023 02:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbjDKGth (ORCPT ); Tue, 11 Apr 2023 02:49:37 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 469BB40DB for ; Mon, 10 Apr 2023 23:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681195744; x=1712731744; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KLcSzST6hDd+fcr/F74YMXpjYh9sQavSmsQ3e9U8YPk=; b=mMWV0gZF369JfYk0K9qcRLqRY1D8k4cXx7WLPcY0ABcB0Ctye7x6o8EH eJLOIzDvLiweUPWuZf0r5PUCUu0aMCrcR0Xn3yedv2wEUf+8SrgIuhvkI tWFaAxY7opeGypBTgXms5iaiGsW/NfuUnEjSkbjDuTx2HykG10rvxZxpo p6zplp/Eytu8n1We1ZUZmwaG2WYO8L4Zrn9IPr+bDyyDyRZThfT7UoVaB 94iw7bxLwI0uPeN1Zxt69BNR9XNmSfUH9rDGKr0t/ms+J2iWAmZzXdEi1 ivcMmnYFYNOFGa02jof6aqb1htqOObUVxfAYceLfIDbfXvSfykgATlEL+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="341028553" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="341028553" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2023 23:48:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="1018256594" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="1018256594" Received: from allen-box.sh.intel.com ([10.239.159.127]) by fmsmga005.fm.intel.com with ESMTP; 10 Apr 2023 23:48:24 -0700 From: Lu Baolu To: Joerg Roedel Cc: Vinod Koul , Tina Zhang , Jacob Pan , Christophe JAILLET , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 07/17] iommu/vt-d: Do not use GFP_ATOMIC when not needed Date: Tue, 11 Apr 2023 14:48:05 +0800 Message-Id: <20230411064815.31456-8-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230411064815.31456-1-baolu.lu@linux.intel.com> References: <20230411064815.31456-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762862928052186758?= X-GMAIL-MSGID: =?utf-8?q?1762862928052186758?= From: Christophe JAILLET There is no need to use GFP_ATOMIC here. GFP_KERNEL is already used for some other memory allocations just a few lines above. Commit e3a981d61d15 ("iommu/vt-d: Convert allocations to GFP_KERNEL") has changed the other memory allocation flags. Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/e2a8a1019ffc8a86b4b4ed93def3623f60581274.1675542576.git.christophe.jaillet@wanadoo.fr Signed-off-by: Lu Baolu --- drivers/iommu/intel/irq_remapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/irq_remapping.c b/drivers/iommu/intel/irq_remapping.c index df9e261af0b5..a1b987335b31 100644 --- a/drivers/iommu/intel/irq_remapping.c +++ b/drivers/iommu/intel/irq_remapping.c @@ -548,7 +548,7 @@ static int intel_setup_irq_remapping(struct intel_iommu *iommu) goto out_free_table; } - bitmap = bitmap_zalloc(INTR_REMAP_TABLE_ENTRIES, GFP_ATOMIC); + bitmap = bitmap_zalloc(INTR_REMAP_TABLE_ENTRIES, GFP_KERNEL); if (bitmap == NULL) { pr_err("IR%d: failed to allocate bitmap\n", iommu->seq_id); goto out_free_pages;