bus: vexpress-config: Add explicit of_platform.h include

Message ID 20230410232727.1562115-1-robh@kernel.org
State New
Headers
Series bus: vexpress-config: Add explicit of_platform.h include |

Commit Message

Rob Herring April 10, 2023, 11:27 p.m. UTC
  vexpress-config uses of_platform_* functions which are declared in
of_platform.h. of_platform.h gets implicitly included by of_device.h,
but that is going to be removed soon. Nothing else depends on
of_device.h so it can be dropped.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/bus/vexpress-config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Liviu Dudau April 11, 2023, 2:28 p.m. UTC | #1
On Mon, Apr 10, 2023 at 06:27:26PM -0500, Rob Herring wrote:
> vexpress-config uses of_platform_* functions which are declared in
> of_platform.h. of_platform.h gets implicitly included by of_device.h,
> but that is going to be removed soon. Nothing else depends on
> of_device.h so it can be dropped.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

I'm expecting Sudeep will pick this one up through his tree, if not please
let me know.

Best regards,
Liviu

> ---
>  drivers/bus/vexpress-config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index a58ac0c8e282..472a570bd53a 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -10,7 +10,7 @@
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> -#include <linux/of_device.h>
> +#include <linux/of_platform.h>
>  #include <linux/sched/signal.h>
>  #include <linux/slab.h>
>  #include <linux/vexpress.h>
> -- 
> 2.39.2
>
  
Rob Herring April 11, 2023, 7:27 p.m. UTC | #2
On Tue, Apr 11, 2023 at 03:28:33PM +0100, Liviu Dudau wrote:
> On Mon, Apr 10, 2023 at 06:27:26PM -0500, Rob Herring wrote:
> > vexpress-config uses of_platform_* functions which are declared in
> > of_platform.h. of_platform.h gets implicitly included by of_device.h,
> > but that is going to be removed soon. Nothing else depends on
> > of_device.h so it can be dropped.
> > 
> > Signed-off-by: Rob Herring <robh@kernel.org>
> 
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> 
> I'm expecting Sudeep will pick this one up through his tree, if not please
> let me know.

I have several other drivers/bus/ patches, so I can take this too. Maybe 
drivers/bus/ needs a maintainer...

Rob
  
Sudeep Holla April 17, 2023, 12:41 p.m. UTC | #3
On Mon, 10 Apr 2023 18:27:26 -0500, Rob Herring wrote:
> vexpress-config uses of_platform_* functions which are declared in
> of_platform.h. of_platform.h gets implicitly included by of_device.h,
> but that is going to be removed soon. Nothing else depends on
> of_device.h so it can be dropped.
> 

Applied to sudeep.holla/linux (for-next/vexpress), thanks!

[1/1] bus: vexpress-config: Add explicit of_platform.h include
      https://git.kernel.org/sudeep.holla/c/04ebdc354895
--
Regards,
Sudeep
  

Patch

diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index a58ac0c8e282..472a570bd53a 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -10,7 +10,7 @@ 
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/sched/signal.h>
 #include <linux/slab.h>
 #include <linux/vexpress.h>