From patchwork Mon Apr 10 08:14:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Xin3" X-Patchwork-Id: 81407 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1758047vqo; Mon, 10 Apr 2023 01:44:33 -0700 (PDT) X-Google-Smtp-Source: AKy350bAd86HmwWBpDvz/nBPvkR0y1Bf/kJnetWd4ZjhU/1JlW2LBoa0I1xdIEC6L9BqR7eAnUlM X-Received: by 2002:a17:903:284e:b0:1a5:3056:3c95 with SMTP id kq14-20020a170903284e00b001a530563c95mr4623143plb.68.1681116272932; Mon, 10 Apr 2023 01:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681116272; cv=none; d=google.com; s=arc-20160816; b=nVjhUYUOf38524rlVXMXligiSlGkaLn53bc3ZVsbDJex5zU7NGTLSt9/R8FQJ0B9w8 jw+4wq56VWOkJOCnrXpTPrs5xsdytQ+6rV3MfYom5bhqWwwU1B75z51s36RTH3mbjuvv WfQvqv9EzTHHc6qJL/r47Wib+Pc55bunEpujUxXMJsSJDQ91bBBfBte4R7ydYTc4sHYt vxEi/AdMis44o3XafnUHacDn/+VjoT6QWUV/jVUZ7aa6LflvUxfci3OUU8Q9/Nf4dNAp 0uQvK41MIfVwUXJ+1fNHkrs+YcFBiYCM3l//1nVWg+1l0EiuDPqtcVyDklUv9isKcJ5s BUfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HXWU+EothhAOstFqFMAbdES8hja1CkXrrCI4kIOxLxM=; b=WbwWVqtNA6Qu+cnuUosgtmEN3BgXw2c9QvIHzyR08rs5SPxbkA8eN+d1vqPzESaGxm pCSb2z6z34ySoAPj5c0DG8R0NkSQ5WTDwNclBXJ0uptQDY/r4WcUqr+cq70SUm7uyfUh bMrXeZN4Io72Xq61lRBB+mO0zaukindXhUuZPSC8skcV5eaJzyyx0Rsa+ya0mb9QO6l1 wsBHIm+xu6tDlQ4mGHyZdxEGkpWtbRU49vnwmNGTixQuka2HBU7GbgVfyHma5bcp3K1w PEJ8+BT+MZR2Uil6479CSZLqd9otKhVgeQFThilgtv//TAGoHcup+vMj8ZHR58ulJCgo E4Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KTpeEpbh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 137-20020a63018f000000b0050bf0f0870esi10518876pgb.627.2023.04.10.01.44.21; Mon, 10 Apr 2023 01:44:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KTpeEpbh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229998AbjDJIm3 (ORCPT + 99 others); Mon, 10 Apr 2023 04:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbjDJIlq (ORCPT ); Mon, 10 Apr 2023 04:41:46 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E42B4EEC; Mon, 10 Apr 2023 01:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681116072; x=1712652072; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=T7eEyAoHvwiW3Acg9V6KJ8qZ7RgqMyuTGxhG3JO7gws=; b=KTpeEpbh+tQHnFEAvWnqCYVevK3RkhTHTfILlIAY31KrSaUldkebW/Tu f1K9RNg6xMkjarvo1HTkC8aCPWFzoWBWlrRiN8frTWCEiHgpAQosCK5GH l/C+zeEa1cDgdO2xyGKjtlpLD7L3pDP14LigllckiJkdubcWQnZCxsEE5 F9doOn50V2ECjGOaztMcMASdFwu/ZNDi9T6SBcbsFnPW9CsgqKCXpSo6M Bre9/ELlEhfnUsjK3kZTn8YU2ZsxCZ2WIv7ntHR8es8k82xdnqxmpqp8c UXYoNaaZC7slgWBKKLmbzBBAnw0G/rowueDslKVYzlK23Z+SxdX2J0QHv A==; X-IronPort-AV: E=McAfee;i="6600,9927,10675"; a="342078128" X-IronPort-AV: E=Sophos;i="5.98,333,1673942400"; d="scan'208";a="342078128" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2023 01:41:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10675"; a="799436337" X-IronPort-AV: E=Sophos;i="5.98,333,1673942400"; d="scan'208";a="799436337" Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga002.fm.intel.com with ESMTP; 10 Apr 2023 01:41:06 -0700 From: Xin Li To: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org, andrew.cooper3@citrix.com, seanjc@google.com, pbonzini@redhat.com, ravi.v.shankar@intel.com, jiangshanlai@gmail.com, shan.kang@intel.com Subject: [PATCH v8 24/33] x86/fred: disallow the swapgs instruction when FRED is enabled Date: Mon, 10 Apr 2023 01:14:29 -0700 Message-Id: <20230410081438.1750-25-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230410081438.1750-1-xin3.li@intel.com> References: <20230410081438.1750-1-xin3.li@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762778176933559201?= X-GMAIL-MSGID: =?utf-8?q?1762778176933559201?= From: "H. Peter Anvin (Intel)" The FRED architecture establishes the full supervisor/user through: 1) FRED event delivery swaps the value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR. 2) ERETU swaps the value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR. Thus, the swapgs instruction is disallowed when FRED is enabled, otherwise it causes #UD. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/kernel/process_64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index a1aa74864c8b..2bea86073646 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -165,7 +165,8 @@ static noinstr unsigned long __rdgsbase_inactive(void) lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); gsbase = rdgsbase(); native_swapgs(); @@ -190,7 +191,8 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) { lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); wrgsbase(gsbase); native_swapgs();