From patchwork Mon Apr 10 07:08:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changbin Du X-Patchwork-Id: 81370 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1730963vqo; Mon, 10 Apr 2023 00:31:37 -0700 (PDT) X-Google-Smtp-Source: AKy350bx4qsaBgBTXBAeaCUBCITwjqj4x9psyHy3TrrvOZ150956tXIaveUIdtds9qQGw3FBvPWE X-Received: by 2002:aa7:cf19:0:b0:502:70e9:2c14 with SMTP id a25-20020aa7cf19000000b0050270e92c14mr9466034edy.29.1681111897610; Mon, 10 Apr 2023 00:31:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681111897; cv=none; d=google.com; s=arc-20160816; b=V9me6yvxhT3xgp3LUfIYR4htKvfScmfxv8tOBwUjMQWxfILKClY8OARZDPnluiegjq dXZz6yo6x9bd1C8mu4g1i6FFVsR++A/on9dErOYQgfzRK+ERpjkDCoQQ8iVlFsiVCwoT J/bYIJmhiY8XyzrE+25h7SAnYyNuMT8ihIK+IwpZuPWSP3p6EQeWguT7Vi2OF20qL0LS r1lJl6WwVI+TdNL90pThinvSG1XcvvqsFoHwvBjbFeVLm/X7dTeVAtyId4efu2EYD9hF Lsa4sQ9YVqkQGYwtEFL63odKE1eTL/n38tpPwsoACrJxFEVFeSAs3vckuIoL+K/uuIwk 4e9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=xoDchxLIbIV90k9DSd1ZaXiTeOZjasnuXHHx7L2dm9Y=; b=jR2W2mjXIp26f4Xup8w8+mKZ/4G92MOFfjnVDwhwrqAwws8E3vYmRh20PfUbRM+ymR MQZAy3GdswfqNdNye5hYxYjTM1xQ2iLg5tV7PczDyT7YuqM4JAmbrKl86yuXyXXRiHX4 DXBcmeVX7QwNV8YmuQq7j/EcT2NFD7oCA7pXT80wIwmr24w+njOrxnXBb0ahl/9pbSIX kos46Y0dn3DWeuOszheystHw3crXTWBdi2lOyNFSdQFxl5wX3Fxe61Trc+a5zhCZCo3O 3j5qu77F7u/nvRl0t3q84fvX0VEopgmF8JB6Q+JszHrEzN7tYWQtzx1te8D8FEfyht1O OUJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t14-20020aa7d4ce000000b00504a26aa3f8si1801769edr.422.2023.04.10.00.31.13; Mon, 10 Apr 2023 00:31:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbjDJHJW (ORCPT + 99 others); Mon, 10 Apr 2023 03:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjDJHJT (ORCPT ); Mon, 10 Apr 2023 03:09:19 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C66BA30D6; Mon, 10 Apr 2023 00:09:18 -0700 (PDT) Received: from kwepemi500013.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pw0QC2d9PzKxq8; Mon, 10 Apr 2023 15:06:43 +0800 (CST) Received: from M910t.huawei.com (10.110.54.157) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 10 Apr 2023 15:09:15 +0800 From: Changbin Du To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , , , Hui Wang , Changbin Du Subject: [PATCH v3 1/2] perf script: print raw ip instead of binary offset for callchain Date: Mon, 10 Apr 2023 15:08:57 +0800 Message-ID: <20230410070858.4051548-2-changbin.du@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230410070858.4051548-1-changbin.du@huawei.com> References: <20230410070858.4051548-1-changbin.du@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.110.54.157] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500013.china.huawei.com (7.221.188.120) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762773589135018468?= X-GMAIL-MSGID: =?utf-8?q?1762773589135018468?= Before this, the raw ip is printed for non-callchain and dso offset for callchain. This inconsistent output for address may confuse people. And mostly what we expect is the raw ip. 'dso offset' is printed in callchain: $ perf script ... ls 1341034 2739463.008343: 2162417 cycles: ffffffff99d657a7 [unknown] ([unknown]) ffffffff99e00b67 [unknown] ([unknown]) 235d3 memset+0x53 (/usr/lib/x86_64-linux-gnu/ld-2.31.so) # dso offset a61b _dl_map_object+0x1bb (/usr/lib/x86_64-linux-gnu/ld-2.31.so) raw ip is printed for non-callchain: $ perf script -G ... ls 1341034 2739463.008876: 2053304 cycles: ffffffffc1596923 [unknown] ([unknown]) ls 1341034 2739463.009381: 1917049 cycles: 14def8e149e6 __strcoll_l+0xd96 (/usr/lib/x86_64-linux-gnu/libc-2.31.so) # raw ip Let's have consistent output for it. Later I'll add a new field 'dsoff' to print dso offset. Signed-off-by: Changbin Du --- tools/perf/util/evsel_fprintf.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index bd22c4932d10..1fb8044d402e 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -153,13 +153,8 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, if (map) addr = map->map_ip(map, node->ip); - if (print_ip) { - /* Show binary offset for userspace addr */ - if (map && !map->dso->kernel) - printed += fprintf(fp, "%c%16" PRIx64, s, addr); - else - printed += fprintf(fp, "%c%16" PRIx64, s, node->ip); - } + if (print_ip) + printed += fprintf(fp, "%c%16" PRIx64, s, node->ip); if (print_sym) { printed += fprintf(fp, " ");