From patchwork Mon Apr 10 01:12:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 81337 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1629525vqo; Sun, 9 Apr 2023 19:04:19 -0700 (PDT) X-Google-Smtp-Source: AKy350aZymOoXu8T+NuvRsSGc6L4q78K++9uVCv61iyu1iQUeVjyuCRDyzQf21tCnwShvufmcEOf X-Received: by 2002:a17:902:db10:b0:19a:b754:4053 with SMTP id m16-20020a170902db1000b0019ab7544053mr16255652plx.26.1681092258823; Sun, 09 Apr 2023 19:04:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681092258; cv=none; d=google.com; s=arc-20160816; b=mn6RLmyI4+ggfvQxi2upvjmrv6BgtTbtMsKqat9lkUlyd5UfC5ZqUhWACvVhrQopVP WFECCFENO9HB0FnzhvlKJ0J9gHfzGoGZ5kLaGRRfJn0e55K3xtcHoyybd7VnMYf3M/dv tHIeIumavLy6NQLGiE3i8CHUFuJ2LCNbYsor1vpeXJMLwZzitfoarJyy6gyL+j78lIrR WXCyfLctFIWbLRZm7LDXg5xwiTbbIasm6QczsVGuUj++p8Fb62yyG/c/nGjLESfKoNB+ Za14BRi0htRP2e822W+1J7oMo88jRV3loyyowT4HiIr0umdvyB8K9UKOlzNWFUPud898 cdDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5ZqyIo2yPozy9BK+WevZ7XbxMmk32DVp4jnPgiud1w8=; b=ub9VWkaqxmI+2cZ9lK4kBGRrpEMH6XWClWj9zXzHTXvYipzqK8okMVNY9krZmoDKa7 6jiqpCZxldSuSuB+1j7RdpmhDiW97bExv1ts50UopFcHNcOJXJvtFGpuSXhGVRGFyIJD B/83Y805L9DIFsBzRiNQGXnwwrQIhOkp+CP5099oTogfh7s4P0XD0xPUG4fmW6280g7k /HmTe8WHjQlP/FTBRTHsEwH/5hLsjoVLL75jzmC4u7Uq8gvmUqVLAdmdklZeF8/8yw+G V6WO68z5MQkdlNEmb48wOBIh6hKDger8FwoL6y2yynE+PNwLNTWi57wEpGQHZJ/6u8in GWNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CS2NUHbs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x7-20020a170902ec8700b001a1b238d1c0si5003992plg.636.2023.04.09.19.04.07; Sun, 09 Apr 2023 19:04:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CS2NUHbs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbjDJBNH (ORCPT + 99 others); Sun, 9 Apr 2023 21:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjDJBNG (ORCPT ); Sun, 9 Apr 2023 21:13:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC1930FA for ; Sun, 9 Apr 2023 18:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=5ZqyIo2yPozy9BK+WevZ7XbxMmk32DVp4jnPgiud1w8=; b=CS2NUHbsxWHgEMwrtE3Ai397jJ eXoVpzicm+RfmWnc3oR1P0YPKA4NK1qTUUhYXh1Bx8+hhT0ZArj5TeXoeMsj2Wxuka1omHAjGFdzx j5Na+sxo7khLwW2anLjX1oh6PmqjFIaGugSYTdO/uO+/H+x8yCmlUVg6EXH9HC+lP1pYuhLif4TQW kI/KfPyZUOfIy6svdLEK0YuOQolRPwaRZ+Upn9GMk+KJqTN0cCvL96zCQ3Z9h04uaIlILCIoWj/qE B7QJ8lJLdyUZZOGRIWVDL5BaVBrA2AU0Rn/UQ2w6NjrPPYcnC5nqlVawWViqmcCOW+FqZya2e4xVg mASJvUpA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1plg5X-00EPbS-2C; Mon, 10 Apr 2023 01:12:55 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Michael Ellerman , Christophe Leroy , Leo Li , Masahiro Yamada , Nicolas Schier , Qiang Zhao , linuxppc-dev , linux-arm-kernel@lists.infradead.org, Kumar Gala Subject: [PATCH v2] soc/fsl/qe: fix usb.c build errors Date: Sun, 9 Apr 2023 18:12:54 -0700 Message-Id: <20230410011254.25675-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762752996081928545?= X-GMAIL-MSGID: =?utf-8?q?1762752996081928545?= Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. This happens when PPC_EP88XC is set, which selects CPM1 & CPM. When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE being set. When USB_FSL_QE is set, QE_USB deafults to y, which causes build errors when QUICC_ENGINE is not set. Making QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y. Fixes these build errors: drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set': usb.c:(.text+0x1e): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg' powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock' powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock' Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ Suggested-by: Michael Ellerman Cc: Christophe Leroy Cc: Leo Li Cc: Masahiro Yamada Cc: Nicolas Schier Cc: Qiang Zhao Cc: linuxppc-dev Cc: linux-arm-kernel@lists.infradead.org Cc: Kumar Gala --- v2: drop Anton Vorontsov ; rebase/resend drivers/soc/fsl/qe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -62,6 +62,7 @@ config QE_TDM config QE_USB bool + depends on QUICC_ENGINE default y if USB_FSL_QE help QE USB Controller support