From patchwork Sat Apr 8 02:26:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "David E. Box" X-Patchwork-Id: 81106 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp643967vqo; Fri, 7 Apr 2023 19:58:21 -0700 (PDT) X-Google-Smtp-Source: AKy350ZNkQTxO9z/OeaISJPCtXROLO+AVexJ61SKPN6jMeBPfv7G0iFzeyS8zscJByebxalms5yW X-Received: by 2002:a17:90b:2250:b0:23d:1143:1e3c with SMTP id hk16-20020a17090b225000b0023d11431e3cmr4572116pjb.44.1680922701673; Fri, 07 Apr 2023 19:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680922701; cv=none; d=google.com; s=arc-20160816; b=J8ymI+NkZ8hn9AW0+PTp4rNnA1Das5Opo4GK+D1MDVgTXw3YV1sfhkSyd8A62gCiTJ OWyLckZLZDYS38x6ZaustisC9vgz9mvkQ4PVvs+PErZNisBFUx05omsGTVKGwAZzREV2 lX0SZGvGRfoBhKRZQDsLGWzn4P0iVAtPNaEaHMMytFAZriVH9A6odjylJMkqtDyDDY7t Y9lO7G5wJ4HMbllEuf6cRURsdYFr5HbC2IbAWj6wSJQSOQ7qSSnN/V87t6bn8TWmY05g TLVdxeDM3v1LelS5Ttmirnl8seRs1enIT5PD84qhh07gNKNeN+07Aq7qblmEs/vhAdlO h0Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/wZg+vzf89w0UDp9pCCoyjf8+Lut04fw+kOLJUnUJQU=; b=w1naqAHr7LCP6leIeYovP4W28LB202wK1HQhNcR+iwX7psSXfl76NyrX40l1dQSz8b SPCGR8GM0dqyvi+IlTJJBgX5INPqlm036kVZ05ykESGkt7qdF6d/l3Cli+z4fbh4Ce5F ZxYcm3GVuYWN9WnjH2I2BcmvujXDEXx6J+zHrfZj3LrTsGQLAcqrzID65q9Doa6g2yKU /C4jcVPPhAY7UCOW/SNDoglkwwlqa2usfhnzqK+OlwWTATVnDoBbKfBzEzUpH2M25Bim aB1es81NPltrIBHqwPHnkHoERP7ox9/TMXA2AzOMW4k4uIZAwcFITtzdzX771j+4XWbe Bwog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=L36bI+GQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020a17090acb1300b002449259314esi5312679pjt.158.2023.04.07.19.58.09; Fri, 07 Apr 2023 19:58:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=L36bI+GQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbjDHC0c (ORCPT + 99 others); Fri, 7 Apr 2023 22:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjDHC0b (ORCPT ); Fri, 7 Apr 2023 22:26:31 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6831BCC1F; Fri, 7 Apr 2023 19:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680920790; x=1712456790; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=DP/6n7B8aOJPPw9H6I1+IBM8O6GwGkK+AtSPpjSso4s=; b=L36bI+GQrna0oArrKWZy9MMhpQ2pNqNP+vQ0p056EGw9qll7YvgSXYqn 693uKt2/5Sr3/g0ejEzewKlbht8t7AWS67+9sjlv+9BN0AqwngAtzMV7x MxVpFQl9chy63druYDPqPaJDYmyRJnMLKH2h88lDl4srWs16wWSPRFpH5 GapQ+1w1uYkDXxAuHSdPKJUbbfF1rayiB7SgRk3SCYiXqHX5h2bfuTq0h fftAPqagFZIcYoMTKoW07F0YBjxjAXClF4zq378RQbDMJ83lnrWp1Jgxp 44LKRiTy+ZV5QDA2Cmq+mDRh1SSdm1oAU4CJHvoEituQGp+zVaxqVhuam w==; X-IronPort-AV: E=McAfee;i="6600,9927,10673"; a="323473923" X-IronPort-AV: E=Sophos;i="5.98,328,1673942400"; d="scan'208";a="323473923" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2023 19:26:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10673"; a="690214902" X-IronPort-AV: E=Sophos;i="5.98,328,1673942400"; d="scan'208";a="690214902" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 07 Apr 2023 19:26:29 -0700 Received: from debox1-desk4.lan (unknown [10.251.23.166]) by linux.intel.com (Postfix) with ESMTP id A8F9558047E; Fri, 7 Apr 2023 19:26:29 -0700 (PDT) From: "David E. Box" To: srinivas.pandruvada@linux.intel.com, irenic.rajneesh@gmail.com, david.e.box@intel.com, hdegoede@redhat.com, markgross@kernel.org, rjw@rjwysocki.net Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86/intel/pmc/mtl: Put GNA/IPU/VPU devices in D3 Date: Fri, 7 Apr 2023 19:26:29 -0700 Message-Id: <20230408022629.727721-1-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762575202743453211?= X-GMAIL-MSGID: =?utf-8?q?1762575202743453211?= On Meteor Lake, the GNA, IPU, and VPU devices are booted in D0 power state and will block the SoC from going into the deepest Package C-state if a driver is not present. Put each device in D3hot if no driver is found. Signed-off-by: David E. Box Reviewed-by: Hans de Goede --- drivers/platform/x86/intel/pmc/mtl.c | 31 ++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) base-commit: 4f59630a5ed0a4e7d275bd7e5d253a8f5a425c5a diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c index eeb3bd8c2502..33aa98b54049 100644 --- a/drivers/platform/x86/intel/pmc/mtl.c +++ b/drivers/platform/x86/intel/pmc/mtl.c @@ -8,6 +8,7 @@ * */ +#include #include "core.h" const struct pmc_reg_map mtl_reg_map = { @@ -45,8 +46,38 @@ void mtl_core_configure(struct pmc_dev *pmcdev) pmc_core_send_ltr_ignore(pmcdev, 3); } +#define MTL_GNA_PCI_DEV 0x7e4c +#define MTL_IPU_PCI_DEV 0x7d19 +#define MTL_VPU_PCI_DEV 0x7d1d +void mtl_set_device_d3(unsigned int device) +{ + struct pci_dev *pcidev; + + pcidev = pci_get_device(PCI_VENDOR_ID_INTEL, device, NULL); + if (pcidev) { + if (!device_trylock(&pcidev->dev)) { + pci_dev_put(pcidev); + return; + } + if (!pcidev->dev.driver) { + dev_info(&pcidev->dev, "Setting to D3hot\n"); + pci_set_power_state(pcidev, PCI_D3hot); + } + device_unlock(&pcidev->dev); + pci_dev_put(pcidev); + } +} + void mtl_core_init(struct pmc_dev *pmcdev) { pmcdev->map = &mtl_reg_map; pmcdev->core_configure = mtl_core_configure; + + /* + * Set power state of select devices that do not have drivers to D3 + * so that they do not block Package C entry. + */ + mtl_set_device_d3(MTL_GNA_PCI_DEV); + mtl_set_device_d3(MTL_IPU_PCI_DEV); + mtl_set_device_d3(MTL_VPU_PCI_DEV); }