diff mbox series

[v5,3/4] dt-bindings: arm: qcom: Add Acer Aspire 1

Message ID 20230407151423.59993-4-nikita@trvn.ru
State New
Headers
Series Add Acer Aspire 1 |

Commit Message

Nikita Travkin April 7, 2023, 3:14 p.m. UTC 
  Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.

Signed-off-by: Nikita Travkin <nikita@trvn.ru>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
 - Merge with IDP (Krzysztof)
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Doug Anderson April 7, 2023, 4:23 p.m. UTC | #1 
Hi,

On Fri, Apr 7, 2023 at 8:14 AM Nikita Travkin <nikita@trvn.ru> wrote:
>
> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes in v2:
>  - Merge with IDP (Krzysztof)
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f8d29b65f28b..db97a61e8ccb 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -367,9 +367,9 @@ properties:
>                - qcom,qru1000-idp
>            - const: qcom,qru1000
>
> -      - description: Qualcomm Technologies, Inc. SC7180 IDP
> -        items:
> +      - items:
>            - enum:
> +              - acer,aspire1
>                - qcom,sc7180-idp
>            - const: qcom,sc7180

If Krzysztof is happy then I have no real objections here. That being
said, I personally would have updated the description to be more
generic and not say "IDP" anymore. Something like "Non-Chromebook
sc7180 boards".


-Doug
Krzysztof Kozlowski April 7, 2023, 7:33 p.m. UTC | #2 
On 07/04/2023 18:23, Doug Anderson wrote:
> Hi,
> 
> On Fri, Apr 7, 2023 at 8:14 AM Nikita Travkin <nikita@trvn.ru> wrote:
>>
>> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Changes in v2:
>>  - Merge with IDP (Krzysztof)
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index f8d29b65f28b..db97a61e8ccb 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -367,9 +367,9 @@ properties:
>>                - qcom,qru1000-idp
>>            - const: qcom,qru1000
>>
>> -      - description: Qualcomm Technologies, Inc. SC7180 IDP
>> -        items:
>> +      - items:
>>            - enum:
>> +              - acer,aspire1
>>                - qcom,sc7180-idp
>>            - const: qcom,sc7180
> 
> If Krzysztof is happy then I have no real objections here. That being
> said, I personally would have updated the description to be more
> generic and not say "IDP" anymore. Something like "Non-Chromebook
> sc7180 boards".

I am fine with both - dropping the description or changing it to
something meaningful.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index f8d29b65f28b..db97a61e8ccb 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -367,9 +367,9 @@  properties:
               - qcom,qru1000-idp
           - const: qcom,qru1000
 
-      - description: Qualcomm Technologies, Inc. SC7180 IDP
-        items:
+      - items:
           - enum:
+              - acer,aspire1
               - qcom,sc7180-idp
           - const: qcom,sc7180