From patchwork Thu Apr 6 19:41:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 80420 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1266975vqo; Thu, 6 Apr 2023 12:57:54 -0700 (PDT) X-Google-Smtp-Source: AKy350ZGfQQr7TX864r9EUF6h/8HumpNcYiYIdplEs7CwUr2CMwrfKEjaaNIucuQy8+Py2tGeGH1 X-Received: by 2002:aa7:9404:0:b0:619:53de:8880 with SMTP id x4-20020aa79404000000b0061953de8880mr88883pfo.16.1680811073963; Thu, 06 Apr 2023 12:57:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680811073; cv=none; d=google.com; s=arc-20160816; b=PMmJbfHpK1/3AaKZPCeYHexX/CfTeeFRlZGTChVvxBqWNk7ldZy+Sy4HxIF6167zIP B4cfwuDPnZhYKaKgXpl7HXgCOrPz68FmdGxy2NaDyeej0ZPqkqJ8h4qPx1QGqxxQHe2G jvMhA45EfNlPGwCTPm76rPxSX0eu43/G9LlOdB9//7qWPlFgYFAlZUmda1ffJHNoUrPj P1ycaaMk9BI4Ikkx5lAEIGZa3Cqix1LW70f8PbgF56ZNdLLUqlUqxPi8Y6UXvrZq+uoo LQqRNbO6BUPHH147cVFLdNBQ4z4GTzbmffLylkXZAk+xcH/aTAhNmosIP8wyjSnXZ1XC XUZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/cXCL/lhl2q9N+8AhilWbHqXjXE0F8hhkrOWrfcURFM=; b=Zt6IizVOxNr+Qy1mePpxX1SQ+MuygjS1pX8hQDoCCisehgADplmKZi8Waj2mIw8DlT bH2MRD/bOp21lBhe+xwJQxxfzWHPymlBJCdWSygo3hvQbK8l8ItsuwVgKHLaqVX+wCOH RbElfpvleVXIZSaBeZVDGYGA3WFe/v94q0MdlawPTjhCtV1QpJAJmzmROoB3O8yk6Iq+ YCesvMQxPbH1ZpSbz99k8DJ5vqE4F7gCWI99L+qCr8zEVFGn6SMaF4w8NMIbTRLS2+dU ARQvtECn1RXVXrfpxjwoI+sAWMV9RgBo6IOV3moPq3/TkGP3HqLQ3dImRjWPjoycSGla x2lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=EUXiqy5X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c9-20020aa79529000000b00627ec453561si2105678pfp.99.2023.04.06.12.57.41; Thu, 06 Apr 2023 12:57:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=EUXiqy5X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237464AbjDFTml (ORCPT + 99 others); Thu, 6 Apr 2023 15:42:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237472AbjDFTm0 (ORCPT ); Thu, 6 Apr 2023 15:42:26 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0AAAA245; Thu, 6 Apr 2023 12:42:21 -0700 (PDT) Received: from localhost (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 81D2866031ED; Thu, 6 Apr 2023 20:42:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680810140; bh=3rBxNv391K3rouaSGtWY3Lj00PK9hBEW9sLwGyEnlTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EUXiqy5XrwJiWDpluiGuRSuDuPcb2xZLn6UTsz5p1jUmRonWnMEBji9XPm6hGS0Nu bCatyGmEkkJTjWin7L5ipoW694UikATPzvbvBaEY3BeR4mxb0Xor5s+EOjFwDApodX D7EG+UkH7xFKFEuSRD2mYgFRh1dR2NEIy3jQoYvW0S4L21BFvl6gWZCoTeJa7QU8us 4qjppkApegQMDfF2oSHdJQAgNT3BYYPLfMUP2xGLwIYvzKquDf9fkXSVr1c/vWe8Ai qjHnT4eqyp7bvuW1g1NiSCV0r1qeazVzlQtPbucscHhSlqHZ24t+9XPw6fhw4V6jV/ lcoqXnRCFwA8Q== From: Cristian Ciocaltea To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Bjorn Andersson , Joseph Chen , Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com Subject: [PATCH v3 6/8] regulator: fan53555: Improve vsel_mask computation Date: Thu, 6 Apr 2023 22:41:56 +0300 Message-Id: <20230406194158.963352-7-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230406194158.963352-1-cristian.ciocaltea@collabora.com> References: <20230406194158.963352-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762458152637894908?= X-GMAIL-MSGID: =?utf-8?q?1762458152637894908?= In preparation for introducing support for additional regulators which do not use the maximum number of voltage selectors available for a given mask, improve the mask computation formula by using fls(). Note fls() requires the bitops header, hence include it explicitly and drop bits.h which is already pulled by bitops.h. Signed-off-by: Cristian Ciocaltea --- drivers/regulator/fan53555.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index 181e5eb00e7a..39c9c29f4ff6 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -8,7 +8,7 @@ // Copyright (c) 2012 Marvell Technology Ltd. // Yunfan Zhang -#include +#include #include #include #include @@ -486,7 +486,7 @@ static int fan53555_regulator_register(struct fan53555_device_info *di, rdesc->min_uV = di->vsel_min; rdesc->uV_step = di->vsel_step; rdesc->vsel_reg = di->vol_reg; - rdesc->vsel_mask = di->vsel_count - 1; + rdesc->vsel_mask = BIT(fls(di->vsel_count - 1)) - 1; rdesc->ramp_reg = di->slew_reg; rdesc->ramp_mask = di->slew_mask; rdesc->ramp_delay_table = di->ramp_delay_table;