Message ID | 20230406190030.968972-4-allenwebb@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1249669vqo; Thu, 6 Apr 2023 12:20:05 -0700 (PDT) X-Google-Smtp-Source: AKy350aSlRbglDlj3eVblJGcX4Pw5ekygZ4Xr/9nrMSv2rGtogVKYCvFQbzRzXb7ChrRoALBCjOo X-Received: by 2002:a05:6402:798:b0:502:8f49:2553 with SMTP id d24-20020a056402079800b005028f492553mr495771edy.25.1680808805257; Thu, 06 Apr 2023 12:20:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680808805; cv=none; d=google.com; s=arc-20160816; b=pD3VBMtzuQICvSSh0WBLvC47S8xII9CxK7tQc2Ze55KZ5AcYdwkZEBRel2+MHhV5+k dELyKS+DbdQDnjjc3BsqPO21n2EFgAU+m15oEWGvIjJ4KX6tV4wbQpygIWSrUIWuTWdX Vx9MRQF2nxlNjAIiMTRn7nmfIKHkoD9xcVdvlOD3pk9+UXtkcrFVYZ6alrs8XANj2gdK twjmso1qXM2Yt/yiKD1SPVYfdiT4K0M2TtsVsP/SRgg9p2V4a55VQsixL4PUCFkRGGID o9oMFOx1J9I2weF330jf8GD2RyItxf941oa+yF+efHXZMLlErRJTbzv7z79EXzJ1li5N tKPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=CIaNzDoEfkQUCUs5a1+ah5UqZ1hq5cACYGIKF90PLWA=; b=WWr25E84e3Mf+zx/jHaxVkGaXhniSi2/0Jh95z1CgVm2AivbqNN7UJcWVD8sdcrqCv OHdbBk4dm7rI/LQBLEyfll7y+vWL3xwCTy67I21hlyZVSdEZUk6JcxHKrPw02MV4XzAJ 8OHtk+lT6EgQXyfQkUUR6d4rRNUub0ZZibYqJB5LvUJbRJJ/k1wn5jJFapR03wTQ4s34 ajZJaobu/XOUqh4yi+sXjtkblEKt9RSD47ybD3AeK4NZvqhPP8/YuJT/4jFuuHBIbd5/ OXUf4O9FR1IDYc2Ym5guqwb+Ez+2KS9XucEqbmXWyf9hOkl+22TIbOPwBRico3r8qPpX sBRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=G+FTw3D1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m20-20020aa7d354000000b00502250fa5a5si1718299edr.470.2023.04.06.12.19.40; Thu, 06 Apr 2023 12:20:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=G+FTw3D1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240362AbjDFTBR (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Thu, 6 Apr 2023 15:01:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240336AbjDFTBG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 6 Apr 2023 15:01:06 -0400 Received: from mail-il1-x14a.google.com (mail-il1-x14a.google.com [IPv6:2607:f8b0:4864:20::14a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 832E893D2 for <linux-kernel@vger.kernel.org>; Thu, 6 Apr 2023 12:01:01 -0700 (PDT) Received: by mail-il1-x14a.google.com with SMTP id d11-20020a056e020c0b00b00326156e3a8bso20692805ile.3 for <linux-kernel@vger.kernel.org>; Thu, 06 Apr 2023 12:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680807661; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=CIaNzDoEfkQUCUs5a1+ah5UqZ1hq5cACYGIKF90PLWA=; b=G+FTw3D1oOQIjnAKB1cpn9CiPMPKCCFM4zdri/XtQJGkhM8ftL306NfOcRuhgBJwAT +mqD0LOE5YJzkUY6ePsFoGVjZiuuVZ9E2USexjk/EUU97k0/6RzsAAanDkVOThd1NSb/ UHy8zFuNtffS3eWlDckeeAT9oCY7xDJSH2ttDYfw5Ys4YqfON7UCSPfniEHkJXIicK5X pym1+Tk0FtNI+3SFj6R7I0VHLqY1yU3s7SCpVrnruhY/CbD+oW8s5P5fV208J/K1wmOr VQqc6oZ6PtBD6O5hhHqZblnYB84HAIivUECRQzO7E8yY+rSsgFhBq+ttRv64b/8RpqGV 7E3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680807661; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CIaNzDoEfkQUCUs5a1+ah5UqZ1hq5cACYGIKF90PLWA=; b=ldmf2bixK4+UUaXaCC0/MwE8VAX1JwuImwpySQxxoMuxzRpq8ECZg1CSNBaok7+4Xl 4lnPL+fcdlJ878d1GYJLTYQiBVIA0PG+ZVKpBKPX3P3/J67oAwbgLYSZ3wavXdlO6BWb JGyyzBX2jt/VAeQsgcC+f/MawebawFZsQU6j4r80PshOzrdUD2fa4YUfb05/GqIXTkTl 0XDqcFFTjXKqxjyi2KwQ2AXNMPa+nKsq8mCvrN0V881crCeW8Y4KdxacEak9SQiEzAIn OhneT8xkG5tW0lUBwaDOl0goQHSd1pCizt0OfGSwl8tiRqLLrcMRrlONjnpADIKiSXLd M5nw== X-Gm-Message-State: AAQBX9fz6BqXi8a3kmBAc0Lqv7zrDghxMi//koj6PkQi2a2tatT1qxG9 zphz9dflw3csqJzxGUb/DLh1K+YnkXgvA4g= X-Received: from allenwebb.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:12e8]) (user=allenwebb job=sendgmr) by 2002:a02:a10c:0:b0:405:8be:eaaa with SMTP id f12-20020a02a10c000000b0040508beeaaamr6056313jag.5.1680807660861; Thu, 06 Apr 2023 12:01:00 -0700 (PDT) Date: Thu, 6 Apr 2023 14:00:22 -0500 In-Reply-To: <20230406190030.968972-1-allenwebb@google.com> Mime-Version: 1.0 References: <20221219204619.2205248-1-allenwebb@google.com> <20230406190030.968972-1-allenwebb@google.com> X-Mailer: git-send-email 2.40.0.577.gac1e443424-goog Message-ID: <20230406190030.968972-4-allenwebb@google.com> Subject: [PATCH v10 03/11] stmpe-spi: Fix MODULE_DEVICE_TABLE entries From: Allen Webb <allenwebb@google.com> To: "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: gregkh@linuxfoundation.org, mcgrof@kernel.org, christophe.leroy@csgroup.eu, nick.alcock@oracle.com, Allen Webb <allenwebb@google.com>, kernel test robot <lkp@intel.com> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.7 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762455773410651913?= X-GMAIL-MSGID: =?utf-8?q?1762455773410651913?= |
Series |
Generate modules.builtin.alias from match ids
|
|
Commit Message
Allen Webb
April 6, 2023, 7 p.m. UTC
A one character difference in the name supplied to MODULE_DEVICE_TABLE
breaks compilation for STMPE_SPI after built-in modules can generate
match-id based module aliases. Since this wasn't being used before and
builtin aliases aren't needed in this case, remove it.
This was not caught earlier because STMPE_SPI can not be built as a
module and MODULE_DEVICE_TABLE is a no-op for built-in modules.
Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@intel.com/
Signed-off-by: Allen Webb <allenwebb@google.com>
---
drivers/mfd/stmpe-spi.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Thu, Apr 06, 2023 at 02:00:22PM -0500, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks compilation for STMPE_SPI after built-in modules can generate > match-id based module aliases. Since this wasn't being used before and > builtin aliases aren't needed in this case, remove it. > > This was not caught earlier because STMPE_SPI can not be built as a > module and MODULE_DEVICE_TABLE is a no-op for built-in modules. > > Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@intel.com/ > Signed-off-by: Allen Webb <allenwebb@google.com> > --- I'm happy to take patches 1-3 thorugh modules-next, but please try to Cc the driver maintainers on the next iteration of this patch series and let them know these are related to this work and see if you can get their ACKs to go through another tree for this purpose. Luis
On Thu, Apr 06, 2023 at 02:00:22PM -0500, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks compilation for STMPE_SPI after built-in modules can generate > match-id based module aliases. Since this wasn't being used before and > builtin aliases aren't needed in this case, remove it. > > This was not caught earlier because STMPE_SPI can not be built as a > module and MODULE_DEVICE_TABLE is a no-op for built-in modules. > > Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@intel.com/ > Signed-off-by: Allen Webb <allenwebb@google.com> > --- Oh feel free to add Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> on patches 1-3. Luis
diff --git a/drivers/mfd/stmpe-spi.c b/drivers/mfd/stmpe-spi.c index e9cbf33502b3..e9cb6a635472 100644 --- a/drivers/mfd/stmpe-spi.c +++ b/drivers/mfd/stmpe-spi.c @@ -129,7 +129,6 @@ static const struct spi_device_id stmpe_spi_id[] = { { "stmpe2403", STMPE2403 }, { } }; -MODULE_DEVICE_TABLE(spi, stmpe_id); static struct spi_driver stmpe_spi_driver = { .driver = {