From patchwork Thu Apr 6 17:18:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 80375 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1193746vqo; Thu, 6 Apr 2023 10:36:03 -0700 (PDT) X-Google-Smtp-Source: AKy350YmNuolOPY4aE9k0lmbucZi4Xyt8i8dTW1zNiWUnH09+1ETpsZsuJWxiVqhh2tMFDCHXHoO X-Received: by 2002:a05:6a20:6aa6:b0:cc:d96c:1090 with SMTP id bi38-20020a056a206aa600b000ccd96c1090mr377526pzb.2.1680802563127; Thu, 06 Apr 2023 10:36:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680802563; cv=none; d=google.com; s=arc-20160816; b=X6+rXWG4sBjLwnzdGtERg2dtROmH8vU1uZ/rp4+ihn7BoRf6w0z/wgoovLJUFBKzLO ktf/xaUYV4anFj8LYnVpWta+eeGymh5FQ7dK6I50e3i29tzx0UJvph5tUTu4Xs0YjNbK 5Ydq+5IrcC1TJC1lySolWNSWuoQUGBgr+CylV+faOCEGfRMWnKlcA43lHh7KVggoBLoj iwi/9svmxb2MxCWiiDC2drIZ52mjw+E1sOA4DN5Y1SEso1DkXF8TCGqaK9Mf21Zo2Vp3 t6pp00CubChtpPiV9VQMLPR2p9q7E4ha6u8R4vuQswz0RpmAdMweIhHwXLqdmaAQI4Oh jmHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7dt069c8NJSutavb/KHBQd046A/DpjlsUVruXM3SBao=; b=Iq7nAbsRZ1K7c7+aEOWxqrkx49pDKp6YRdeeH3+Ps7g+qslGjCEt/tAozfuZ42J8if xtixD1W0O2ielWB8gHGrX53A8ZbozBO+VxhO8X4gQTIzeq/QWJGYky3TbtZYWrdqaVoX E6ECQwc0stAhmUTb7lpuCUqCcgysiHYX70tviI98/R67ICeYEZniIJeqhMUohnePnW0I mP/MimOqVbbV7guIAnZJuOq2pcPF5BFus0YEzG/4S7DVaoZs4QvAhLOW+RlHu6H9ylKR W7L1l9bdwgWqgJpeUXXW86xdeiCm/WIvaiBJAzGzKWcFgDdWM5UmQhv51Fl9qOKdf+/7 k7eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DqNAB+Dk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs127-20020a632885000000b0050b1a4d8625si1683663pgb.723.2023.04.06.10.35.49; Thu, 06 Apr 2023 10:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DqNAB+Dk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239398AbjDFRSb (ORCPT + 99 others); Thu, 6 Apr 2023 13:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239513AbjDFRS0 (ORCPT ); Thu, 6 Apr 2023 13:18:26 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC3AC977F; Thu, 6 Apr 2023 10:18:21 -0700 (PDT) Received: from localhost (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 725BE66031CB; Thu, 6 Apr 2023 18:18:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680801500; bh=lFOZ5esxl/tbYIcE53Cn4DHfBeM2O3R87VdL+HeZPkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DqNAB+DkL1pKNih8XoenkmU0wKLDk8DyjxEBQX7AmLSJH/EqJywyOurgpcXYtfrO+ qg33/YtaBeISAjtp/4dM1kNpIIjialOUuTaDhukDpPrDyAwwhPoCMu6O0RV2FLmXiO NoEFu4vqxldA8AraNJWP9aTJuWbmhSNffr5kok0hZoNEansUfYziZyZUGHXLb9NE+g acQjwVJ6ZUCxXgBjveTNunoFId7TqA5T3j2m6+jfrZKZYHxOb+WjHAChxrYRiLUUFe o4c4CMMMXm0/dCRRM8T3uyZ69froNwKTJ/ISRgTQa64ghhBzZR6CNIEVbVsugmlhsZ gJJfwdqCj87gQ== From: Cristian Ciocaltea To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Bjorn Andersson , Joseph Chen , Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com Subject: [PATCH v2 3/8] regulator: fan53555: Fix wrong TCS_SLEW_MASK Date: Thu, 6 Apr 2023 20:18:01 +0300 Message-Id: <20230406171806.948290-4-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230406171806.948290-1-cristian.ciocaltea@collabora.com> References: <20230406171806.948290-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762449228858816007?= X-GMAIL-MSGID: =?utf-8?q?1762449228858816007?= The support for TCS4525 regulator has been introduced with a wrong ramp-rate mask, which has been defined as a logical expression instead of a bit shift operation. For clarity, fix it using GENMASK() macro. Fixes: 914df8faa7d6 ("regulator: fan53555: Add TCS4525 DCDC support") Signed-off-by: Cristian Ciocaltea --- drivers/regulator/fan53555.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index 0754c370a21c..4d2104c3a077 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -61,7 +61,7 @@ #define TCS_VSEL1_MODE (1 << 6) #define TCS_SLEW_SHIFT 3 -#define TCS_SLEW_MASK (0x3 < 3) +#define TCS_SLEW_MASK GENMASK(4, 3) enum fan53555_vendor { FAN53526_VENDOR_FAIRCHILD = 0,