From patchwork Wed Apr 5 19:36:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: y86-dev X-Patchwork-Id: 79887 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp551372vqo; Wed, 5 Apr 2023 12:49:12 -0700 (PDT) X-Google-Smtp-Source: AKy350Z0YtkstoJxZR1QmqsS0th1kaEXtlaBowVixIqlxolrwUFZkvw8P4QIm5aDppe+qx2Jqh4Q X-Received: by 2002:a17:90b:3911:b0:23b:4438:e9ee with SMTP id ob17-20020a17090b391100b0023b4438e9eemr3484141pjb.12.1680724152661; Wed, 05 Apr 2023 12:49:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680724152; cv=none; d=google.com; s=arc-20160816; b=Uxdx4s18PVP+0/g2gTQsFOOFlZvFJstU0EuCYBWGH1qzhoIQShR7JbjM3WlhfyYe31 F8nXgAtC7SG85sgC+crAByBQnFlPoibawc/pC31WRMGbPWr5w/nKx6c9J5QOEBHn17Hf UeespccDB6Ke6D1Wvc5uZbzySVoIsuTjjjhh/yVWtfy2sdfziBrZvTfUOOM36TcC2VPq 5YNytVwW8uMNnTKq28kzjunNpv2IDLZXlBV6AIi2OqXUoehQ6Xu7nuR5bqg50iwfGLzV nF8+rtuJc1SDBp48EoVFqKx3rRAWmSdrQn4jIxFZfpZ7da5aOWV7yF4BLBO1FAqxfJsG KEzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:references:in-reply-to:message-id:subject:cc:from:to :dkim-signature:date; bh=1WSR+3j5APk6WFOfsZYaDLZ1ObxYh9T91Sr8wPbfRw8=; b=PKy3dRzHUBJFREOQiw+lRHMo9eardko5Apbn5450+/de2l/3migcV2yrue38OTLTBh L8SVUUIvIKiBD76362HuzzHSAoiOkZidG1C6M3eD9eVtVtfgzefIAsFo8PsyI0aNvzAn aRyJp6ftni7gr5yeHb0F+tdVF+lzk2PmbCUNSADNpBxmlcmPtrbKyDWE7CV5iJgl+r1y ulE2NWNahjKgPDvoUz86CgGC+vl8NB9pyu30/X3j16PkWD5VrzKtlI2RWiass3OxrIys 7AYSbj6eCEzHY/Sa0JUntkXVIYiHx3oXpNo2c7zCaRFmPFOq1Csrykf5sSzswYoG+vxi ZzoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b="gIAC/mOO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a17090ad34800b0023d05a9b16fsi1965522pjx.165.2023.04.05.12.49.00; Wed, 05 Apr 2023 12:49:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b="gIAC/mOO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234174AbjDETiE (ORCPT + 99 others); Wed, 5 Apr 2023 15:38:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233978AbjDEThr (ORCPT ); Wed, 5 Apr 2023 15:37:47 -0400 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8AB47ED3; Wed, 5 Apr 2023 12:37:23 -0700 (PDT) Date: Wed, 05 Apr 2023 19:36:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1680723420; x=1680982620; bh=1WSR+3j5APk6WFOfsZYaDLZ1ObxYh9T91Sr8wPbfRw8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=gIAC/mOOQsrGPHeH8MWVmjbtNZMWpl3fvw6wzhswjwD+kTxKAikOdGjIYqZrgiDgO cLnku8pMSgkAr8LUUqTiNG/rkTYdzlNTIE++lzbtQ9FAbxeopU7Umzk4u71AiRIvUj nGKHGH6DrAnFJ6AXx43be8qId2ZEpaPMxfF0gSL8+YVtzWbNoRbs03z7OOmPjEyZmW rc4bPNouOWn3BwYCL4Qm9AMu1duo8VES6XU5zR6NeZqs4uzIqjNgp0j+v6Iov68jU3 OTmUHo0uZzeYjLKSP9htEdL/0CdLwjEE0H48tNPLaWZIrA20VdgUoRPvqMZHoBQZRZ FRiZxNv92S3eg== To: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Alice Ryhl , Andreas Hindborg From: Benno Lossin Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Benno Lossin , Alice Ryhl , Andreas Hindborg Subject: [PATCH v6 13/15] rust: types: add common init-helper functions for `Opaque` Message-ID: <20230405193445.745024-14-y86-dev@protonmail.com> In-Reply-To: <20230405193445.745024-1-y86-dev@protonmail.com> References: <20230405193445.745024-1-y86-dev@protonmail.com> Feedback-ID: 40624463:user:proton MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762367008784292637?= X-GMAIL-MSGID: =?utf-8?q?1762367008784292637?= Add helper functions to more easily initialize `Opaque` via FFI and rust raw initializer functions. These functions take a function pointer to the FFI/raw initialization function and take between 0-4 other arguments. It then returns an initializer that uses the FFI/raw initialization function along with the given arguments to initialize an `Opaque`. Signed-off-by: Benno Lossin Reviewed-by: Alice Ryhl Reviewed-by: Andreas Hindborg Cc: Gary Guo --- rust/kernel/init.rs | 9 +++++++++ rust/kernel/types.rs | 47 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+) -- 2.39.2 diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs index ffd539e2f5ef..a501fb823ae9 100644 --- a/rust/kernel/init.rs +++ b/rust/kernel/init.rs @@ -177,6 +177,14 @@ //! } //! ``` //! +//! For the special case where initializing a field is a single FFI-function call that cannot fail, +//! there exist helper functions [`Opaque::ffi_init`]. These functions initialize a single +//! [`Opaque`] field by just delegating to the FFI-function. You can use these in combination with +//! [`pin_init!`]. +//! +//! For more information on how to use [`pin_init_from_closure()`], take a look at the uses inside +//! the `kernel` crate. The [`sync`] module is a good starting point. +//! //! [`sync`]: kernel::sync //! [pinning]: https://doc.rust-lang.org/std/pin/index.html //! [structurally pinned fields]: @@ -187,6 +195,7 @@ //! [`impl PinInit`]: PinInit //! [`impl Init`]: Init //! [`Opaque`]: kernel::types::Opaque +//! [`Opaque::ffi_init`]: kernel::types::Opaque::ffi_init //! [`pin_data`]: ::macros::pin_data use crate::{ diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs index ff2b2fac951d..dbfae9bb97ce 100644 --- a/rust/kernel/types.rs +++ b/rust/kernel/types.rs @@ -2,6 +2,7 @@ //! Kernel types. +use crate::init::{self, PinInit}; use alloc::boxed::Box; use core::{ cell::UnsafeCell, @@ -248,6 +249,52 @@ impl Opaque { } } +macro_rules! opaque_init_funcs { + ($($abi:literal $name:ident($($arg_name:ident: $arg_typ:ident),*);)*) => { + impl Opaque { + $( + /// Create an initializer using the given initializer function. + /// + /// # Safety + /// + /// The given function **must** under all circumstances initialize the memory + /// location to a valid `T`. If it fails to do so it results in UB. + /// + /// If any parameters are given, those need to be valid for the function. Valid + /// means that calling the function with those parameters complies with the above + /// requirement **and** every other requirement on the function itself. + pub unsafe fn $name<$($arg_typ),*>( + init_func: unsafe extern $abi fn(*mut T $(, $arg_typ)*), + $($arg_name: $arg_typ,)* + ) -> impl PinInit { + // SAFETY: The safety contract of this function ensures that `init_func` fully + // initializes `slot`. + unsafe { + init::pin_init_from_closure(move |slot| { + init_func(Self::raw_get(slot) $(, $arg_name)*); + Ok(()) + }) + } + } + )* + } + } +} + +opaque_init_funcs! { + "C" ffi_init(); + "C" ffi_init1(arg1: A1); + "C" ffi_init2(arg1: A1, arg2: A2); + "C" ffi_init3(arg1: A1, arg2: A2, arg3: A3); + "C" ffi_init4(arg1: A1, arg2: A2, arg3: A3, arg4: A4); + + "Rust" manual_init(); + "Rust" manual_init1(arg1: A1); + "Rust" manual_init2(arg1: A1, arg2: A2); + "Rust" manual_init3(arg1: A1, arg2: A2, arg3: A3); + "Rust" manual_init4(arg1: A1, arg2: A2, arg3: A3, arg4: A4); +} + /// A sum type that always holds either a value of type `L` or `R`. pub enum Either { /// Constructs an instance of [`Either`] containing a value of type `L`.