From patchwork Wed Apr 5 16:50:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eddie James X-Patchwork-Id: 79808 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp453338vqo; Wed, 5 Apr 2023 09:56:33 -0700 (PDT) X-Google-Smtp-Source: AKy350asvXyzr20m7NHPQ2cpwG8NOFwj73I1137noLYrugJV+mxdRO2j96qbODZWlPk3a3cMnr8h X-Received: by 2002:a17:906:4cda:b0:947:d9b1:89a3 with SMTP id q26-20020a1709064cda00b00947d9b189a3mr3040903ejt.27.1680713793525; Wed, 05 Apr 2023 09:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680713793; cv=none; d=google.com; s=arc-20160816; b=Ei+A2+5L1Er0Kp2LrNgUJpyaWNzeiMSNvsaNCpnr72P1Luq1ezH259NkYgBufEscnS JP50wbTyy8hpvydCb/tsJNwYiokcsg/uGY2wISbT4+jxiu8CIj4UDtw12YxNzz4VCkyU s7o1WZsIdgVhCQQ/0L+NuAbtgjDNzanFiySns4xbHCe24S/nwn1PcyNb+v2thyxIWFXH 4kSpxlyuS2oSciFRadM26358WJTgC2U11DCf6QO0QI3VPZVNHScRQQvETGlcsWrjZZWd 4Uxj3tzuZ4BT3FMJa4XghZqWiv8QN/nv+wuku6TVi7FBjjqQ+wbIoQzzjGQYpyUSC2ur DF2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UXgOY7AuIGFAsaQsdgBTKV+Xqw3tw6NbkRPvrtDm+Qg=; b=FOeeg0S1zQLOiF3bwD9oAe+9ogkduKDKYCd1aCIxmLkzBz8PktsjqF32bS+QP64UT7 4DEIsOdCw/K2zljgWIuSRItNZqqRzcq2xzyTKYmFT35UkXEiyN2M2TXKMQapJuvz5YtU eFqaOzmsasrY6/PQUqG8tZuNd9nVo/ORcOq4bYOgGqVMAihArV0NrZcf9iYNcDCVrjKr sahykbHOQr1eYXQ1ZXm7Y4rhwnkVtb7AwD9CDA8N4CvTs1P6hsD/nq8rvjHo6N/7m4co wRlZlE8Y1pcYWqVvzdIdk6YIV/aCIWoEkBmHOZDjWngiwWM4Q7O0Gkmf6dxfdLMCIGL3 +KOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bs+K18wZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ku11-20020a170907788b00b00944041f6c81si11586335ejc.476.2023.04.05.09.56.08; Wed, 05 Apr 2023 09:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bs+K18wZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233448AbjDEQuo (ORCPT + 99 others); Wed, 5 Apr 2023 12:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231967AbjDEQun (ORCPT ); Wed, 5 Apr 2023 12:50:43 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 472D43AAB; Wed, 5 Apr 2023 09:50:42 -0700 (PDT) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 335FmPfs027578; Wed, 5 Apr 2023 16:50:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=UXgOY7AuIGFAsaQsdgBTKV+Xqw3tw6NbkRPvrtDm+Qg=; b=bs+K18wZUVZVwZhNBYTGkjwVJE+XPMMdCMmdj/sYkV4zbEfz10aiO6v5lxG++wFy3BMK uAoP1nD1R1AbH1SKC8UrI+IjjVu+xFhGUhfbyD5Cbk/gmYoWoACPPGukQqiQkHLgWiU8 wx/ggv8qeTvmaM930ySsngJh4MkZ2Keb26hWVD1t3GObXhTs0Ar8oDjAy/R6vm/20jwJ FBDC0A9aCYVtzqPvBJl40bB10AuYsHSg/pNDHpM6UXdsEJ4y5WobK4J4XmvrOCb+b8iM 3BZH/gBvzL7CK69SaPpSr26//UC8bfOD0MgF48ivSi7y9NTgOq979Ta9CIBjybGSvq4a 4g== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3psaamvqa1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Apr 2023 16:50:36 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 335F9JNE017698; Wed, 5 Apr 2023 16:50:35 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3ppc87y75p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Apr 2023 16:50:35 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 335GoYnd24576592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Apr 2023 16:50:34 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89BD258054; Wed, 5 Apr 2023 16:50:34 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2FAD5803F; Wed, 5 Apr 2023 16:50:33 +0000 (GMT) Received: from slate16.aus.stglabs.ibm.com (unknown [9.160.127.161]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 5 Apr 2023 16:50:33 +0000 (GMT) From: Eddie James To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, lee@kernel.org, pavel@ucw.cz, Eddie James Subject: [RESEND] leds: Ensure hardware blinking turns off when requested Date: Wed, 5 Apr 2023 11:50:28 -0500 Message-Id: <20230405165028.73579-1-eajames@linux.ibm.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: PvPSYGVOZCqw9KDxnNvoCOsffa5zoKz2 X-Proofpoint-ORIG-GUID: PvPSYGVOZCqw9KDxnNvoCOsffa5zoKz2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-05_11,2023-04-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1011 spamscore=0 suspectscore=0 phishscore=0 mlxlogscore=584 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304050149 X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762356146266037157?= X-GMAIL-MSGID: =?utf-8?q?1762356146266037157?= If an LED is blinking through the hardware and the trigger is deactivated, the driver will set the brightness to 0 to disable blinking. However, if the LED driver doesn't support non-blocking operations, the request for setting brightness to 0 will get queued. Then if a user requests a new non-zero brightness before the request for 0 brightness is executed, the LED blinking will not get disabled since the brightness will simply be updated. Fix this by flushing the workqueue before updating the requested brightness. Fixes: 4d71a4a12b13 ("leds: Add support for setting brightness in a synchronous way") Signed-off-by: Eddie James --- drivers/leds/led-class.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 9255bc11f99d..78a270300d30 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -57,6 +57,8 @@ static ssize_t brightness_store(struct device *dev, if (state == LED_OFF) led_trigger_remove(led_cdev); + /* flush out any request to disable blinking */ + flush_work(&led_cdev->set_brightness_work); led_set_brightness(led_cdev, state); flush_work(&led_cdev->set_brightness_work);