From patchwork Wed Apr 5 15:27:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79771 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp396653vqo; Wed, 5 Apr 2023 08:32:05 -0700 (PDT) X-Google-Smtp-Source: AKy350a+iGMj0DBgZJ49IL+NcGIIeNKc/SCMZVmZY89JPB6TqwQG3Hw69vWDwzea/ota5IlpDhJK X-Received: by 2002:a17:907:388:b0:933:3aa7:57a7 with SMTP id ss8-20020a170907038800b009333aa757a7mr3138636ejb.49.1680708725013; Wed, 05 Apr 2023 08:32:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680708724; cv=none; d=google.com; s=arc-20160816; b=dHYVQGHMssg7XcpjLlEZCoY65F4Wfm46aSJsFCJffK2zk4BYFGCTMx19A722Wq8PGs ZaERCsf5dwx4TRt0Mm0nz4a4pNEQY6UWsfEfQs2g/rOEuG0Sd4PWdCNqpmh8MMpXoMwK 0fZVeDCAEr7350T2V39kGwnvbisuL2iN6sKBglzacudYAyS79OP4JUxdM/9c6YpeQ/0Y eqlyPqU0D2gXkKl0Hk68ByZFNseD/8KPI2UaEZ0PPxZKYyGVLMOFAsOPcShNfDDSXR86 qbq2OzRQVcdQfdHtMatumGWt2JPKmaazwzaw33ObgKRVW7VyDomwnPvUOmA1VtfpnMFK Ahww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4mEldU33bESQBxc/3t6z+A5E7f4jk4qfy5vnE+Hz+Jo=; b=g11OTyghpXXUIV5x+HA1rklb0UdxplPlElzmi+iDYcufWXPKBRiVD6ZBpeTXwto4w2 AfFZwRJpGqe8t0SzgOuWMw1w0AdUQopQ7524BtVoKRwhXE3ttSrHZpb7CfmKUnSSigfa vumbpXGA0GVWA/7UhTB1kT395yuLmiEKURH9jIA4cLlCUAQkwKQpE2uyESFrRmndoi8y b0cun87WvqOpw2N8+PoSTfWrb+fSsvgGXd4+HD6B4KvxFJsd3MCS/vyoBNQaLoCM6cas XcyC0EjSMDMNKW4/HA+fomIzcYlk/MOv79Is729SBZEjBxrWFU8ykYhSw5ziRCDCo8By 9emA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kahV4+Pd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h5-20020a17090619c500b0093337d30dadsi5962205ejd.522.2023.04.05.08.31.39; Wed, 05 Apr 2023 08:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kahV4+Pd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238729AbjDEP2p (ORCPT + 99 others); Wed, 5 Apr 2023 11:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238179AbjDEP2e (ORCPT ); Wed, 5 Apr 2023 11:28:34 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6B0B40DA for ; Wed, 5 Apr 2023 08:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680708512; x=1712244512; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yHr3YfcH0isSmBGhveOFvMlA78zsK4oy4JPk9GZ0c+o=; b=kahV4+PdJT+XinlAM/aR4gsAUHl3SOgcGhanmK8/OvJoqHrHPyK1Wx2I 6Y8MEpTVuXsABRQlh8K+1glL9VkqYWx9vYG77u9XCztCJ8jUOZRV1DGGr 7DjWErKukjLpifco1EXuIrcXZTbwSsc/gqiFW5ditlkZlxAxUzkTHgJSS AHPOHM+1bJgesKyeyvZ8rfYYkuZR91CBI1Z4IFyue9mLr0hE8nQBgZS5q 9eJrSBCiA12+cwm5wrxnBNoFSPoAjpwZBK97OiV/5VFIjvKSwZtOLTH0N kuzOsLRIM6UOL311DICFVMC1zOkYz8umLDxvwrzp7NQqDAW1kVrSFvBE5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345064768" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="345064768" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:27:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="756028427" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="756028427" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2023 08:27:50 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B9AF24F1; Wed, 5 Apr 2023 18:27:52 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Bumwoo Lee Subject: [PATCH v2 4/5] extcon: Use sizeof(*pointer) instead of sizeof(type) Date: Wed, 5 Apr 2023 18:27:44 +0300 Message-Id: <20230405152745.24959-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762350831898009531?= X-GMAIL-MSGID: =?utf-8?q?1762350831898009531?= It is preferred to use sizeof(*pointer) instead of sizeof(type). The type of the variable can change and one needs not change the former (unlike the latter). No functional change intended. Signed-off-by: Andy Shevchenko Acked-by: Bumwoo Lee --- drivers/extcon/extcon.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index daaded92cf80..50c5fd454488 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1098,8 +1098,7 @@ static int extcon_alloc_cables(struct extcon_dev *edev) if (!edev->max_supported) return 0; - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), + edev->cables = kcalloc(edev->max_supported, sizeof(*edev->cables), GFP_KERNEL); if (!edev->cables) return -ENOMEM; @@ -1161,14 +1160,12 @@ static int extcon_alloc_muex(struct extcon_dev *edev) for (index = 0; edev->mutually_exclusive[index]; index++) ; - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), + edev->attrs_muex = kcalloc(index + 1, sizeof(*edev->attrs_muex), GFP_KERNEL); if (!edev->attrs_muex) return -ENOMEM; - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), + edev->d_attrs_muex = kcalloc(index, sizeof(*edev->d_attrs_muex), GFP_KERNEL); if (!edev->d_attrs_muex) { kfree(edev->attrs_muex); @@ -1214,8 +1211,8 @@ static int extcon_alloc_groups(struct extcon_dev *edev) return 0; edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); + sizeof(*edev->extcon_dev_type.groups), + GFP_KERNEL); if (!edev->extcon_dev_type.groups) return -ENOMEM; @@ -1293,7 +1290,7 @@ int extcon_dev_register(struct extcon_dev *edev) spin_lock_init(&edev->lock); if (edev->max_supported) { edev->nh = kcalloc(edev->max_supported, sizeof(*edev->nh), - GFP_KERNEL); + GFP_KERNEL); if (!edev->nh) { ret = -ENOMEM; goto err_alloc_nh;