[2/2] soc: qcom: Introduce RPM master stats driver
Commit Message
Introduce a driver to query and expose detailed, per-subsystem (as opposed
to the existing qcom_stats driver which exposes SoC-wide data) about low
power mode states of a given RPM master. That includes the APSS (ARM),
MPSS (modem) and other remote cores, depending on the platform
configuration.
This is a vastly cleaned up and restructured version of a similar
driver found in msm-5.4.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/soc/qcom/Kconfig | 11 +++
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/rpm_master_stats.c | 160 ++++++++++++++++++++++++++++++++++++
3 files changed, 172 insertions(+)
Comments
Hi Konrad,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 8417c8f5007bf4567ccffda850a3157c7d905f67]
url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/dt-bindings-soc-qcom-Add-RPM-Master-stats/20230405-230341
base: 8417c8f5007bf4567ccffda850a3157c7d905f67
patch link: https://lore.kernel.org/r/20230405-topic-master_stats-v1-2-1b1fa2739953%40linaro.org
patch subject: [PATCH 2/2] soc: qcom: Introduce RPM master stats driver
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230406/202304060002.HLUjkH63-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/76fec5cd8630399cfdb8612093bfa0a5d0d98ea9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Konrad-Dybcio/dt-bindings-soc-qcom-Add-RPM-Master-stats/20230405-230341
git checkout 76fec5cd8630399cfdb8612093bfa0a5d0d98ea9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/soc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304060002.HLUjkH63-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/soc/qcom/rpm_master_stats.c: In function 'master_stats_probe':
>> drivers/soc/qcom/rpm_master_stats.c:92:83: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat=]
92 | "Couldn't parse MSG RAM phandle idx %s", i);
| ~^ ~
| | |
| | int
| char *
| %d
vim +92 drivers/soc/qcom/rpm_master_stats.c
66
67 static int master_stats_probe(struct platform_device *pdev)
68 {
69 struct device *dev = &pdev->dev;
70 struct device_node *msgram_np;
71 struct master_stats_data *d;
72 struct dentry *dent, *root;
73 struct resource res;
74 int count, i, ret;
75
76 count = of_property_count_strings(dev->of_node, "qcom,master-names");
77 if (count < 0)
78 return count;
79
80 d = devm_kzalloc(dev, count * sizeof(*d), GFP_KERNEL);
81 if (!d)
82 return -ENOMEM;
83
84 root = debugfs_create_dir("rpm_master_stats", NULL);
85 platform_set_drvdata(pdev, root);
86
87 for (i = 0; i < count; i++) {
88 msgram_np = of_parse_phandle(dev->of_node, "qcom,rpm-msg-ram", i);
89 if (!msgram_np) {
90 debugfs_remove_recursive(root);
91 return dev_err_probe(dev, -EINVAL,
> 92 "Couldn't parse MSG RAM phandle idx %s", i);
93 }
94
95 /*
96 * Purposefully skip devm_platform helpers as we're using a
97 * shared resource.
98 */
99 ret = of_address_to_resource(msgram_np, 0, &res);
100 if (ret < 0) {
101 debugfs_remove_recursive(root);
102 return ret;
103 }
104
105 d[i].base = devm_ioremap(dev, res.start, resource_size(&res));
106 if (IS_ERR(d[i].base)) {
107 debugfs_remove_recursive(root);
108 return dev_err_probe(dev, -EINVAL,
109 "Could not map the MSG RAM slice idx %d!\n", i);
110 }
111
112 ret = of_property_read_string_index(dev->of_node, "qcom,master-names", i,
113 &d[i].label);
114 if (ret < 0) {
115 debugfs_remove_recursive(root);
116 return dev_err_probe(dev, ret,
117 "Could not read name idx %d!\n", i);
118 }
119
120 /*
121 * Generally it's not advised to fail on debugfs errors, but this
122 * driver's only job is exposing data therein.
123 */
124 dent = debugfs_create_file(d[i].label, 0444, root,
125 &d[i], &master_stats_fops);
126 if (!dent) {
127 debugfs_remove_recursive(root);
128 return -EINVAL;
129 }
130 }
131
132 device_set_pm_not_required(dev);
133
134 return 0;
135 }
136
@@ -135,6 +135,17 @@ config QCOM_RMTFS_MEM
Say y here if you intend to boot the modem remoteproc.
+config QCOM_RPM_MASTER_STATS
+ tristate "Qualcomm RPM Master stats"
+ depends on ARCH_QCOM || COMPILE_TEST
+ help
+ The RPM Master sleep stats driver provides detailed per-subsystem
+ sleep/wake data, read from the RPM message RAM. It can be used to
+ assess whether all the low-power modes available are entered as
+ expected or to check which part of the SoC prevents it from sleeping.
+
+ Say y here if you intend to debug or monitor platform sleep.
+
config QCOM_RPMH
tristate "Qualcomm RPM-Hardened (RPMH) Communication"
depends on ARCH_QCOM || COMPILE_TEST
@@ -14,6 +14,7 @@ obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o
qmi_helpers-y += qmi_encdec.o qmi_interface.o
obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o
obj-$(CONFIG_QCOM_RMTFS_MEM) += rmtfs_mem.o
+obj-$(CONFIG_QCOM_RPM_MASTER_STATS) += rpm_master_stats.o
obj-$(CONFIG_QCOM_RPMH) += qcom_rpmh.o
qcom_rpmh-y += rpmh-rsc.o
qcom_rpmh-y += rpmh.o
new file mode 100644
@@ -0,0 +1,160 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2012-2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023, Linaro Limited
+ *
+ * This driver supports what is known as "Master Stats v2", which seems to be
+ * the only version which has ever shipped, all the way from 2013 to 2023.
+ */
+
+#include <linux/debugfs.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/platform_device.h>
+
+struct master_stats_data {
+ void __iomem *base;
+ const char *label;
+};
+
+struct rpm_master_stats {
+ uint32_t active_cores;
+ uint32_t num_shutdowns;
+ uint64_t shutdown_req;
+ uint64_t wakeup_idx;
+ uint64_t bringup_req;
+ uint64_t bringup_ack;
+ uint32_t wakeup_reason; /* 0 = "rude wakeup", 1 = scheduled wakeup */
+ uint32_t last_sleep_trans_dur;
+ uint32_t last_wake_trans_dur;
+
+ /* Per-subsystem (*not necessarily* SoC-wide) XO shutdown stats */
+ uint32_t xo_count;
+ uint64_t xo_last_enter;
+ uint64_t last_exit;
+ uint64_t xo_total_dur;
+};
+
+static int master_stats_show(struct seq_file *s, void *unused)
+{
+ struct master_stats_data *d = s->private;
+ struct rpm_master_stats stat;
+
+ memcpy_fromio(&stat, d->base, sizeof(stat));
+
+ seq_printf(s, "%s:\n", d->label);
+
+ seq_printf(s, "\tLast shutdown @ %llu\n", stat.shutdown_req);
+ seq_printf(s, "\tLast bringup req @ %llu\n", stat.bringup_req);
+ seq_printf(s, "\tLast bringup ack @ %llu\n", stat.bringup_ack);
+ seq_printf(s, "\tLast wakeup idx: %llu\n", stat.wakeup_idx);
+ seq_printf(s, "\tLast XO shutdown enter @ %llu\n", stat.xo_last_enter);
+ seq_printf(s, "\tLast XO shutdown exit @ %llu\n", stat.last_exit);
+ seq_printf(s, "\tXO total duration: %llu\n", stat.xo_total_dur);
+ seq_printf(s, "\tLast sleep transition duration: %u\n", stat.last_sleep_trans_dur);
+ seq_printf(s, "\tLast wake transition duration: %u\n", stat.last_wake_trans_dur);
+ seq_printf(s, "\tXO shutdown count: %u\n", stat.xo_count);
+ seq_printf(s, "\tWakeup reason: 0x%x\n", stat.wakeup_reason);
+ seq_printf(s, "\tShutdown count: %u\n", stat.num_shutdowns);
+ seq_printf(s, "\tActive cores bitmask: 0x%x\n", stat.active_cores);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(master_stats);
+
+static int master_stats_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct device_node *msgram_np;
+ struct master_stats_data *d;
+ struct dentry *dent, *root;
+ struct resource res;
+ int count, i, ret;
+
+ count = of_property_count_strings(dev->of_node, "qcom,master-names");
+ if (count < 0)
+ return count;
+
+ d = devm_kzalloc(dev, count * sizeof(*d), GFP_KERNEL);
+ if (!d)
+ return -ENOMEM;
+
+ root = debugfs_create_dir("rpm_master_stats", NULL);
+ platform_set_drvdata(pdev, root);
+
+ for (i = 0; i < count; i++) {
+ msgram_np = of_parse_phandle(dev->of_node, "qcom,rpm-msg-ram", i);
+ if (!msgram_np) {
+ debugfs_remove_recursive(root);
+ return dev_err_probe(dev, -EINVAL,
+ "Couldn't parse MSG RAM phandle idx %s", i);
+ }
+
+ /*
+ * Purposefully skip devm_platform helpers as we're using a
+ * shared resource.
+ */
+ ret = of_address_to_resource(msgram_np, 0, &res);
+ if (ret < 0) {
+ debugfs_remove_recursive(root);
+ return ret;
+ }
+
+ d[i].base = devm_ioremap(dev, res.start, resource_size(&res));
+ if (IS_ERR(d[i].base)) {
+ debugfs_remove_recursive(root);
+ return dev_err_probe(dev, -EINVAL,
+ "Could not map the MSG RAM slice idx %d!\n", i);
+ }
+
+ ret = of_property_read_string_index(dev->of_node, "qcom,master-names", i,
+ &d[i].label);
+ if (ret < 0) {
+ debugfs_remove_recursive(root);
+ return dev_err_probe(dev, ret,
+ "Could not read name idx %d!\n", i);
+ }
+
+ /*
+ * Generally it's not advised to fail on debugfs errors, but this
+ * driver's only job is exposing data therein.
+ */
+ dent = debugfs_create_file(d[i].label, 0444, root,
+ &d[i], &master_stats_fops);
+ if (!dent) {
+ debugfs_remove_recursive(root);
+ return -EINVAL;
+ }
+ }
+
+ device_set_pm_not_required(dev);
+
+ return 0;
+}
+
+static void master_stats_remove(struct platform_device *pdev)
+{
+ struct dentry *root = platform_get_drvdata(pdev);
+
+ debugfs_remove_recursive(root);
+}
+
+static const struct of_device_id rpm_master_table[] = {
+ { .compatible = "qcom,rpm-master-stats" },
+ { },
+};
+
+static struct platform_driver master_stats_driver = {
+ .probe = master_stats_probe,
+ .remove_new = master_stats_remove,
+ .driver = {
+ .name = "rpm_master_stats",
+ .of_match_table = rpm_master_table,
+ },
+};
+module_platform_driver(master_stats_driver);
+
+MODULE_DESCRIPTION("RPM Master Statistics driver");
+MODULE_LICENSE("GPL");