Message ID | 20230404145350.45388-2-sebastian.reichel@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3090573vqo; Tue, 4 Apr 2023 07:56:29 -0700 (PDT) X-Google-Smtp-Source: AKy350be8P9uZTn5P9yLsHqv/AqA0Semdgukv0sTfoXv9ZaVNxalymIzBWJO7fTVq1aniWKPn5EB X-Received: by 2002:aa7:9a07:0:b0:62b:47fc:a968 with SMTP id w7-20020aa79a07000000b0062b47fca968mr2497492pfj.8.1680620189420; Tue, 04 Apr 2023 07:56:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680620189; cv=none; d=google.com; s=arc-20160816; b=PVQRpOe9SuzceTrt8dVrYtmqFcsEeXlDVyjGnvUJ8YcnRfuKUTgX+MWK9CqzaBK+tD 5/wQV6ZBV9cFjtht2wZNL0Zz9PQldI9B4vOp+yuxJ1I1wslc0BEPpRYhyWTTYTc+wA1E im2U6NN903YColMcGjfQRRD+FUEh+vhCqidVfV8KO18f/+vRD+WnE04WGmMtKwoCz99a 1vDFrNjyei08W+UEPjXmCycqkBmetgH5xTq7XJ4Vi2Ve4e2yQzo6TA7GxAZ+Ur76cfhZ P+hNDzUU8BLPNRDtFC35fdYo+H/RwUz0oYe8oYUqqBuAq7o/F8MuYWY7m8IDTLM+ose1 eHUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Wncee6yZVfX4D7gRVxgEJcMPEhe/rbJ77Oe2h/JsSo4=; b=kLzbKT7b0ASCm/ywRtljFu+Q5/DODFp2uVBM4oaWiCgmtxY5TtE5S+EXx39oXLJRDY YGCts0Ig2Ja+wlIuj+Lzc7krvlvwqWCLALfDmv60MQLTa0lrsQdYi3qwLGNqCQgEiWyh FULuEPEecjjScRn+tp/cP5pGJ3JTqwqNXu+iL0uypT6pwCWMAr/OQFKS1Wj7tFMZflOb y89/YE9xcKCV53sUf0vEQrsR9T+8+tXhcfXssVALVKmSzKYCm5kMhKnv5ufHxEjnQ6GR K2YHCGjmEjR6JPjC3TZkAlZch9LDuyn5hYGCfy0HB/paqZQ5TjwQFPIs+Lae668NSyQ1 NrqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ZFX5Z5Mt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b00513522ea60asi9904387pgq.615.2023.04.04.07.56.14; Tue, 04 Apr 2023 07:56:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ZFX5Z5Mt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232473AbjDDOx6 (ORCPT <rfc822;lkml4gm@gmail.com> + 99 others); Tue, 4 Apr 2023 10:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbjDDOx4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 4 Apr 2023 10:53:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F519E58; Tue, 4 Apr 2023 07:53:55 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-190-097.ewe-ip-backbone.de [91.248.190.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id B1293660316A; Tue, 4 Apr 2023 15:53:53 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680620033; bh=IZgsXXkUIeK+MqZv4Hy7oH9grr/jB03TfUzCnGkU6tI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZFX5Z5MtuoVFp1ihqnPYgnJvFgAOTjQWXVieK/Fgma1T+WTM0T6VFJoZjIx2k442z qNTBdZHzLeDihhnHvIoQceO8HCmRQ5oXzk/5jFS6bPkBw7jHeVa44EZgP8yqwQ9lmA s1+tFZpfjF4sg1kTh4Qf+KhvhckGAJ6v2lvQ6DekPgznPIwmM9XdTfdRVOnDakfUvU GC5F8khxJj05l38j4uJ6Yfdx641hQdWw8yJBdlXqG4cE5LeuO3vjWGAab3nFanLfUP E20H7YS0+G3Yvt3ulwWisNBBIH6Gnhdzpiz23fSeaZgwpmp6ODTo61iP4qHpUyq2PP f3w42dcYo0DWg== Received: by jupiter.universe (Postfix, from userid 1000) id BAD2F4807E0; Tue, 4 Apr 2023 16:53:51 +0200 (CEST) From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel <sebastian.reichel@collabora.com>, kernel@collabora.com Subject: [PATCHv1 1/3] dt-bindings: usb: Add RK3588 OHCI Date: Tue, 4 Apr 2023 16:53:48 +0200 Message-Id: <20230404145350.45388-2-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404145350.45388-1-sebastian.reichel@collabora.com> References: <20230404145350.45388-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762257995929987663?= X-GMAIL-MSGID: =?utf-8?q?1762257995929987663?= |
Series |
generic-ohci/ehci: add RK3588 support
|
|
Commit Message
Sebastian Reichel
April 4, 2023, 2:53 p.m. UTC
Add compatible for RK3588 OHCI. As far as I know it's fully
compatible with generic-ohci.
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
.../devicetree/bindings/usb/generic-ohci.yaml | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
Comments
On 04/04/2023 16:53, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index a9ba7257b884..d84732a100ba 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -44,6 +44,7 @@ properties: > - hpe,gxp-ohci > - ibm,476gtr-ohci > - ingenic,jz4740-ohci > + - rockchip,rk3588-ohci > - snps,hsdk-v1.0-ohci > - const: generic-ohci > - enum: > @@ -68,8 +69,6 @@ properties: > maxItems: 2 > > clocks: > - minItems: 1 > - maxItems: 3 The constraints here should stay. Best regards, Krzysztof
Hi Krzysztof, On Thu, Apr 06, 2023 at 09:45:11AM +0200, Krzysztof Kozlowski wrote: > On 04/04/2023 16:53, Sebastian Reichel wrote: > > Add compatible for RK3588 OHCI. As far as I know it's fully > > compatible with generic-ohci. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > --- > > .../devicetree/bindings/usb/generic-ohci.yaml | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > index a9ba7257b884..d84732a100ba 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > @@ -44,6 +44,7 @@ properties: > > - hpe,gxp-ohci > > - ibm,476gtr-ohci > > - ingenic,jz4740-ohci > > + - rockchip,rk3588-ohci > > - snps,hsdk-v1.0-ohci > > - const: generic-ohci > > - enum: > > @@ -68,8 +69,6 @@ properties: > > maxItems: 2 > > > > clocks: > > - minItems: 1 > > - maxItems: 3 > > The constraints here should stay. dtbs_check complained about the 4 RK3588 clock entries if this stays. That's why I moved them to the condition down below into the else branch. -- Sebastian
On 06/04/2023 12:51, Sebastian Reichel wrote: > Hi Krzysztof, > > On Thu, Apr 06, 2023 at 09:45:11AM +0200, Krzysztof Kozlowski wrote: >> On 04/04/2023 16:53, Sebastian Reichel wrote: >>> Add compatible for RK3588 OHCI. As far as I know it's fully >>> compatible with generic-ohci. >>> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> >>> --- >>> .../devicetree/bindings/usb/generic-ohci.yaml | 18 ++++++++++++++++-- >>> 1 file changed, 16 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> index a9ba7257b884..d84732a100ba 100644 >>> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> @@ -44,6 +44,7 @@ properties: >>> - hpe,gxp-ohci >>> - ibm,476gtr-ohci >>> - ingenic,jz4740-ohci >>> + - rockchip,rk3588-ohci >>> - snps,hsdk-v1.0-ohci >>> - const: generic-ohci >>> - enum: >>> @@ -68,8 +69,6 @@ properties: >>> maxItems: 2 >>> >>> clocks: >>> - minItems: 1 >>> - maxItems: 3 >> >> The constraints here should stay. > > dtbs_check complained about the 4 RK3588 clock entries if this > stays. That's why I moved them to the condition down below into > the else branch. Which is not what we want. We want the constraints here (the widest). Best regards, Krzysztof
Hi, On Thu, Apr 06, 2023 at 01:02:44PM +0200, Krzysztof Kozlowski wrote: > On 06/04/2023 12:51, Sebastian Reichel wrote: > >>> clocks: > >>> - minItems: 1 > >>> - maxItems: 3 > >> > >> The constraints here should stay. > > > > dtbs_check complained about the 4 RK3588 clock entries if this > > stays. That's why I moved them to the condition down below into > > the else branch. > > Which is not what we want. We want the constraints here (the widest). So it should look like this? clocks: minItems: 1 maxItems: 4 ... if rk3588: clocks: minItems: 4 maxItems: 4 else: clocks: minItems: 1 maxItems: 3 -- Sebastian
On 06/04/2023 14:33, Sebastian Reichel wrote: > Hi, > > On Thu, Apr 06, 2023 at 01:02:44PM +0200, Krzysztof Kozlowski wrote: >> On 06/04/2023 12:51, Sebastian Reichel wrote: >>>>> clocks: >>>>> - minItems: 1 >>>>> - maxItems: 3 >>>> >>>> The constraints here should stay. >>> >>> dtbs_check complained about the 4 RK3588 clock entries if this >>> stays. That's why I moved them to the condition down below into >>> the else branch. >> >> Which is not what we want. We want the constraints here (the widest). > > So it should look like this? > > clocks: > minItems: 1 > maxItems: 4 > Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index a9ba7257b884..d84732a100ba 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -44,6 +44,7 @@ properties: - hpe,gxp-ohci - ibm,476gtr-ohci - ingenic,jz4740-ohci + - rockchip,rk3588-ohci - snps,hsdk-v1.0-ohci - const: generic-ohci - enum: @@ -68,8 +69,6 @@ properties: maxItems: 2 clocks: - minItems: 1 - maxItems: 3 description: | In case the Renesas R-Car Gen3 SoCs: - if a host only channel: first clock should be host. @@ -147,6 +146,21 @@ allOf: then: properties: transceiver: false + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-ohci + then: + properties: + clocks: + minItems: 4 + maxItems: 4 + else: + properties: + clocks: + minItems: 1 + maxItems: 3 additionalProperties: false