| Message ID | 20230404134225.13408-3-Jonathan.Cameron@huawei.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:6358:3d4a:b0:114:e959:cc0c with SMTP id
b10csp2977952rwc;
Tue, 4 Apr 2023 07:14:46 -0700 (PDT)
X-Google-Smtp-Source:
AKy350axnGngjRODwpReYSELlZmxmiMBSJ21Kp0pbHZTBXTw/AbQU09vd+PFVxAKwHD+cMaoKfVC
X-Received: by 2002:a17:902:f693:b0:19c:e6c8:db16 with SMTP id
l19-20020a170902f69300b0019ce6c8db16mr3666541plg.27.1680617685658;
Tue, 04 Apr 2023 07:14:45 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1680617685; cv=none;
d=google.com; s=arc-20160816;
b=khbdwyOuIyDS0woKobi2FF1je7Q3s/Gr5eL2uTdxbLDcAOJ4KtETW3yw60Fy2hGSJv
g/kl4sGO2hP9J0+p6FSsoGM9E1pX1aFV2Wn9kMOhwtBCrxYR8YRa0u0cAedS4KrhWP1v
5caUkzcNAYs6x9fzZqRI+lU+J0EGxMFZEKcgwkvL0wfQV/ws19F08ICSqyPV775OCkaf
PA5wPjlkVH3mS7xgo4a88KCJ/a2vC5/5GuYI8DhaKWqN+GtbbkLCKGcSGSUwseSIhS6q
pyXzR+eIpIyIXXYqfI1di5E0xkgQ9en/Rznb5yPSRlqIrWBaTk5OcTPyOV4T4Wqye91w
Or+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=m/DCDBikecMgcbTP4iEkZr5YD7QUfx1KcMxXh1Cye9k=;
b=vKRVABPh2JpSH7Gj0X5jrPGt/BYT7V68XfNHHGjOlXTmuURHW5h20fulaE6HqvxyGE
ysf5iyQV/7pbHPSEXRVkOdgwp8/3HWDdg887ift7TXZKXNTQmRGIEW+utYGjBfDvxq70
OuzF6/jzbT2d8hUWVqJvGFoIE+v23hL7TMhIF2k7FGepDI2vCySDsAht18oPxWPEo+ZC
d2WYsXq49BruSjWmP+3jI4yRgodjLClcqOgaLAPvlVYMNU92idMHjIfuejCNLNFN+wk3
m0989MddoiZmR9S1VBBZNTsuGDJBgKq/Lsg17JNU6f3US+eQMRh3K+duZpo/Yhs2nQ44
vbnQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x24-20020a63db58000000b0050bfb509daasi10654718pgi.637.2023.04.04.07.14.32;
Tue, 04 Apr 2023 07:14:45 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S234843AbjDDNnX (ORCPT <rfc822;lkml4gm@gmail.com> + 99 others);
Tue, 4 Apr 2023 09:43:23 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34018 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234453AbjDDNnV (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 4 Apr 2023 09:43:21 -0400
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com
[185.176.79.56])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 979D1186;
Tue, 4 Apr 2023 06:43:20 -0700 (PDT)
Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226])
by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PrTSK01jFz6J72x;
Tue, 4 Apr 2023 21:41:20 +0800 (CST)
Received: from SecurePC-101-06.china.huawei.com (10.122.247.231) by
lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.23; Tue, 4 Apr 2023 14:43:17 +0100
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Will Deacon <will@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<gregkh@linuxfoundation.org>
CC: <linuxarm@huawei.com>, Dan Williams <dan.j.williams@intel.com>,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jiucheng Xu <jiucheng.xu@amlogic.com>,
Khuong Dinh <khuong@os.amperecomputing.com>,
Robert Richter <rric@kernel.org>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Frank Li <Frank.li@nxp.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Vineet Gupta <vgupta@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>, <linux-fpga@vger.kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Liang Kan <kan.liang@linux.intel.com>
Subject: [PATCH 02/32] perf/hisi-pcie: Assign parent for event_source device
Date: Tue, 4 Apr 2023 14:41:55 +0100
Message-ID: <20230404134225.13408-3-Jonathan.Cameron@huawei.com>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20230404134225.13408-1-Jonathan.Cameron@huawei.com>
References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
X-Originating-IP: [10.122.247.231]
X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To
lhrpeml500005.china.huawei.com (7.191.163.240)
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,
RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1762255336045183381?=
X-GMAIL-MSGID: =?utf-8?q?1762255370208564569?=
|
| Series |
Add parents to struct pmu -> dev
|
|
Commit Message
Jonathan Cameron
April 4, 2023, 1:41 p.m. UTC
Currently the PMU device appears directly under /sys/devices/
Only root busses should appear there, so instead assign the pmu->dev
parent to be the PCI device.
Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/perf/hisilicon/hisi_pcie_pmu.c | 1 +
1 file changed, 1 insertion(+)
Comments
On 2023/4/4 21:41, Jonathan Cameron wrote: > Currently the PMU device appears directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parent to be the PCI device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Yicong Yang <yangyicong@hisilicon.com> > --- > drivers/perf/hisilicon/hisi_pcie_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c > index 6fee0b6e163b..2cc88d75b895 100644 > --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c > +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c > @@ -793,6 +793,7 @@ static int hisi_pcie_alloc_pmu(struct pci_dev *pdev, struct hisi_pcie_pmu *pcie_ > pcie_pmu->pmu = (struct pmu) { > .name = name, > .module = THIS_MODULE, > + .parent = &pdev->dev, > .event_init = hisi_pcie_pmu_event_init, > .pmu_enable = hisi_pcie_pmu_enable, > .pmu_disable = hisi_pcie_pmu_disable, >
diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c index 6fee0b6e163b..2cc88d75b895 100644 --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c @@ -793,6 +793,7 @@ static int hisi_pcie_alloc_pmu(struct pci_dev *pdev, struct hisi_pcie_pmu *pcie_ pcie_pmu->pmu = (struct pmu) { .name = name, .module = THIS_MODULE, + .parent = &pdev->dev, .event_init = hisi_pcie_pmu_event_init, .pmu_enable = hisi_pcie_pmu_enable, .pmu_disable = hisi_pcie_pmu_disable,