From patchwork Tue Apr 4 13:13:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Garzarella X-Patchwork-Id: 79100 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3024324vqo; Tue, 4 Apr 2023 06:23:31 -0700 (PDT) X-Google-Smtp-Source: AKy350aIVClwvNPm0s1q8OO8JbUJb5BbtMlIDNK+w8MRvJXfiW8hetkKRcvpLtppLPoh41rqRRF8 X-Received: by 2002:a17:907:762e:b0:947:94fb:3ac6 with SMTP id jy14-20020a170907762e00b0094794fb3ac6mr1885181ejc.33.1680614611078; Tue, 04 Apr 2023 06:23:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680614611; cv=none; d=google.com; s=arc-20160816; b=W7KdpiA3jP0sNXrgBRnq7kA9HVdBvksnz4Helz9sNXtgYe44H/+ctfj4Ibi5Fh9L9P L0qseDOKt7AKU56jymzVaxmM5wwqG0LsrEUWefvxKXktE2Kn6Ly3ISoYbNdzYcqvYxNs 93pB2rHbcdhEI/6mreO991bXlHP9d5HtmLBJx/v8v5HMFNTzbw9va+2giHgIc3lZBNxj PEv3QH4wh/XB9fXiu/ajhZVKR790r5X85qIHeq56zJ+h98p9GLPzz7u6Q0Z1rjlZEsYB e/LXELAXJ2s1GH89gO4ArjQmnv8Fr31a1YfkEJYvAV5VzXATghL7IGXg5s6AtH5/PB34 iCBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4MlJ8boSBAN33TyWlK9MdNtuYbz66i2Pl/D7dBKo3iE=; b=oVbQBkur8cGttX0ABS1SHr0xaiftFbuLUgRC0soRkXWVVPPO0OCTfQ0minsCfVpsSo FW7oUW5HKyknWR8pVDYC5N1JbiUVQW23wuXHlO5oPg1oBVecpg1sdLDRxTXpnNB2xvNo ub2+qt79jXgYSaAn+/zo7j5jGoJKncbCI99yECQPz5CMXueCPOQxZDhKVyxn/Ea72JHV InYlUKfqEq+f0mgo97O+8mn/aQmtEoa1JomlCoF8xCDTlkZhxRVf3k0ecMk3E8FATcVh OB0SBEtbwd9F0opyZC7bhqKWbJTCyhkupSjGGS4kY7r08iWAdR8+ZA658KuCCRve5yyS W+CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MD1dTh6n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id um4-20020a170906cf8400b0093b5bc4c792si3087804ejb.749.2023.04.04.06.23.05; Tue, 04 Apr 2023 06:23:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MD1dTh6n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235007AbjDDNPE (ORCPT + 99 others); Tue, 4 Apr 2023 09:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234777AbjDDNPB (ORCPT ); Tue, 4 Apr 2023 09:15:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BA2B35B3 for ; Tue, 4 Apr 2023 06:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680614039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4MlJ8boSBAN33TyWlK9MdNtuYbz66i2Pl/D7dBKo3iE=; b=MD1dTh6nUzasx7INnVVzUsIBMmzvud1lZez9LCM5z39VxnTZO3A0n74WTgB+uMb0t2EwMi Gv15cZHFAEukj3xezSoW98uuN4cah5rVUHhtNilNi8hb74i6G2xwwlbzb2X/ioaVL4RXEw NcgOFW458wnop+Wjxqr3Y3uaxKAABFM= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-yHr7CG2XOdSgnxY7pkecbQ-1; Tue, 04 Apr 2023 09:13:58 -0400 X-MC-Unique: yHr7CG2XOdSgnxY7pkecbQ-1 Received: by mail-qt1-f198.google.com with SMTP id l13-20020a05622a174d00b003e4df699997so19876384qtk.20 for ; Tue, 04 Apr 2023 06:13:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680614038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4MlJ8boSBAN33TyWlK9MdNtuYbz66i2Pl/D7dBKo3iE=; b=KDwbqGCDs4HCpbVReIGejBYI5fspYf7UsbCOKkVJlstUXhlSW4K5POGW5Y58aq0ODH qK52hs5pyZalR9HBzElPokhFr2PnNSK0Fw/EAmAupdGNbtMrN7liZoK4JVW7B+TJtJq0 31LiTuPkJRyLdWgFJ0+adGPWMVnMF9TnivMC12bD6xVr5z10eki5qaZXpqpdEk227Khv r7TZkzuLOUyWJMkcJ+UmaVPdmSb9udkeKp9kWNVtui1ovncZdUmbbavUY5r9Qtr8MIcR 0M3BB2mR2hVfRaYxqPN1I7XTy0qkDkIf8Hkl5EN0eouNJC/w/vVHbcLHJe99OKJSgZ3V uHUw== X-Gm-Message-State: AAQBX9c76xkYyqaSYbhUB2VJHCKlH/4g3e8PqInr1n7XrKu9gi41AXY8 GYAcishEYtYy0Fojfj/oA8VHrqXjBft9qN2l0kTZFL4gZn5Fwb+/4KMkP/8tSNrHYVDxKsrLiui Tw5d4CqXro5ASQ2pA8HtWDXNe X-Received: by 2002:a05:622a:452:b0:3e2:4280:bc5d with SMTP id o18-20020a05622a045200b003e24280bc5dmr2577054qtx.23.1680614038306; Tue, 04 Apr 2023 06:13:58 -0700 (PDT) X-Received: by 2002:a05:622a:452:b0:3e2:4280:bc5d with SMTP id o18-20020a05622a045200b003e24280bc5dmr2577024qtx.23.1680614038001; Tue, 04 Apr 2023 06:13:58 -0700 (PDT) Received: from step1.redhat.com (host-82-53-134-157.retail.telecomitalia.it. [82.53.134.157]) by smtp.gmail.com with ESMTPSA id z5-20020ac87105000000b003e64303bd2dsm2841837qto.63.2023.04.04.06.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 06:13:57 -0700 (PDT) From: Stefano Garzarella To: virtualization@lists.linux-foundation.org Cc: eperezma@redhat.com, stefanha@redhat.com, Jason Wang , Andrey Zhadchenko , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "Michael S. Tsirkin" , Stefano Garzarella Subject: [PATCH v5 2/9] vhost-vdpa: use bind_mm/unbind_mm device callbacks Date: Tue, 4 Apr 2023 15:13:19 +0200 Message-Id: <20230404131326.44403-3-sgarzare@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404131326.44403-1-sgarzare@redhat.com> References: <20230404131326.44403-1-sgarzare@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762252146350931571?= X-GMAIL-MSGID: =?utf-8?q?1762252146350931571?= When the user call VHOST_SET_OWNER ioctl and the vDPA device has `use_va` set to true, let's call the bind_mm callback. In this way we can bind the device to the user address space and directly use the user VA. The unbind_mm callback is called during the release after stopping the device. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- Notes: v4: - added new switch after vhost_dev_ioctl() [Jason] v3: - added `case VHOST_SET_OWNER` in vhost_vdpa_unlocked_ioctl() [Jason] v2: - call the new unbind_mm callback during the release [Jason] - avoid to call bind_mm callback after the reset, since the device is not detaching it now during the reset drivers/vhost/vdpa.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 7be9d9d8f01c..3824c249612f 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -219,6 +219,28 @@ static int vhost_vdpa_reset(struct vhost_vdpa *v) return vdpa_reset(vdpa); } +static long vhost_vdpa_bind_mm(struct vhost_vdpa *v) +{ + struct vdpa_device *vdpa = v->vdpa; + const struct vdpa_config_ops *ops = vdpa->config; + + if (!vdpa->use_va || !ops->bind_mm) + return 0; + + return ops->bind_mm(vdpa, v->vdev.mm); +} + +static void vhost_vdpa_unbind_mm(struct vhost_vdpa *v) +{ + struct vdpa_device *vdpa = v->vdpa; + const struct vdpa_config_ops *ops = vdpa->config; + + if (!vdpa->use_va || !ops->unbind_mm) + return; + + ops->unbind_mm(vdpa); +} + static long vhost_vdpa_get_device_id(struct vhost_vdpa *v, u8 __user *argp) { struct vdpa_device *vdpa = v->vdpa; @@ -716,6 +738,17 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, break; } + if (r) + goto out; + + switch (cmd) { + case VHOST_SET_OWNER: + r = vhost_vdpa_bind_mm(v); + if (r) + vhost_dev_reset_owner(d, NULL); + break; + } +out: mutex_unlock(&d->mutex); return r; } @@ -1287,6 +1320,7 @@ static int vhost_vdpa_release(struct inode *inode, struct file *filep) vhost_vdpa_clean_irq(v); vhost_vdpa_reset(v); vhost_dev_stop(&v->vdev); + vhost_vdpa_unbind_mm(v); vhost_vdpa_config_put(v); vhost_vdpa_cleanup(v); mutex_unlock(&d->mutex);