diff mbox series

[02/11] USB: dwc3: fix runtime pm imbalance on unbind

Message ID	20230404072524.19014-3-johan+linaro@kernel.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Johan Hovold <johan+linaro@kernel.org> To: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>, stable@vger.kernel.org, Li Jun <jun.li@nxp.com> Subject: [PATCH 02/11] USB: dwc3: fix runtime pm imbalance on unbind Date: Tue, 4 Apr 2023 09:25:15 +0200 Message-Id: <20230404072524.19014-3-johan+linaro@kernel.org> In-Reply-To: <20230404072524.19014-1-johan+linaro@kernel.org> References: <20230404072524.19014-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	USB: dwc3: error handling fixes and cleanups \| [00/11] USB: dwc3: error handling fixes and cleanups [01/11] USB: dwc3: fix runtime pm imbalance on probe errors [02/11] USB: dwc3: fix runtime pm imbalance on unbind [03/11] USB: dwc3: disable autosuspend on unbind [04/11] USB: dwc3: gadget: drop dead hibernation code [05/11] USB: dwc3: drop dead hibernation code [06/11] USB: dwc3: clean up probe error labels [07/11] USB: dwc3: clean up phy init error handling [08/11] USB: dwc3: clean up core init error handling [09/11] USB: dwc3: refactor phy handling [10/11] USB: dwc3: refactor clock lookups [11/11] USB: dwc3: clean up probe declarations

Commit Message

Johan Hovold April 4, 2023, 7:25 a.m. UTC

  Make sure to balance the runtime PM usage count on driver unbind by
adding back the pm_runtime_allow() call that had been erroneously
removed.

Fixes: 266d0493900a ("usb: dwc3: core: don't trigger runtime pm when remove driver")
Cc: stable@vger.kernel.org	# 5.9
Cc: Li Jun <jun.li@nxp.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/usb/dwc3/core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thinh Nguyen April 11, 2023, 1:22 a.m. UTC | #1

On Tue, Apr 04, 2023, Johan Hovold wrote:
> Make sure to balance the runtime PM usage count on driver unbind by
> adding back the pm_runtime_allow() call that had been erroneously
> removed.
> 
> Fixes: 266d0493900a ("usb: dwc3: core: don't trigger runtime pm when remove driver")
> Cc: stable@vger.kernel.org	# 5.9
> Cc: Li Jun <jun.li@nxp.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/usb/dwc3/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 5058bd8d56ca..9f8c988c25cb 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1979,6 +1979,7 @@ static int dwc3_remove(struct platform_device *pdev)
>  	dwc3_core_exit(dwc);
>  	dwc3_ulpi_exit(dwc);
>  
> +	pm_runtime_allow(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_put_noidle(&pdev->dev);
>  	pm_runtime_set_suspended(&pdev->dev);
> -- 
> 2.39.2
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks,
Thinh

diff mbox series

Patch

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 5058bd8d56ca..9f8c988c25cb 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1979,6 +1979,7 @@  static int dwc3_remove(struct platform_device *pdev)
 	dwc3_core_exit(dwc);
 	dwc3_ulpi_exit(dwc);
 
+	pm_runtime_allow(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);