From patchwork Mon Apr 3 21:21:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 78756 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2597474vqo; Mon, 3 Apr 2023 14:34:52 -0700 (PDT) X-Google-Smtp-Source: AKy350Yt1qLNyTVooDVn/1/yulq9NcyUBjIJBxYFh3y3Ky77bmSCV7pDzFosiN3kjIj1gFxNKe1D X-Received: by 2002:a62:1c43:0:b0:625:cf03:e8cb with SMTP id c64-20020a621c43000000b00625cf03e8cbmr515730pfc.4.1680557691755; Mon, 03 Apr 2023 14:34:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680557691; cv=none; d=google.com; s=arc-20160816; b=uyDodYcxy5GLc2uzB+H5x1ZFZJyma+by81Jmwgsa1ngNIXQlDMR2QSGZg3E0w+I5Dd qbHhrWh1zAcDFvlBe1EbtGj54Z3PwO2/q1JfsYW4fr/XE27Trdv0vz8ELEI0yBLk+Le0 loTw3iNRcvm7P12zIfE+IovaKqbiQY2trnljmaqGUHE9XjMosqHf8eVfYalkzyY49OSG rENoQCt/1K9VbEnWyEqyJMzEHnxKfS2+6er3jfoCcbaugiRMFWYzhnKk4xu5g0dHtiRp xl+84MclE77eyOhR+rtq4/v2XlNT2Z7/a+2x/E3gEY7hKS9ovG5Uoi/eP+5ANcfkFw5U dvgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=wP4Xvq/2SbhJwRzUvNDEP+Ib8AtgcdOclkvNUd5eicE=; b=omK/AahuNXYxa+q6iZ9bXUF8AgC9dx6c/Eb+Bg/swe6WgMkvRK+y4vj4vNdpiniSZj GEzLtY70ZYLPkpPtzhMSnZ98ep0IlhO7ZY2i3fmAG9SDYpR8WeGK8SkULJb1/bix5zBc mhLcdL+rYh5ZLhChmNycv4h040/Pfi+X2klF3rXtzUQ1H1U37QtmMtUC7xy77n0WYnda 6nDNoCAQZXUERXWtVahu/BTjeJhC4/POLPEydt/fuKidhAwHl6OHPufes8e4m1JrWvCl fjZw2w5Cw5L65fUJxyTdv+iogt0OH+X5wNtL1V1Yi4F2DW9Q/p/DWlSRm/dLheb7x6JN asKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 126-20020a630584000000b0050bfc1d1b6dsi9053094pgf.132.2023.04.03.14.34.38; Mon, 03 Apr 2023 14:34:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233538AbjDCVXB (ORCPT + 99 others); Mon, 3 Apr 2023 17:23:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233075AbjDCVWq (ORCPT ); Mon, 3 Apr 2023 17:22:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34B63A97; Mon, 3 Apr 2023 14:22:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 761E362C28; Mon, 3 Apr 2023 21:22:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB46CC433D2; Mon, 3 Apr 2023 21:22:43 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1pjRdS-000FR2-36; Mon, 03 Apr 2023 17:22:42 -0400 Message-ID: <20230403212242.777821662@goodmis.org> User-Agent: quilt/0.66 Date: Mon, 03 Apr 2023 17:21:30 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , stable@vger.kernel.org, Daniel Bristot de Oliveira Subject: [for-linus][PATCH 5/6] tracing/osnoise: Fix notify new tracing_max_latency References: <20230403212125.244064799@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762192462312095628?= X-GMAIL-MSGID: =?utf-8?q?1762192462312095628?= From: Daniel Bristot de Oliveira osnoise/timerlat tracers are reporting new max latency on instances where the tracing is off, creating inconsistencies between the max reported values in the trace and in the tracing_max_latency. Thus only report new tracing_max_latency on active tracing instances. Link: https://lkml.kernel.org/r/ecd109fde4a0c24ab0f00ba1e9a144ac19a91322.1680104184.git.bristot@kernel.org Cc: stable@vger.kernel.org Fixes: dae181349f1e ("tracing/osnoise: Support a list of trace_array *tr") Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_osnoise.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index e8116094bed8..4496975f2029 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -1296,7 +1296,7 @@ static void notify_new_max_latency(u64 latency) rcu_read_lock(); list_for_each_entry_rcu(inst, &osnoise_instances, list) { tr = inst->tr; - if (tr->max_latency < latency) { + if (tracer_tracing_is_on(tr) && tr->max_latency < latency) { tr->max_latency = latency; latency_fsnotify(tr); }