From patchwork Mon Apr 3 16:50:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 78637 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2457819vqo; Mon, 3 Apr 2023 10:13:51 -0700 (PDT) X-Google-Smtp-Source: AKy350Z4zXWYCPf/RrM/PUTDUFbmV+IE/TQwMup+aNQ8x6U0cU+ysBxPu6SkZqYjdt7EUN+gRATK X-Received: by 2002:a17:90b:3811:b0:23b:3d6e:1ed with SMTP id mq17-20020a17090b381100b0023b3d6e01edmr40594925pjb.13.1680542030742; Mon, 03 Apr 2023 10:13:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680542030; cv=none; d=google.com; s=arc-20160816; b=lqm7aGORyW4rpadbBKKpw/o74ZpXNj10LaV7jvmM3rEfkPL1xhz/NmM9gp6D/xyOZT oAVpHOrhT28+7Lf7HEhyhGu5yCbviSogofsfwwht4PE5wTHxQD1ocZYU23XcF/JjiSs3 DNth90+aa+19GemCthJH3TpkT/6ZXMjWpHkAyGQ7hD6lIBsz+yRngJAM5Cw/lihont3b LuvIw7UZf0sHFG9yMZFJp6b9QL6mDvtN6l3YUZfBqEPyYW9C9em82KuUCOMKBDU9wGmf msnmO3d8klkAJxlEFSMw+98lnwmdPIvk2uNBfzVH86AWara+s2/kpZVsmsuFg4Nzi2md FNww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=EjZCpXfh72JFXGOUONGFb7mydk/44UHBgGk2m4Z4BKY=; b=d8X+a4iK0qPcdE2/Ounx64SQ4Ap1zu3WQTIS8841z4KZRHZYGU/pVGkNNwMC9dYb49 dW/pXxBTfSeMUUxYk8uI3kcByFxARGmLO1vF/Q+R0SJUWI4giiOd1KZih9CKaoOYSNEK uKeJzPD57htNrCoZs0ZnXQ3Iv74QJdrpoL9NFYE6mNXEwI58B6x6jlhtsmuJDyuqGAU7 /NcMXjM+jAsAHOJoAFSz659POL/ALVORHWO/cmP+q9GSahFKnsb3Ao0LVvU9/iwOxdf3 6DMeYKW189ksWRz21rbygPIba/fwzd8cXdqS7QgAmRZLPcssVGMIvKwSrCl6f2oVj0w/ sL9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nGV7GIES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ij25-20020a170902ab5900b0019cd5d744e4si7895509plb.156.2023.04.03.10.13.38; Mon, 03 Apr 2023 10:13:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nGV7GIES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232460AbjDCQun (ORCPT + 99 others); Mon, 3 Apr 2023 12:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231958AbjDCQum (ORCPT ); Mon, 3 Apr 2023 12:50:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09A75E4 for ; Mon, 3 Apr 2023 09:50:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F85F61961 for ; Mon, 3 Apr 2023 16:50:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E816AC433EF; Mon, 3 Apr 2023 16:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680540641; bh=0ob/hFAIfCGbkHjr+Z2bHwcAANgfDHKR2sqmW+DCfRo=; h=From:To:Cc:Subject:Date:From; b=nGV7GIESm8duFk1qFhH2HHFziJEwQBrM6CVfBvifvGUxrnFb8s2XDLN40E3yzEh4M Eo/B+QGGHGtOgYPLtnoj3Dfj3vLccX8L9dRW9VbjVbxkQ1c7FXNBUislHZjJH/EvQG 80Wpcw6SdzvNyEEU2QThKuSDz6aEhDN8AL9VsWZEmFQ66Wg00JvasgoY4Os4tyaURt VYYU7NqPORiFY8NanHsnmniCQC2uTRkYt5K7nX813Vaqrr8rXjUdFrUDPM7RWPz4vD WUzO3UNylaDjd8JNv4KKcsulrcB/xppBGpLuTbBqc0B3CV2c8NJ3z3RyVJSOCyll0K rPx3WIrIYayfQ== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: fix null pointer panic in tracepoint in __replace_atomic_write_block Date: Mon, 3 Apr 2023 09:50:38 -0700 Message-Id: <20230403165038.3018949-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762176040175053891?= X-GMAIL-MSGID: =?utf-8?q?1762176040175053891?= We got a kernel panic if old_addr is NULL. Signed-off-by: Jaegeuk Kim Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 72bce3808394..2439d7029e64 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -257,7 +257,7 @@ static int __replace_atomic_write_block(struct inode *inode, pgoff_t index, f2fs_put_dnode(&dn); trace_f2fs_replace_atomic_write_block(inode, F2FS_I(inode)->cow_inode, - index, *old_addr, new_addr, recover); + index, old_addr ? *old_addr : 0, new_addr, recover); return 0; }