| Message ID | 20230403132328.61414-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2301018vqo;
Mon, 3 Apr 2023 06:26:40 -0700 (PDT)
X-Google-Smtp-Source:
AKy350anqsXQBWVEjIpwiwFoC99aPct1+1Oio0xsttOgmgGWM0y9627GmQMNvIp+8BcMJI6CbZCk
X-Received: by 2002:a17:906:7949:b0:93d:a14f:c9b2 with SMTP id
l9-20020a170906794900b0093da14fc9b2mr40917908ejo.4.1680528400657;
Mon, 03 Apr 2023 06:26:40 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1680528400; cv=none;
d=google.com; s=arc-20160816;
b=SHa9TCaioEUxEVMBrEsm1W9fBckXM29ZMGFB0fUBL8pi6g0MAXv8Yfu1nXeGg1oid7
7nV4SJa/OW0ejSF3pe9rcteBWu2pelXhUCLExg1XEsZV3e2QRS2LVpI57jo5xvBodUH3
2s/57qbuxkQ9Jz8HmbDZfcSqDOsVxH3rGad3YAk2eCKLlbxdJYeQ0SQ1ETIpmOWclxww
CTZHO29EnH3wmqemfZQYZGtvrjT/laJ33IVOcBf8CcHkEbO3jRCm+7ZRkqIvI47ZOdTr
Exs/41CjIWPPNw5Q59kx6v8KbXeOoIBEsl1mMcqmiW2RGtOBXsat86OPJeUnh/lkz7/h
tHzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=QkaHcd9FrOlxWr5a7MQGp6+vZNEoBTWVj8R7WwWR3tQ=;
b=wPz8zrzexuNDcfJeXg79N94EjDXTkhJ0b+jhQi4JC+1Om9wTnT7OdI9GeQV/1tl+7O
gIVdAZuKttfhrX9evs1C/LILPXlXWl69I5rxa7VFmYhQ8kOgUymva5PTJsmYPbNDmo4G
TnICeQcajAToxE7evQ16hcsFu0lnxxX53OIDBMjyL4B1HIPO7eHuvGXZeDfDMn9ddlkr
SWvM3DYvVGGCsM7eLcm0yYiqdkkYgzMa1c/YFX3g9XwKIaH0JjWfGDN8nMFQKc5ZzznK
ji3FNy3LHP2l0/ZI1aDbnLKpDCIcigXQVTxzuCYhpau+31HnDG3n4aNTVhfs930acm7P
Y83A==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=DXiRtYLY;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
li7-20020a170907198700b00947bf51f947si5554223ejc.276.2023.04.03.06.26.16;
Mon, 03 Apr 2023 06:26:40 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=DXiRtYLY;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231634AbjDCNYR (ORCPT <rfc822;zwp10758@gmail.com> + 99 others);
Mon, 3 Apr 2023 09:24:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51116 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232539AbjDCNYJ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 3 Apr 2023 09:24:09 -0400
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
[IPv6:2a00:1450:4864:20::536])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DC2A22234
for <linux-kernel@vger.kernel.org>;
Mon, 3 Apr 2023 06:23:32 -0700 (PDT)
Received: by mail-ed1-x536.google.com with SMTP id h8so117310210ede.8
for <linux-kernel@vger.kernel.org>;
Mon, 03 Apr 2023 06:23:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1680528210;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=QkaHcd9FrOlxWr5a7MQGp6+vZNEoBTWVj8R7WwWR3tQ=;
b=DXiRtYLY4zzZUiYrkGz/7fNOJQlJJdzkD42cFDuE8RzQl/wvD5Gl7oV/TJLPzcr1k8
oqBfarKQqCcf8IVJD4/5+g5KhSdX0Pz1iR2g14KStbjC0Iam9FFXbrr1q2jbvjy/3mIe
0iRDxqkyv7SoUHrAGE1FtJEf5AUZA/W3IbCzPubIvIo7BtWoq8keDs8g02Pobw41x9IC
P+OI/WEvLfUPi71pgdqptGkFIh6FgSjzlc5G2KDxOYjIzOMS3rpqt9+szYoZk5JCm5RC
w6Re4Bm+9VVblRJlQuMjfoo9+vDCTK6k6rvy40RPuBaYHP5NllzgjYjz8kF+KjV9lU+a
rNyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1680528210;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=QkaHcd9FrOlxWr5a7MQGp6+vZNEoBTWVj8R7WwWR3tQ=;
b=1YNwGXew0inMddh/7gUBeZkDlREcsipgcuzO14ugX9TIE7flFkcVuP/geBXCUPz7s+
5mjHrLdwkTE4uFXBp5v59S641sxVgE5gAqPTqRD2pabSRIGEx6ZeTsBCCwVtVw3miM5Q
j5nM81Jm2Shx3GP6JRCI6hvsHSeyL/x2CjJtQxiDalr7HCjZr3c0ApdsZyJrvQTk2JFf
QJpWb/4+WLuJK+giMHw+cM6ek4tlnlVJ8N9TPVYPPnMCy0Gay1oSe9Ip7XoqbLZT9dS6
ZZp3HY4ogNlZORtXlwtR3PaNTQEa6UF44waAr/7QWjsQP/XNFlQqexjMh1RNwl98NjaD
rnOg==
X-Gm-Message-State: AAQBX9e42KVcf19+kNnxGMqaDT3ZZWlp1FYzkUm/FVMK9nrKtoVuvTYy
MF3SC6iZwc1f1K/6NudLxlMOFK2b28Ht5yxasQw=
X-Received: by 2002:a17:906:7090:b0:885:a62c:5a5c with SMTP id
b16-20020a170906709000b00885a62c5a5cmr32958316ejk.46.1680528210409;
Mon, 03 Apr 2023 06:23:30 -0700 (PDT)
Received: from krzk-bin.. ([2a02:810d:15c0:828:ae90:d80:1069:4805])
by smtp.gmail.com with ESMTPSA id
j18-20020a17090623f200b00947a749fc3esm4328488ejg.33.2023.04.03.06.23.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 03 Apr 2023 06:23:30 -0700 (PDT)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH] arm64: dts: qcom: sc8280xp: correct Soundwire wakeup
interrupt name
Date: Mon, 3 Apr 2023 15:23:28 +0200
Message-Id: <20230403132328.61414-1-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1762161748164529770?=
X-GMAIL-MSGID: =?utf-8?q?1762161748164529770?=
|
| Series |
arm64: dts: qcom: sc8280xp: correct Soundwire wakeup interrupt name
|
|
Commit Message
Krzysztof Kozlowski
April 3, 2023, 1:23 p.m. UTC
The bindings expect second Soundwire interrupt to be "wakeup" (Linux
driver takes by index):
sc8280xp-crd.dtb: soundwire-controller@3330000: interrupt-names:1: 'wakeup' was expected
Fixes: c18773d162a6 ("arm64: dts: qcom: sc8280xp: add SoundWire and LPASS")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 3.04.2023 15:23, Krzysztof Kozlowski wrote: > The bindings expect second Soundwire interrupt to be "wakeup" (Linux > driver takes by index): Seems to be a common occurence with drivers that were written a long time ago but have been updated for new hw since.. Perhaps something like of_irq_get_by_name_idx(..., "name", idx_if_not_found) could be useful.. > > sc8280xp-crd.dtb: soundwire-controller@3330000: interrupt-names:1: 'wakeup' was expected > > Fixes: c18773d162a6 ("arm64: dts: qcom: sc8280xp: add SoundWire and LPASS") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index af7bee14fa06..cd38320dafda 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2606,7 +2606,7 @@ swr2: soundwire-controller@3330000 { > reg = <0 0x03330000 0 0x2000>; > interrupts-extended = <&intc GIC_SPI 959 IRQ_TYPE_LEVEL_HIGH>, > <&intc GIC_SPI 520 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "core", "wake"; > + interrupt-names = "core", "wakeup"; > > clocks = <&txmacro>; > clock-names = "iface";
On Mon, 3 Apr 2023 15:23:28 +0200, Krzysztof Kozlowski wrote: > The bindings expect second Soundwire interrupt to be "wakeup" (Linux > driver takes by index): > > sc8280xp-crd.dtb: soundwire-controller@3330000: interrupt-names:1: 'wakeup' was expected > > Applied, thanks! [1/1] arm64: dts: qcom: sc8280xp: correct Soundwire wakeup interrupt name commit: 894e258b6a38922f9860a20ca07cf2f745e3b090 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index af7bee14fa06..cd38320dafda 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -2606,7 +2606,7 @@ swr2: soundwire-controller@3330000 { reg = <0 0x03330000 0 0x2000>; interrupts-extended = <&intc GIC_SPI 959 IRQ_TYPE_LEVEL_HIGH>, <&intc GIC_SPI 520 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "core", "wake"; + interrupt-names = "core", "wakeup"; clocks = <&txmacro>; clock-names = "iface";