Message ID | 20230403025230.25035-7-chunfeng.yun@mediatek.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2028683vqo; Sun, 2 Apr 2023 19:58:33 -0700 (PDT) X-Google-Smtp-Source: AKy350aekZEE2MqKJ508es3s7mVtsk3yb1DectCJjIuJ7Gj0aAoPuELDtHuwOyaU/Nnsw5jh7Wjx X-Received: by 2002:a17:90b:4c87:b0:23d:2e22:17c9 with SMTP id my7-20020a17090b4c8700b0023d2e2217c9mr39306021pjb.5.1680490712765; Sun, 02 Apr 2023 19:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680490712; cv=none; d=google.com; s=arc-20160816; b=qHUAveWa7FRfAOmh7uzx/Kjb3FJojSAObOZepuoAMYnjips+ksAW1AoHC+21j2bFlP Vk/ZFkfUMcBwFg4UmEwVvhS7nwihzr30Ta/cQdELrgPZYO63Dm4LAQJ+13rC84qcQIn9 6Ui8nk0VaYac4HF4TyEXe9iA+9jakaNEpBfTn8uifhRpLnC3/TahdPDrItT8rijerI3W E139Hv4uEl9Yx+9Ccqdu27THJRRlWPbAf9425CsTLe4xJaKOB2ix06wlgvIgv+pCUD2w Jk2icXc4F9MnpTg6d/AC5UvcDrHqaaTWQmNx9+FsO0PP7g6dtaAMLlt4PtAchFbIpTda 4nyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MuwQPblAEH8HWHgYOf1U7H9BiMIVFtXI2z+R/2HKH/U=; b=aT7mseXKoq1RsVAhoVBMXc4o0KKmnA2JNvcqhUWN02pwKCaSMWO5ItfsGtgXefZKKo OT0EG2qAWmQ+vUy9K2WbXHG45rrWccFrPs6A3l9W5nxS6TOKv1NNPGQQvdl/EKdj0jVW vTGVBor1dX+0rjPsFLx5fd/jvqSUgkbRuqaPZ39G0PIcsYg09mAVQprrMqxdvmxCVJZW 9BTt4a9YMjeN2zQHCAVkqkmXNrJhvHGQ8Z7q2BOK0Qs6nIoBkxY2bXJevFA8rcaNknYz O2iGzlxVqoEXnFDHBJgzenNZcnPxAcBtszi6gPI2A4LsLS8IVkR6fuO8V0LvNPL7b4FJ T2Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=RmmV2IXw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a3-20020a17090a854300b0023f9cb51eaesi11788538pjw.84.2023.04.02.19.58.20; Sun, 02 Apr 2023 19:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=RmmV2IXw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbjDCCxN (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Sun, 2 Apr 2023 22:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbjDCCwx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 2 Apr 2023 22:52:53 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D542CAF32; Sun, 2 Apr 2023 19:52:44 -0700 (PDT) X-UUID: 97aa67a2d1ca11edb6b9f13eb10bd0fe-20230403 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=MuwQPblAEH8HWHgYOf1U7H9BiMIVFtXI2z+R/2HKH/U=; b=RmmV2IXwH5jADzDqPF6IpCiMIvGnooMFL7T7h//93Kkspw5T80CX/3/+ew38V7Tw8yjk+oERocvvhVayDWNo8Bpl/PAIoj7++nu4m82GsQqmYMxnFhNlPKTjQL0BrLMq2YAwXoTfZjmBsLKGCScQih5+qbE9u4YPdHp/GZrTKpc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:85c43b04-5b9a-403d-9878-f055717d366c,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:95 X-CID-INFO: VERSION:1.1.22,REQID:85c43b04-5b9a-403d-9878-f055717d366c,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTION :quarantine,TS:95 X-CID-META: VersionHash:120426c,CLOUDID:c74eabf7-ddba-41c3-91d9-10eeade8eac7,B ulkID:230403105238RFWOSDA6,BulkQuantity:0,Recheck:0,SF:38|29|28|17|19|48,T C:nil,Content:0,EDM:-3,IP:nil,URL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: 97aa67a2d1ca11edb6b9f13eb10bd0fe-20230403 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from <chunfeng.yun@mediatek.com>) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 731793214; Mon, 03 Apr 2023 10:52:37 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Mon, 3 Apr 2023 10:52:36 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Mon, 3 Apr 2023 10:52:36 +0800 From: Chunfeng Yun <chunfeng.yun@mediatek.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org> CC: Chunfeng Yun <chunfeng.yun@mediatek.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Eddie Hung <eddie.hung@mediatek.com>, Tianping Fang <tianping.fang@mediatek.com> Subject: [PATCH 7/7] usb: mtu3: add optional clock xhci_ck and frmcnt_ck Date: Mon, 3 Apr 2023 10:52:30 +0800 Message-ID: <20230403025230.25035-7-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230403025230.25035-1-chunfeng.yun@mediatek.com> References: <20230403025230.25035-1-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,RDNS_NONE,SPF_HELO_PASS, T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762122229463832133?= X-GMAIL-MSGID: =?utf-8?q?1762122229463832133?= |
Series |
[1/7] usb: mtu3: give back request when rx error happens
|
|
Commit Message
Chunfeng Yun (云春峰)
April 3, 2023, 2:52 a.m. UTC
Add optional clock 'xhci_ck' which is usually the same as sys_ck, but
some SoC use two separated clocks when the controller supports dual
role mode;
Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/mtu3/mtu3.h | 2 +-
drivers/usb/mtu3/mtu3_plat.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
Comments
Il 03/04/23 04:52, Chunfeng Yun ha scritto: > Add optional clock 'xhci_ck' which is usually the same as sys_ck, but > some SoC use two separated clocks when the controller supports dual > role mode; > Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC. This needs more details, because from what it seems, `xhci_ck` could be a children of `sys_ck`, in which case there would be no need to add that to this driver, as it'd be handled by the clock API instead. What SoC is this for? Regards, Angelo
On Mon, 2023-04-03 at 14:34 +0200, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 03/04/23 04:52, Chunfeng Yun ha scritto: > > Add optional clock 'xhci_ck' which is usually the same as sys_ck, > > but > > some SoC use two separated clocks when the controller supports dual > > role mode; > > Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC. > > This needs more details, because from what it seems, `xhci_ck` could > be > a children of `sys_ck`, No, it's not child of 'sys_ck', they are all the 125Mhz clocks. > in which case there would be no need to add that > to this driver, as it'd be handled by the clock API instead. > > What SoC is this for? encounter the issue on mt8195 > > Regards, > Angelo >
diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h index 2d7b57e07eee..b4a7662dded5 100644 --- a/drivers/usb/mtu3/mtu3.h +++ b/drivers/usb/mtu3/mtu3.h @@ -90,7 +90,7 @@ struct mtu3_request; */ #define EP0_RESPONSE_BUF 6 -#define BULK_CLKS_CNT 4 +#define BULK_CLKS_CNT 6 /* device operated link and speed got from DEVICE_CONF register */ enum mtu3_speed { diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index d78ae52b4e26..6f264b129243 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -234,6 +234,8 @@ static int get_ssusb_rscs(struct platform_device *pdev, struct ssusb_mtk *ssusb) clks[1].id = "ref_ck"; clks[2].id = "mcu_ck"; clks[3].id = "dma_ck"; + clks[4].id = "xhci_ck"; + clks[5].id = "frmcnt_ck"; ret = devm_clk_bulk_get_optional(dev, BULK_CLKS_CNT, clks); if (ret) return ret;