From patchwork Mon Apr 3 19:59:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 78705 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2554571vqo; Mon, 3 Apr 2023 13:06:36 -0700 (PDT) X-Google-Smtp-Source: AKy350ZglOqLoE+pBQq26CCqUikwb9qjCUT5fCOyh6etJX4prPWzg8/7K3tjH4UD1alHFJ0z3hfw X-Received: by 2002:aa7:cb4f:0:b0:4fc:725:e670 with SMTP id w15-20020aa7cb4f000000b004fc0725e670mr436759edt.11.1680552396515; Mon, 03 Apr 2023 13:06:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680552396; cv=none; d=google.com; s=arc-20160816; b=B67SKchJRwiWN0mwaiN2rCaWvzgx7/fQPBVDERb0Uz/qaIUJ5bKlFrdSlaQ9iYUNF+ 8IS6CrpNN3gGTkApAJnWTIrr94RJGzpWSmqvAgiqrETCLBWGdp4VGU456bcbKE/8PNoi wiyksMRyB4fXfHgYSMW6+zh9QmQ06ykluBHnNJr9+v5CdmLH9Z1P6MzXD5WjMfizyAyo 8YPpFm5qmmw1XI4reTrOxmMxOCfMgL9C31nPcwUB9a1HH5r1Vey02fpwFb8Un1OQmNpM 11BNUdGIi/9GgP+Cy8TTIK9G5CjWsPvMUZDqJPgBmYt2AlCJ3WnznplvgJfoHbcHCBKu 86Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=Bg/HCXdFOa6pEuZtZpdQAudL+0Nih+E2fbYA1vbqCPo=; b=FMQ9d2bH+T+0r/n/r2EBXWq+qSNkMa9Ck8vf47tG5zOX+0OjFjoa5VAg0p66Wgi5TP FinjAyLq4cFDxv/Zfq2viRjCJHg1TXY0/AgQbavJCCC48K8bPt9ecPXFWMx0OCLLnxyP for+EASYsjZzhMQdiMoSJ7croeF9Lm6Qd2Ug0pUAmd79xDRS97XiHMRAZuX7qHXjihDq Z6XkwEqJTfQyC7IJQ8AFoLMCvX44qOl7zbmbZyy5V4wjRljjN5iLjn8La51uin/bwtMu f+SoIeiQZvvlEhUP/U/Mf+zXAEaBa8+Kxdxsk9WfVBi4rmbOXMOTxr2zrhQ3ssMw3uA4 B+tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RlU27bvg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k24-20020aa7d8d8000000b005029459a6c5si4877825eds.365.2023.04.03.13.06.11; Mon, 03 Apr 2023 13:06:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RlU27bvg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232364AbjDCUAV (ORCPT + 99 others); Mon, 3 Apr 2023 16:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbjDCUAT (ORCPT ); Mon, 3 Apr 2023 16:00:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E963CD7 for ; Mon, 3 Apr 2023 13:00:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8543762950 for ; Mon, 3 Apr 2023 20:00:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B32ECC433D2; Mon, 3 Apr 2023 20:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680552017; bh=wWhl5BO+MfmttCEYPrR6iCQCTocuBDmG7hzKkDLpiEY=; h=From:Date:Subject:To:Cc:From; b=RlU27bvgnVIZ1GKdEIB6+ciFV1mx+akcXX2NWw7hnvXjrDbv+u3PSsaD6sKwAwIkU AL98YXCl+Vd6CUGAPMpP3zB+l4XBlj94ev9DaHwhA7USUXiwbsr9UFb+m9E0PbkmVp deWnn2Pa1hPuobDynVtTAm17pEGTTb448DOY8vZekIBHyTTFrm1128Scm79wPvijuw /8BaI07flgBKl8npYnm0hfRPNRNLfCHYtBXwmoHMpxFOl1HM4roaUxq4sitqFW5Q7S HR7DQLI51P2f0qGvOuQvy0SsqKE5EYHDMcsVkr0t62Hsc45KJUP7akn9e5S0j1x30y TJFCGaaOT+inw== From: Mark Brown Date: Mon, 03 Apr 2023 20:59:44 +0100 Subject: [PATCH] regmap: Use mas_walk() instead of mas_find() MIME-Version: 1.0 Message-Id: <20230403-regmap-maple-walk-fine-v1-1-09512dd51e50@kernel.org> X-B4-Tracking: v=1; b=H4sIAC8wK2QC/x2NywqDMBBFf0Vm3YE0Vmj7K6WLPG500EaZQC2I/ 97o4i7OhcPZqEAFhZ7NRoqvFJlzheuloTC43IMlViZrbGtupmVF/3EL103g1U0jJ8ngx916H20 MCR1V2bsC9upyGA59nXU87kWR5Hf2Xu99/wPwVgZsfwAAAA== To: Liam.Howlett@Oracle.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-00303 X-Developer-Signature: v=1; a=openpgp-sha256; l=1373; i=broonie@kernel.org; h=from:subject:message-id; bh=wWhl5BO+MfmttCEYPrR6iCQCTocuBDmG7hzKkDLpiEY=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkKzBPMCJJJ9pw9zNKYOGOOOthUXSElqODjRYbaAQQ wHMJiNaJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZCswTwAKCRAk1otyXVSH0HyjB/ 9wuWX5Z7lfnrqp1liHLKEwKUHODnEuvabqwTPf1uvVDhjFhgC3G9DFzPu978V6VXl4p3wNClqRku2N 2T/8cUIuGr60h7YwgaE/UdYTwjzCUKTls1yYu7Oaxw+joUONq5KfogO5wpcxpPJf5y5zb5Jb4QFJl/ 5WSOkQdPYZG/sub3/fHB9hpDpyENfZbsu/xDWmcztea3nGf2Z47ygjGAeJ2b5RMBZrfruvpZZqgyvP UBPLEgFuOCPeFsQlCwn2dSugunJehlic96yryxmykQFgB7JayX7/cM8avae/ar6WTSoH43xw77ikLD 9/pZKZMFtYcEsLineeob16SXJ/jxOO X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762186909790749705?= X-GMAIL-MSGID: =?utf-8?q?1762186909790749705?= Liam recommends using mas_walk() instead of mas_find() for our use case so let's do that, it avoids some minor overhead associated with being able to restart the operation which we don't need since we do a simple search. Suggested-by: Liam R. Howlett Signed-off-by: Mark Brown --- drivers/base/regmap/regcache-maple.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- base-commit: f033c26de5a5734625d2dd1dc196745fae186f1b change-id: 20230403-regmap-maple-walk-fine-982bbd2dcfe5 Best regards, diff --git a/drivers/base/regmap/regcache-maple.c b/drivers/base/regmap/regcache-maple.c index 497cc708d277..5d1bc3691830 100644 --- a/drivers/base/regmap/regcache-maple.c +++ b/drivers/base/regmap/regcache-maple.c @@ -22,7 +22,9 @@ static int regcache_maple_read(struct regmap *map, rcu_read_lock(); - entry = mas_find(&mas, reg); + mas.index = reg; + mas.last = reg; + entry = mas_walk(&mas); if (!entry) { rcu_read_unlock(); return -ENOENT; @@ -47,7 +49,9 @@ static int regcache_maple_write(struct regmap *map, unsigned int reg, rcu_read_lock(); - entry = mas_find(&mas, reg); + mas.index = reg; + mas.last = reg; + entry = mas_walk(&mas); if (entry) { entry[reg - mas.index] = val; rcu_read_unlock();