From patchwork Sun Apr 2 09:05:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 78199 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1645288vqo; Sun, 2 Apr 2023 02:11:49 -0700 (PDT) X-Google-Smtp-Source: AKy350bGW+pSsLsIpAfwJJZ5FfHupSlxknxfS2yKZ7J6/t4Y+Aehwqgp8wQD+iVwIZPU/1iZx77i X-Received: by 2002:aa7:c2d9:0:b0:4fa:315a:cb59 with SMTP id m25-20020aa7c2d9000000b004fa315acb59mr33864371edp.12.1680426709511; Sun, 02 Apr 2023 02:11:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680426709; cv=none; d=google.com; s=arc-20160816; b=qdbI+O4Ypln1vk30Qq1ZOk/Fixhpc/hxsV/4ejzmH8gkN9mTgNFB4FDNmZ43Ag+rf/ WviFW+rnJjNk5x3a4ATzvG7ahcu0ZvvWseKxgPbxOU0hvph1TkkVMJX3+6RfXjpNINXS nSqDWlXvMD1WVicbeT+mhDg4ie8Xx/YalooOjvIJC0CO4pCM0f5v5s5RBhkMhlaV6a6J 1wvSFsL3nOQfF+KF4IzlqktY7CaL+sAsKfN0LevrE77beHLm990ym6Rv586FXr87xjTl cqPNe/19YG2jdGnX4s5EkyV5u9XIrvKbob0jZenhgqTmBDEMFXwojr+QpIKRao+tSC3Q 70SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Xxmdipmh0VupfU0AxNgSgYNcXrG9+DioatW6om49eEY=; b=KYpA2mE7KX3y5mxV5puaxPLfh/TOYHScAKQAic8sBQJ5dlixpR3gEKQXCzCB8tvPA7 P0k3TR1YNdTWAXHRD6+/+uE5ma9AnAlY3JV+SwbRoOm3sJcsy0dnk0E96IDTBbr7PNh6 AGp+q1XAAzjRrvcVm8qf5kFG8iRo2MEmB3MUv6s/b689CBx8jXX2iG64cR6tSalQNi58 azNXqvaSY4QzggKIEIdGq/Fm1gmKICaWeZfe2NiVBak8tvzmPJQf43bD+LFjDKftBIDM 9jzdkxj8pQ9JJoYhVuHur1s0W5FLZuFPplqE32pSlFXVuJ/ZQNj/Ma1o4b6kdvQOuya0 tRCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SUDLEiUm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j25-20020aa7ca59000000b004bb9ff4b733si6212919edt.353.2023.04.02.02.11.09; Sun, 02 Apr 2023 02:11:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SUDLEiUm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230241AbjDBJGL (ORCPT + 99 others); Sun, 2 Apr 2023 05:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjDBJGK (ORCPT ); Sun, 2 Apr 2023 05:06:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BD87B762; Sun, 2 Apr 2023 02:06:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15644B80DD2; Sun, 2 Apr 2023 09:06:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 826F5C433EF; Sun, 2 Apr 2023 09:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680426365; bh=tstDOziMek5axEwzqeGOS4xIyUKdT0x7UNiG+x46cAk=; h=From:To:Cc:Subject:Date:From; b=SUDLEiUmZd2M1RI9wUDKRUVEeV/HdPsXS+MjJD/eZftQxGBCcLvHuatVpIyRnxcuR RvGM4EGuMAIht5//BYns6EzaBON7q3NASjPqGIVqOFR1oaUrNjeEV9TE0/JZLDfixj 78w4Ura2Z1HhUDYidKF9iNAhMM5gRZS2ejE3M+b8= From: Greg Kroah-Hartman To: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Dengcheng Zhu , John Crispin , Qais Yousef , "Steven J . Hill" , Thomas Bogendoerfer , Yang Yingliang , kernel test robot Subject: [PATCH] MIPS: vpe-cmp: remove module owner pointer from struct class usage. Date: Sun, 2 Apr 2023 11:05:45 +0200 Message-Id: <2023040242-pursuable-frown-48d8@gregkh> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1815; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=tstDOziMek5axEwzqeGOS4xIyUKdT0x7UNiG+x46cAk=; b=owGbwMvMwCRo6H6F97bub03G02pJDCmarulHPKZdSzJ7I/Up7v9T/is3dTUKdwrYa97om/nSO /k9r7x1RywLgyATg6yYIsuXbTxH91ccUvQytD0NM4eVCWQIAxenAEwksI5hwYG4qeWZC4XMk16F cr/xjXm58fXSWwzzA3atvvxUVSxgt/aK2yWL7Dh+lF3IAgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762055117250707575?= X-GMAIL-MSGID: =?utf-8?q?1762055117250707575?= In commit 6e30a66433af ("driver core: class: remove struct module owner out of struct class"), the module owner pointer was removed from struct class, but this was missed for the mips vpe-cmp code due to lack of build testing (and it being burried under a very unused config settings.) Fix this up by removing the module pointer to resolve the build error. Note, there are other problems with the driver model usage in this file (static struct device usage, empty device release function, etc.), so it probably could use some good cleaning up, but odds are this driver really isn't used so hopefully it will just be removed entirely someday soon as part of the general "remove unused arches" cleanup that is slowly happening. Cc: Dengcheng Zhu Cc: John Crispin Cc: Qais Yousef Cc: Steven J. Hill Cc: Thomas Bogendoerfer Cc: Yang Yingliang Cc: linux-mips@vger.kernel.org Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202304020802.xbRTJKjW-lkp@intel.com/ Fixes: 6e30a66433af ("driver core: class: remove struct module owner out of struct class") Signed-off-by: Greg Kroah-Hartman Acked-by: Thomas Bogendoerfer --- arch/mips/kernel/vpe-cmp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/kernel/vpe-cmp.c b/arch/mips/kernel/vpe-cmp.c index 92140edb3ce3..4ef7f49a4c6d 100644 --- a/arch/mips/kernel/vpe-cmp.c +++ b/arch/mips/kernel/vpe-cmp.c @@ -79,7 +79,6 @@ static void vpe_device_release(struct device *cd) static struct class vpe_class = { .name = "vpe", - .owner = THIS_MODULE, .dev_release = vpe_device_release, .dev_groups = vpe_groups, };