From patchwork Sun Apr 2 20:09:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 78297 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1901421vqo; Sun, 2 Apr 2023 13:12:38 -0700 (PDT) X-Google-Smtp-Source: AKy350Y8D8wWvdJPOo4unGMyegWnTCqasqF423dtCb8K8fzkIpyvlX64pc7L0myU1/uZzC9pNgoK X-Received: by 2002:a05:6402:15a:b0:4f9:deb4:b984 with SMTP id s26-20020a056402015a00b004f9deb4b984mr32671666edu.9.1680466358258; Sun, 02 Apr 2023 13:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680466358; cv=none; d=google.com; s=arc-20160816; b=qdjCOuBK0P1YS0bk2kWo8fNfNuGH45nYzni4sgjIHz/nzlA1LKaqFWLZ+v4sVcOHL8 X58xBxtle8TQQ6y8DWKmnL8/HxD7Olbm55yxxH5PzuGPSSo/55j/3qJh+xrIu/OC06xL PLWg58KO3DJct2Sv/xoAWmDTIKDpQsxKlZMU/bymfEFumtIuEkmMFgD2/6vkIhBLkDX5 jgus2cuQ0TxAwnHGEr2TOcBKZO6hbbvGALdzSnmUmscLcRSPD9lC+nwz9Wk61WEYVWfq uOkv4E4+zEoxp3UMZi73qrqX+CCY/ZinbZHxWQK9Go8DFlk7g+gbUvysdhtkhp43lloJ mrzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AFjm9UZOr4B7pRsXgqjvbVyzqWT97tUm8W06JvPbgKQ=; b=vIydaCiahMNEDWTFitq15kAkySxH5pKwN9DCaKwxr+zQj+8Zi2svBsHCva7CyEJhV5 7AbZ+kGMBPO+zzeXD2DrYJYBckoiAJjQRdX9tEVblSeQry20CWsZUFepPD3nUzS0JVAC LfnZfEdFC2QAnW9Jep0FZdemdgadEH1hBQfS+bLlUDQZIUOecdn1T4v8/tqljrpDxFJb CBHyIkKU0AwplUHglKOGT/8HpjsAvDYFanwwFuGCaNoFFYms+T+yGFqwbOhSZ6ZMIbJg lt0JsUSFNQ2AY6wym4oXway+qhMzrTi2+s243DHluItLeSG2b2jNDMIDw7+rw1j6C535 LMIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=O3nYWp+w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020aa7cb44000000b0050230e4b487si2985853edt.13.2023.04.02.13.12.14; Sun, 02 Apr 2023 13:12:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=O3nYWp+w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230458AbjDBUKi (ORCPT + 99 others); Sun, 2 Apr 2023 16:10:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbjDBUKX (ORCPT ); Sun, 2 Apr 2023 16:10:23 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C273CC2E for ; Sun, 2 Apr 2023 13:10:22 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id eg48so109411312edb.13 for ; Sun, 02 Apr 2023 13:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1680466220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AFjm9UZOr4B7pRsXgqjvbVyzqWT97tUm8W06JvPbgKQ=; b=O3nYWp+wncOn7KIYtTsObuYApJsAoEL4q+RnfvaUH7NaoUfBGA9w2AsigwGa8GK0LQ lOmWNaA7mk+nlJB47YhEmoIe7kfLHo6cvpaSiqhXyt/yYkQFqWgbcAzuh9/CKTrtvtnT CFxEU3X2w4DIFV4r9koGIseFEwOsrK8oONBdA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680466220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AFjm9UZOr4B7pRsXgqjvbVyzqWT97tUm8W06JvPbgKQ=; b=SPC8Nc5Bf1oesmh1IyXjE1ABTTICphNDu13+EzLgMYfLI4TC/NasgldW0JoIEz5qC9 4PJ4UxAJ/dQxREP1wU23YqyUpTiByCQHZE2melyHvzsYD49rDJHTnE/W2MV5pMc8Lreh GZEZ8AO7ZSU+O9c/AxfF5oKkLfrDVYLaNEA+O89P1p6M1uGHilJOfGnvnIwnxaJs3NQw iQaBakbIyySmH74v2Dw71ee1XyXbUiLL2SkN8ZP/9Mvtl+b6QOTS7XDhbgUTchqGIaCX HFpgayQGJEi3oaTluJs70dzv/neiEgV4XrCxSmE7mNaWePNpzI3UQUaDECYU9eOGdIK5 9dYA== X-Gm-Message-State: AAQBX9edlB6pi4H8JyIBnQriTP0cCG5SGDVIVUmzsP84jJVbkBZhve3A 9TllVxPoLuQCNNO8xAL5qBVXdLltZHLt2HqbUiQ= X-Received: by 2002:a17:907:84a:b0:947:87a2:31d7 with SMTP id ww10-20020a170907084a00b0094787a231d7mr13489859ejb.33.1680466220561; Sun, 02 Apr 2023 13:10:20 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-248-31-153.retail.telecomitalia.it. [95.248.31.153]) by smtp.gmail.com with ESMTPSA id gl18-20020a170906e0d200b00924d38bbdc0sm3553127ejb.105.2023.04.02.13.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 13:10:20 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Jonathan Cameron , Oliver Graute , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= , Wolfram Sang , linux-input@vger.kernel.org Subject: [PATCH 6/9] Input: edt-ft5x06 - don't print error messages with dev_dbg() Date: Sun, 2 Apr 2023 22:09:48 +0200 Message-Id: <20230402200951.1032513-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20230402200951.1032513-1-dario.binacchi@amarulasolutions.com> References: <20230402200951.1032513-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762096692012825378?= X-GMAIL-MSGID: =?utf-8?q?1762096692012825378?= In some parts of the code, error messages were improperly printed with dev_dbg() calls. In those cases, dev_dbg() has been replaced with dev_err(). Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/edt-ft5x06.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 7d82f412ab15..89958881fca1 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -783,7 +783,7 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, error = edt_ft5x06_register_write(tsdata, 0x08, 0x01); if (error) { - dev_dbg(&client->dev, + dev_err(&client->dev, "failed to write 0x08 register, error %d\n", error); goto out; } @@ -797,13 +797,13 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, if (val < 0) { error = val; - dev_dbg(&client->dev, + dev_err(&client->dev, "failed to read 0x08 register, error %d\n", error); goto out; } if (retries == 0) { - dev_dbg(&client->dev, + dev_err(&client->dev, "timed out waiting for register to settle\n"); error = -ETIMEDOUT; goto out;