diff mbox series

driver core: remove incorrect comment for device_create*

Message ID 2023040218-scouts-unplowed-24d2@gregkh
State New
Headers
Series driver core: remove incorrect comment for device_create* |

Commit Message

Greg KH April 2, 2023, 9:11 a.m. UTC 
  The device_create() and device_create_with_groups() function comments
incorrectly state that they only work with a struct class that was
created using class_create(), but that is not true now and I am not sure
if it ever was.  So just remove the comment as it's not needed now.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/core.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Rafael J. Wysocki April 3, 2023, 5:54 p.m. UTC | #1 
On Sun, Apr 2, 2023 at 11:11 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> The device_create() and device_create_with_groups() function comments
> incorrectly state that they only work with a struct class that was
> created using class_create(), but that is not true now and I am not sure
> if it ever was.  So just remove the comment as it's not needed now.
>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

> ---
>  drivers/base/core.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 3ee5d206e7eb..7a42d1b6b721 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -4330,9 +4330,6 @@ device_create_groups_vargs(const struct class *class, struct device *parent,
>   * pointer.
>   *
>   * Returns &struct device pointer on success, or ERR_PTR() on error.
> - *
> - * Note: the struct class passed to this function must have previously
> - * been created with a call to class_create().
>   */
>  struct device *device_create(const struct class *class, struct device *parent,
>                              dev_t devt, void *drvdata, const char *fmt, ...)
> @@ -4371,9 +4368,6 @@ EXPORT_SYMBOL_GPL(device_create);
>   * pointer.
>   *
>   * Returns &struct device pointer on success, or ERR_PTR() on error.
> - *
> - * Note: the struct class passed to this function must have previously
> - * been created with a call to class_create().
>   */
>  struct device *device_create_with_groups(const struct class *class,
>                                          struct device *parent, dev_t devt,
> --
> 2.40.0
>
diff mbox series

Patch

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 3ee5d206e7eb..7a42d1b6b721 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -4330,9 +4330,6 @@  device_create_groups_vargs(const struct class *class, struct device *parent,
  * pointer.
  *
  * Returns &struct device pointer on success, or ERR_PTR() on error.
- *
- * Note: the struct class passed to this function must have previously
- * been created with a call to class_create().
  */
 struct device *device_create(const struct class *class, struct device *parent,
 			     dev_t devt, void *drvdata, const char *fmt, ...)
@@ -4371,9 +4368,6 @@  EXPORT_SYMBOL_GPL(device_create);
  * pointer.
  *
  * Returns &struct device pointer on success, or ERR_PTR() on error.
- *
- * Note: the struct class passed to this function must have previously
- * been created with a call to class_create().
  */
 struct device *device_create_with_groups(const struct class *class,
 					 struct device *parent, dev_t devt,