From patchwork Sat Apr 1 10:09:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 78087 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1141254vqo; Sat, 1 Apr 2023 03:40:58 -0700 (PDT) X-Google-Smtp-Source: AKy350aP3ms/452gG4rPoJuv7RQzR62qTURWxd/H1Mp159ShZoOVzPjxOr4QoHaZZYgWeN+FRAcI X-Received: by 2002:a17:902:cec1:b0:1a1:aa28:e67a with SMTP id d1-20020a170902cec100b001a1aa28e67amr39138829plg.48.1680345658523; Sat, 01 Apr 2023 03:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680345658; cv=none; d=google.com; s=arc-20160816; b=JLsVBI3GEywjWjMegxT145zw//tQ9LjbXCbOzUM76ZIsxV37TsvgmyS56F/Mmp/6fN u4gvQCA+q5lqiQvQy3jjkuXLDirME6C5JCaTGls1Rh2QHfUTsjWOb1wY8iU/vDNTRajn 853soIcOtT4Aq6aAx8Y39+oC1CKydEBr2WoxHVPMbbFh73TqnsEhgjKHwsA3T/fk8LvV wU60ctgMnusR7owt/kK8KeIkvoIwDqDDnSp5MvN4ZreTbDE1JeW8P5m9nExxF9EocW5q mrdG2kBWomLzuMnpY+u53Dh4RH33K8TIN13RuEHy2SWEZwpnKvS5bsNx+86Td32r7GQp VS3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VmpBKsRtu/1TmfMka2Fsj7eG88xr+tVGylkC2be0R/I=; b=vnrfwurCbYtONGQUsUmm1AtriNXUVZxtHs3biXoIWxHnY/5uOPtJg2YAudXBwcxPqQ lNrHhVFL7FQNT/1AeVI1PLG70os03qWu+J0flT+G0wvfiV6nvXHAKuD87pOE+adp+zJI CgTIWqZc/mj6zShb+AKI5tyoy9wYYH5t15qvdKJOCNXeCB9GsTUUEn/m/d2dDhdZdwkY loLVAZAtM+PHY66NaQfdDoBxzGtdW1pOrgHYQ1OYzsB+fBdsWqs9Qg/8wDDnx+ODd80a ZdSBn/XWTkJxAjdD/r3Unqnv4iLysfhYOjjmz8Jh6wbLIYHgOKZa7H0g4/v5jE1Y2xgd yIeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hNXafzFT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a170903018300b0019ae58cae8esi4890999plg.120.2023.04.01.03.40.46; Sat, 01 Apr 2023 03:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hNXafzFT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjDAKKQ (ORCPT + 99 others); Sat, 1 Apr 2023 06:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbjDAKKP (ORCPT ); Sat, 1 Apr 2023 06:10:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E05A1D2DC for ; Sat, 1 Apr 2023 03:10:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B2B760C27 for ; Sat, 1 Apr 2023 10:10:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D188BC433D2; Sat, 1 Apr 2023 10:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680343813; bh=EB/7TtVadKu5smsVxqKVB6j7j2tQkpgO1huzAziIWDU=; h=From:To:Cc:Subject:Date:From; b=hNXafzFTWULt/Ty8xC2WGqFMb/0ymfXveC+Q1EOHHo8Ikv8eTA2LxIxM0x7jHcRYR 8CjDKl0VaDvjqS/PM9pT/8UenqxgYSjPKij5GKvaR0PMdYp1MhcYnJLhBUGhqbE9/h PpdCBAc3YC724AfePNLv6XhZb46fDJcB0ra4Ws3o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , syzbot+41d665317c811d4d88aa@syzkaller.appspotmail.com Subject: [PATCH] driver core: class : fix slab-use-after-free Read in class_register() Date: Sat, 1 Apr 2023 12:09:26 +0200 Message-Id: <2023040126-blandness-duckling-bd55@gregkh> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1012; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=EB/7TtVadKu5smsVxqKVB6j7j2tQkpgO1huzAziIWDU=; b=owGbwMvMwCRo6H6F97bub03G02pJDCkaTFcr7n3/XKpXmlUd+9Z058+szEDFM4vsBGQXpHu5V r4NrHncEcvCIMjEICumyPJlG8/R/RWHFL0MbU/DzGFlAhnCwMUpABOxCGeYZ3lxaf2WlT0+vLoX Fury3z/ycsrJAoY5PKv7nP9nrXY5HWJw+c2ln4dCwtu/AgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761970129239122140?= X-GMAIL-MSGID: =?utf-8?q?1761970129239122140?= Syzbot found that we had forgotten to unregister the lock_class_key when using it in commit dcfbb67e48a2 ("driver core: class: use lock_class_key already present in struct subsys_private") so fix that up and correctly release it when done. Cc: "Rafael J. Wysocki" Reported-and-tested-by: Fixes: dcfbb67e48a2 ("driver core: class: use lock_class_key already present in struct subsys_private") Signed-off-by: Greg Kroah-Hartman --- drivers/base/class.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/class.c b/drivers/base/class.c index 2991936c80db..ac1808d1a2e8 100644 --- a/drivers/base/class.c +++ b/drivers/base/class.c @@ -103,6 +103,7 @@ static void class_release(struct kobject *kobj) pr_debug("class '%s' does not have a release() function, " "be careful\n", class->name); + lockdep_unregister_key(&cp->lock_key); kfree(cp); }