[v4,1/2] dt-bindings: phy: qcom,qmp-usb: Fix phy subnode for SM6115 & QCM2290 USB3 PHY
| Message ID | 20230401154725.1059563-2-bhupesh.sharma@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1311139vqo;
Sat, 1 Apr 2023 09:10:48 -0700 (PDT)
X-Google-Smtp-Source:
AKy350bGL3dxZ9eu1s0OgPOw+5hpQM07utg7spzZkeik+XvPSU46yH6Qc3V86k8iohCfYfrjrK1G
X-Received: by 2002:a17:907:8b88:b0:925:f788:d76d with SMTP id
tb8-20020a1709078b8800b00925f788d76dmr32884772ejc.27.1680365448312;
Sat, 01 Apr 2023 09:10:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1680365448; cv=none;
d=google.com; s=arc-20160816;
b=MNWnCw+gm3+RpmvUUYMR0QGqeRH20pdvuuk+ZLbyf76LespwgRNibdnCk9/xaXmQr5
DVKkBPQkgT8gnoSza+phcqWYMmPthXZhiVItdu7Jn8Ih8ZB38TEhWixhPdqnb55yntLL
1sRzrvMSUCpJuTjiHrKeE99faQqEJq0dqbBSQtkFCeK6SGt/wXO+lOWwMKKCtWIXNwTZ
vwKQVEI/rbyUGLPpEuX7bKF2BN1fuWJkFWeaeQodr4VKpiZ8K9Lr2M4fDPasYgInRsUt
ssNzqvbTmEFbClqdCQEWDDmVmcQQr8dRODfIjJohb/2ltN7zjUROmH/0+CSf8DWaMLfe
FaOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=+N3Lew9LFdFmBLa2xh7Y61frxhM4EhNwmm0GMfVIfIo=;
b=h5iPYsiRJ/sysOADh/I/lyIW5qa9lXviMYHAQmothvs4wWh4tG5bNv43X9dE1O3IQK
bJ27CQqF8VaivhtSGyGO8JT5bcUCe9ePB5TOFBj6NExH1FzEg5QbaJB4liIzfL8C+F2V
aVucS9quDBcaW6GWDVkKvfV3eshK/EALkcJ/2UdWrmrfB1oebADMPHaXwQEWwLHE67Ta
YJa2FvgUkTXMdB799a7SQspDcDzv2Gqe48AjeIHG4wUmpmZ3ujcKLycrjpTk7POwKcUx
+xlK8dev0zlEKBdN+qul5VgdCNYweATxEVuFuLjBdXWZUosy/URsBQff6xqOLY+5rnwx
bRVQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=nzaTnmRk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
wy12-20020a170906fe0c00b00948130c7e35si1836341ejb.167.2023.04.01.09.10.22;
Sat, 01 Apr 2023 09:10:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=nzaTnmRk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229681AbjDAPto (ORCPT <rfc822;dexuan.linux@gmail.com>
+ 99 others); Sat, 1 Apr 2023 11:49:44 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33486 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229612AbjDAPtl (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 1 Apr 2023 11:49:41 -0400
Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com
[IPv6:2607:f8b0:4864:20::633])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED9B92293F
for <linux-kernel@vger.kernel.org>;
Sat, 1 Apr 2023 08:49:40 -0700 (PDT)
Received: by mail-pl1-x633.google.com with SMTP id kq3so24146296plb.13
for <linux-kernel@vger.kernel.org>;
Sat, 01 Apr 2023 08:49:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1680364180;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=+N3Lew9LFdFmBLa2xh7Y61frxhM4EhNwmm0GMfVIfIo=;
b=nzaTnmRkDihaYkXInNf/oggEORv36u93mfkPRLg2rVTdtIZHUpS5XWtKt481tOQPS0
6ld0wsXk7xo4Qj860x/S44QXU+b74um4dnEhRs3NZeRR70X3iX7uMHJhRWdby6s4WRAk
t5roh3FFAM/qA/Z089pW5Un82e4/aKc1ZMfK4KX6pmb0Zm/AGofTFxKiXOT7A3X2jt/4
bilsQ+4OKp/qloCfYBX2tS5/bOrgbaXCgsKT8W0OvW2iWFBUWtySZ5mtE+oOUEN6us3n
slKlUKje1xPsM4VB3Ts/HWeQtaeIOGM0nz7OWFhTtc7YB9eSjAuzlNzbdJel56PxrPNH
mtXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1680364180;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=+N3Lew9LFdFmBLa2xh7Y61frxhM4EhNwmm0GMfVIfIo=;
b=Rgaly0FrWZqWvPZ0cEbsbtqSKQBWmdqSuIBaDkmwIfIilnKmGpt94G25hOctbUSkcF
Z0FL6393DXDH1wGRQGOD85zqGWaGoY709cq+qvqyn48ewTSCe6NmI6KSDUuhEnCkDnrX
t1dIPlUlday0ppxrBIMPoNH5yovZw7zziCVckDhfvGsRBAEvsC7RJj7KoNsHaGe7zWvp
EpRJemsaJ6oTErDE8R7Dr/Eu9eggsVpHWLQhMfj8BspfX4TiIrRniNgl/6TZivO6Wb9n
Uknps0eOU6tHeUStQstUJaw6/EDi5IjU5zVzBBVvrVwIwu6U++ibuLgP9cM6o16Qj58/
VK+w==
X-Gm-Message-State: AAQBX9ckES+zYFm+5xJGVFXBkt65J//vRz90LQMUauDlxVBYoOZY2mz7
X+thK4k+n+bJ8HQp6knVQ0rjwg==
X-Received: by 2002:a05:6a20:1445:b0:e4:663a:f645 with SMTP id
a5-20020a056a20144500b000e4663af645mr6198016pzi.16.1680364180309;
Sat, 01 Apr 2023 08:49:40 -0700 (PDT)
Received: from localhost.localdomain ([223.233.66.184])
by smtp.gmail.com with ESMTPSA id
65-20020a630444000000b0050fb4181e8bsm3385367pge.40.2023.04.01.08.49.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 01 Apr 2023 08:49:40 -0700 (PDT)
From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com,
bhupesh.sharma@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski@linaro.org
Subject: [PATCH v4 1/2] dt-bindings: phy: qcom,qmp-usb: Fix phy subnode for
SM6115 & QCM2290 USB3 PHY
Date: Sat, 1 Apr 2023 21:17:24 +0530
Message-Id: <20230401154725.1059563-2-bhupesh.sharma@linaro.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20230401154725.1059563-1-bhupesh.sharma@linaro.org>
References: <20230401154725.1059563-1-bhupesh.sharma@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761990880633613191?=
X-GMAIL-MSGID: =?utf-8?q?1761990880633613191?=
|
| Series |
Enable USB SS qmp phy for Qualcomm SM6115 SoC
|
|
Commit Message
Bhupesh Sharma
April 1, 2023, 3:47 p.m. UTC
The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is
similar to sm8150 QMP PHY in the sense that the phy subnode supports
6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and
PCS_MISC.
Update the dt-bindings document to reflect the same.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
.../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Sat, 1 Apr 2023 at 18:49, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > similar to sm8150 QMP PHY in the sense that the phy subnode supports sm8150 has 5 QMP PHYs. Which one is mentioned here? > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > PCS_MISC. > > Update the dt-bindings document to reflect the same. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > index e81a38281f8c..1575dc70bcf2 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > @@ -276,7 +276,9 @@ allOf: > compatible: > contains: > enum: > + - qcom,qcm2290-qmp-usb3-phy > - qcom,sdm845-qmp-usb3-phy > + - qcom,sm6115-qmp-usb3-phy > - qcom,sm8150-qmp-usb3-phy > - qcom,sm8350-qmp-usb3-phy > - qcom,sm8450-qmp-usb3-phy > @@ -318,12 +320,10 @@ allOf: > enum: > - qcom,ipq6018-qmp-usb3-phy > - qcom,ipq8074-qmp-usb3-phy > - - qcom,qcm2290-qmp-usb3-phy > - qcom,sc7180-qmp-usb3-phy > - qcom,sc8180x-qmp-usb3-phy > - qcom,sdx55-qmp-usb3-uni-phy > - qcom,sdx65-qmp-usb3-uni-phy > - - qcom,sm6115-qmp-usb3-phy > - qcom,sm8150-qmp-usb3-uni-phy > - qcom,sm8250-qmp-usb3-phy > then: > -- > 2.38.1 >
On Sat, 1 Apr 2023 at 22:42, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Sat, 1 Apr 2023 at 18:49, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > > > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > > similar to sm8150 QMP PHY in the sense that the phy subnode supports > > sm8150 has 5 QMP PHYs. Which one is mentioned here? 'qcom,sm8150-qmp-usb3-phy' which is named as 'usb_1_qmpphy' in sm8150.dtsi (see : <https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm8150.dtsi#n3394>) and has 6 regs , namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and PCS_MISC. Regards, Bhupesh > > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > > PCS_MISC. > > > > Update the dt-bindings document to reflect the same. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > index e81a38281f8c..1575dc70bcf2 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > @@ -276,7 +276,9 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,qcm2290-qmp-usb3-phy > > - qcom,sdm845-qmp-usb3-phy > > + - qcom,sm6115-qmp-usb3-phy > > - qcom,sm8150-qmp-usb3-phy > > - qcom,sm8350-qmp-usb3-phy > > - qcom,sm8450-qmp-usb3-phy > > @@ -318,12 +320,10 @@ allOf: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > > - - qcom,qcm2290-qmp-usb3-phy > > - qcom,sc7180-qmp-usb3-phy > > - qcom,sc8180x-qmp-usb3-phy > > - qcom,sdx55-qmp-usb3-uni-phy > > - qcom,sdx65-qmp-usb3-uni-phy > > - - qcom,sm6115-qmp-usb3-phy > > - qcom,sm8150-qmp-usb3-uni-phy > > - qcom,sm8250-qmp-usb3-phy > > then: > > -- > > 2.38.1 > > > > > -- > With best wishes > Dmitry
On 01/04/2023 17:47, Bhupesh Sharma wrote: > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > similar to sm8150 QMP PHY in the sense that the phy subnode supports > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > PCS_MISC. > > Update the dt-bindings document to reflect the same. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Bhupesh, Can you use scripts/get_maintainers.pl to get the Cc addresses instead of writing them manually or inventing? Best regards, Krzysztof
On Wed, 5 Apr 2023 at 15:11, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 01/04/2023 17:47, Bhupesh Sharma wrote: > > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > > similar to sm8150 QMP PHY in the sense that the phy subnode supports > > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > > PCS_MISC. > > > > Update the dt-bindings document to reflect the same. > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Bhupesh, > > Can you use scripts/get_maintainers.pl to get the Cc addresses instead > of writing them manually or inventing? Sure Krzysztof, will do. Thanks, Bhupesh
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml index e81a38281f8c..1575dc70bcf2 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml @@ -276,7 +276,9 @@ allOf: compatible: contains: enum: + - qcom,qcm2290-qmp-usb3-phy - qcom,sdm845-qmp-usb3-phy + - qcom,sm6115-qmp-usb3-phy - qcom,sm8150-qmp-usb3-phy - qcom,sm8350-qmp-usb3-phy - qcom,sm8450-qmp-usb3-phy @@ -318,12 +320,10 @@ allOf: enum: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-usb3-phy - - qcom,qcm2290-qmp-usb3-phy - qcom,sc7180-qmp-usb3-phy - qcom,sc8180x-qmp-usb3-phy - qcom,sdx55-qmp-usb3-uni-phy - qcom,sdx65-qmp-usb3-uni-phy - - qcom,sm6115-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - qcom,sm8250-qmp-usb3-phy then: