From patchwork Fri Mar 31 09:33:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 77683 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp437483vqo; Fri, 31 Mar 2023 02:44:42 -0700 (PDT) X-Google-Smtp-Source: AKy350abAQQwrP04450WNRyh9N3vXmtBnB1eFLQeIOmFqhMwHhQmg5dTOjNElOB62cPBWwS8amIY X-Received: by 2002:a17:907:9627:b0:947:40e6:fde4 with SMTP id gb39-20020a170907962700b0094740e6fde4mr7349390ejc.2.1680255882138; Fri, 31 Mar 2023 02:44:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255882; cv=none; d=google.com; s=arc-20160816; b=tvLckF7TGvteqGcdlm0n/DNAbBiOva6tdtKRv8ffZuJvff4JT34vv3GpoOozb17P9A Oz8rNU+PlTupV4BRxwaYAcT/E//xWzo+xx+9OaDKZ/oLXfyik9ZAXeaVP6/BqaKuZPSR FxiSt5GCiN/w//KG9pL9ciQlvZrZ8yKNqkqPZ6M8yc9srqyFeQ/o1D99Lw2I/lES8NhD u7bBqgomrdAJlKtt9fQtWG/gbUyZvFknDLuXZMpPZxtcWMbR6P/F+icdAWi2r84PsDiM ZkQwInJ9AT19Hna3Z3d+cAlkyWvHR1Xm9mjjAQU1OlHvFS5gSvN/brB2jTEYseqadDaC 9Zbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QWcZwZWTALIbzkuj5bNVjq2eAZ6tXDyHq998Z+Mlnbs=; b=SD/xhZUWfB+ptGkiRg0QVmo+V6sT6HDxPOQ+36PEN5qebkyUCkb8CVuZDe+vEUmrg3 cqu5r7IhmiKfzsXFAnTpJ98XrFhCC6/Y8N68froD42PIu1K4n9PITXva5owYLqwVl2Ty GD3BzH6ygSO83DmYHwlMnh6dayUXGxBjvrav1pUIvEiY6OHh9vLd/TdJRE/XvJhtt3yk +bZ7+y5JrqRTxAGNCMSoq4kmLqTgCUpuJH2ye7nCnFcRKPEwADubBfm6GDoEjYfhkidu 5lt9LJmn6fF62JOyclQEdlj8c72ExEL6QV90oUwqNRvF9dplsyZgTu8q6NckUULn88XR lM8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bRO3vsYs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lt24-20020a170906fa9800b00927130f010esi1466059ejb.58.2023.03.31.02.44.19; Fri, 31 Mar 2023 02:44:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bRO3vsYs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbjCaJed (ORCPT + 99 others); Fri, 31 Mar 2023 05:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbjCaJeI (ORCPT ); Fri, 31 Mar 2023 05:34:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E67F51EA23 for ; Fri, 31 Mar 2023 02:33:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C2476B82D7C for ; Fri, 31 Mar 2023 09:33:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A2EEC433D2; Fri, 31 Mar 2023 09:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680255212; bh=cG2nXhJrWKrDIwvw+gSEk9fxnRVDM8TBTZRetku5/tE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bRO3vsYsc5CcSBOAQcpEnD60o0CZkMqi9Rd+btz2vALjxImFFaafm8DFBdU1LLaKq 96+Yd7JusWfOT+5J8R8Ef1UcStaZ9g8E6CmIqce8hlToVkiW7+rTuQVjvByZsnfN5O j4/yUtcX63dOLEod2oH91gnBsVtehFwTWlhf54I0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: [PATCH 3/7] driver core: class: remove subsystem private pointer from struct class Date: Fri, 31 Mar 2023 11:33:14 +0200 Message-Id: <20230331093318.82288-3-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230331093318.82288-1-gregkh@linuxfoundation.org> References: <20230331093318.82288-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1634; i=gregkh@linuxfoundation.org; h=from:subject; bh=cG2nXhJrWKrDIwvw+gSEk9fxnRVDM8TBTZRetku5/tE=; b=owGbwMvMwCRo6H6F97bub03G02pJDClqK+5myDzteeM6I6R0XoU8c92GquySFl4eoZr5aaqHV nH/kUvviGVhEGRikBVTZPmyjefo/opDil6Gtqdh5rAygQxh4OIUgIlYBjIs6FudsDxL9fZ90R/u XY/MA1Uinrf1MczPMnG/FZaWdaWcN5f1UrPQZZ+tXbUA X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875991688627335?= X-GMAIL-MSGID: =?utf-8?q?1761875991688627335?= Now that the last users of the subsystem private pointer in struct class are gone, the pointer can be removed, as no one is using it. One step closer to allowing struct class to be const and moved into read-only memory. Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman Acked-by: Rafael J. Wysocki --- drivers/base/class.c | 4 ---- include/linux/device/class.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/base/class.c b/drivers/base/class.c index a8a1bf976290..fcfb295363cc 100644 --- a/drivers/base/class.c +++ b/drivers/base/class.c @@ -97,8 +97,6 @@ static void class_release(struct kobject *kobj) pr_debug("class '%s': release.\n", class->name); - class->p = NULL; - if (class->class_release) class->class_release(class); else @@ -206,7 +204,6 @@ int class_register(struct class *cls) cp->subsys.kobj.kset = class_kset; cp->subsys.kobj.ktype = &class_ktype; cp->class = cls; - cls->p = cp; error = kset_register(&cp->subsys); if (error) @@ -222,7 +219,6 @@ int class_register(struct class *cls) err_out: kfree(cp); - cls->p = NULL; return error; } EXPORT_SYMBOL_GPL(class_register); diff --git a/include/linux/device/class.h b/include/linux/device/class.h index 9cb5db0588c8..f7aad64e256a 100644 --- a/include/linux/device/class.h +++ b/include/linux/device/class.h @@ -71,8 +71,6 @@ struct class { void (*get_ownership)(const struct device *dev, kuid_t *uid, kgid_t *gid); const struct dev_pm_ops *pm; - - struct subsys_private *p; }; struct class_dev_iter {