[v2] arm64: dts: rockchip: Remove non-existing pwm-delay-us property
Commit Message
There is neither a driver that parses this nor a DT binding schema that
documents it, so let's remove from the DTS files that make use of this.
The properties that exist are post-pwm-on-delay-ms and pwm-off-delay-ms,
defined in the pwm-backlight DT binding. If the delays are really needed
then those properties should be used instead.
Brian Norris mentioned though that looking at the first downstream usage
of the pwm-delay-us property for RK3399 Gru systems in ChromiumOS tree,
he couldn't find a spec reference that said that this was really needed.
So perhaps it was unnecessary added and a simple removal would be enough.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
---
Changes in v2:
- Update commit message with the information provided by Brian Norries.
- Add Reviewed-by tag from Brian Norries.
arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 1 -
arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 -
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 1 -
3 files changed, 3 deletions(-)
base-commit: b2bc47e9b2011a183f9d3d3454a294a938082fb9
Comments
On Fri, 31 Mar 2023 01:19:23 +0200, Javier Martinez Canillas wrote:
> There is neither a driver that parses this nor a DT binding schema that
> documents it, so let's remove from the DTS files that make use of this.
>
> The properties that exist are post-pwm-on-delay-ms and pwm-off-delay-ms,
> defined in the pwm-backlight DT binding. If the delays are really needed
> then those properties should be used instead.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Remove non-existing pwm-delay-us property
commit: 3adf89324a2b2a9dbc2c12d8895021e7e34e3346
Best regards,
@@ -61,7 +61,6 @@ backlight: backlight {
pinctrl-names = "default";
pinctrl-0 = <&bl_en>;
pwms = <&pwm0 0 1000000 PWM_POLARITY_INVERTED>;
- pwm-delay-us = <10000>;
};
emmc_pwrseq: emmc-pwrseq {
@@ -198,7 +198,6 @@ backlight: backlight {
power-supply = <&pp3300_disp>;
pinctrl-names = "default";
pinctrl-0 = <&bl_en>;
- pwm-delay-us = <10000>;
};
gpio_keys: gpio-keys {
@@ -167,7 +167,6 @@ backlight: backlight {
pinctrl-names = "default";
pinctrl-0 = <&bl_en>;
pwms = <&pwm1 0 1000000 0>;
- pwm-delay-us = <10000>;
};
dmic: dmic {