diff mbox series

[06/29] selftests/mm: Link vm_util.c always

Message ID 20230330160700.3106955-1-peterx@redhat.com
State New
Headers
Series selftests/mm: Split / Refactor userfault test |

Commit Message

Peter Xu March 30, 2023, 4:07 p.m. UTC 
  We do have plenty of files that want to link against vm_util.c.  Just make
it simple by linking it always.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tools/testing/selftests/mm/Makefile | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

David Hildenbrand April 3, 2023, 7:52 a.m. UTC | #1 
On 30.03.23 18:07, Peter Xu wrote:
> We do have plenty of files that want to link against vm_util.c.  Just make
> it simple by linking it always.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   tools/testing/selftests/mm/Makefile | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 47516a78d447..b35f3eafde3c 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -105,17 +105,7 @@ TEST_FILES += va_128TBswitch.sh
>   
>   include ../lib.mk
>   
> -$(OUTPUT)/cow: vm_util.c
> -$(OUTPUT)/khugepaged: vm_util.c
> -$(OUTPUT)/ksm_functional_tests: vm_util.c
> -$(OUTPUT)/madv_populate: vm_util.c
> -$(OUTPUT)/soft-dirty: vm_util.c
> -$(OUTPUT)/split_huge_page_test: vm_util.c
> -$(OUTPUT)/userfaultfd: vm_util.c
> -$(OUTPUT)/gup_test: vm_util.c
> -$(OUTPUT)/mrelease_test: vm_util.c
> -$(OUTPUT)/transhuge-stress: vm_util.c
> -$(OUTPUT)/ksm_tests: vm_util.c
> +$(TEST_GEN_PROGS): vm_util.c
>   
>   ifeq ($(MACHINE),x86_64)
>   BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32))

Reviewed-by: David Hildenbrand <david@redhat.com>
Mike Rapoport April 7, 2023, 9:23 a.m. UTC | #2 
On Thu, Mar 30, 2023 at 12:07:00PM -0400, Peter Xu wrote:
> We do have plenty of files that want to link against vm_util.c.  Just make
> it simple by linking it always.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  tools/testing/selftests/mm/Makefile | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 47516a78d447..b35f3eafde3c 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -105,17 +105,7 @@ TEST_FILES += va_128TBswitch.sh
> 
>  include ../lib.mk
> 
> -$(OUTPUT)/cow: vm_util.c
> -$(OUTPUT)/khugepaged: vm_util.c
> -$(OUTPUT)/ksm_functional_tests: vm_util.c
> -$(OUTPUT)/madv_populate: vm_util.c
> -$(OUTPUT)/soft-dirty: vm_util.c
> -$(OUTPUT)/split_huge_page_test: vm_util.c
> -$(OUTPUT)/userfaultfd: vm_util.c
> -$(OUTPUT)/gup_test: vm_util.c
> -$(OUTPUT)/mrelease_test: vm_util.c
> -$(OUTPUT)/transhuge-stress: vm_util.c
> -$(OUTPUT)/ksm_tests: vm_util.c
> +$(TEST_GEN_PROGS): vm_util.c
> 
>  ifeq ($(MACHINE),x86_64)
>  BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32))
> -- 
> 2.39.1
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
index 47516a78d447..b35f3eafde3c 100644
--- a/tools/testing/selftests/mm/Makefile
+++ b/tools/testing/selftests/mm/Makefile
@@ -105,17 +105,7 @@  TEST_FILES += va_128TBswitch.sh
 
 include ../lib.mk
 
-$(OUTPUT)/cow: vm_util.c
-$(OUTPUT)/khugepaged: vm_util.c
-$(OUTPUT)/ksm_functional_tests: vm_util.c
-$(OUTPUT)/madv_populate: vm_util.c
-$(OUTPUT)/soft-dirty: vm_util.c
-$(OUTPUT)/split_huge_page_test: vm_util.c
-$(OUTPUT)/userfaultfd: vm_util.c
-$(OUTPUT)/gup_test: vm_util.c
-$(OUTPUT)/mrelease_test: vm_util.c
-$(OUTPUT)/transhuge-stress: vm_util.c
-$(OUTPUT)/ksm_tests: vm_util.c
+$(TEST_GEN_PROGS): vm_util.c
 
 ifeq ($(MACHINE),x86_64)
 BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32))