diff mbox series

[03/29] selftests/mm: Dump a summary in run_vmtests.sh

Message ID	20230330160646.3106903-1-peterx@redhat.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Peter Xu <peterx@redhat.com> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand <david@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, peterx@redhat.com, Axel Rasmussen <axelrasmussen@google.com>, Mike Kravetz <mike.kravetz@oracle.com>, Leonardo Bras Soares Passos <lsoaresp@redhat.com>, Mike Rapoport <rppt@linux.vnet.ibm.com>, Nadav Amit <nadav.amit@gmail.com> Subject: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh Date: Thu, 30 Mar 2023 12:06:46 -0400 Message-Id: <20230330160646.3106903-1-peterx@redhat.com> In-Reply-To: <20230330155707.3106228-1-peterx@redhat.com> References: <20230330155707.3106228-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	selftests/mm: Split / Refactor userfault test \| [00/29] selftests/mm: Split / Refactor userfault test [01/29] Revert "userfaultfd: don't fail on unrecognized features" [02/29] selftests/mm: Update .gitignore with two missing tests [03/29] selftests/mm: Dump a summary in run_vmtests.sh [04/29] selftests/mm: Merge util.h into vm_util.h [05/29] selftests/mm: Use TEST_GEN_PROGS where proper [06/29] selftests/mm: Link vm_util.c always [07/29] selftests/mm: Merge default_huge_page_size() into one [08/29] selftests/mm: Use PM_* macros in vm_utils.h [09/29] selftests/mm: Reuse pagemap_get_entry() in vm_util.h [10/29] selftests/mm: Test UFFDIO_ZEROPAGE only when !hugetlb [11/29] selftests/mm: Drop test_uffdio_zeropage_eexist [12/29] selftests/mm: Create uffd-common.[ch] [13/29] selftests/mm: Split uffd tests into uffd-stress and uffd-unit-tests [14/29] selftests/mm: uffd_[un]register() [15/29] selftests/mm: uffd_open_{dev\|sys}() [16/29] selftests/mm: UFFDIO_API test [17/29] selftests/mm: Drop global mem_fd in uffd tests [18/29] selftests/mm: Drop global hpage_size in uffd tests [19/29] selftests/mm: Let uffd_handle_page_fault() takes wp parameter [20/29] selftests/mm: Allow allocate_area() to fail properly [21/29] selftests/mm: Add framework for uffd-unit-test [22/29] selftests/mm: Move uffd pagemap test to unit test [23/29] selftests/mm: Move uffd minor test to unit test [24/29] selftests/mm: Move uffd sig/events tests into uffd unit tests [25/29] selftests/mm: Move zeropage test into uffd unit tests [26/29] selftests/mm: Workaround no way to detect uffd-minor + wp [27/29] selftests/mm: Allow uffd test to skip properly with no privilege [28/29] selftests/mm: Drop sys/dev test in uffd-stress test [29/29] selftests/mm: Add shmem-private test to uffd-stress

Commit Message

Peter Xu March 30, 2023, 4:06 p.m. UTC

  Dump a summary after running whatever test specified.  Useful for human
runners to identify any kind of failures (besides exit code).

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Axel Rasmussen March 30, 2023, 7:07 p.m. UTC | #1

On Thu, Mar 30, 2023 at 9:06 AM Peter Xu <peterx@redhat.com> wrote:
>
> Dump a summary after running whatever test specified.  Useful for human
> runners to identify any kind of failures (besides exit code).
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index c0f93b668c0c..9cc33984aa9f 100644
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -5,6 +5,9 @@
>  # Kselftest framework requirement - SKIP code is 4.
>  ksft_skip=4
>
> +count_pass=0
> +count_fail=0
> +count_skip=0
>  exitcode=0
>
>  usage() {
> @@ -149,11 +152,14 @@ run_test() {
>                 "$@"
>                 local ret=$?
>                 if [ $ret -eq 0 ]; then
> +                       count_pass=$(( $count_pass + 1 ))

Actually, inside $(( )) there's no need to prefix variable names with
$ too. Running "shellcheck" over the script written this way will
generate a warning.

Same applies below.

>                         echo "[PASS]"
>                 elif [ $ret -eq $ksft_skip ]; then
> +                       count_skip=$(( $count_skip + 1 ))
>                         echo "[SKIP]"
>                         exitcode=$ksft_skip
>                 else
> +                       count_fail=$(( $count_fail + 1 ))
>                         echo "[FAIL]"
>                         exitcode=1
>                 fi
> @@ -279,4 +285,6 @@ CATEGORY="soft_dirty" run_test ./soft-dirty
>  # COW tests
>  CATEGORY="cow" run_test ./cow
>
> +echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}"
> +
>  exit $exitcode
> --
> 2.39.1
>

Besides the nitpick:

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>

Peter Xu March 30, 2023, 10:28 p.m. UTC | #2

On Thu, Mar 30, 2023 at 12:07:24PM -0700, Axel Rasmussen wrote:
> On Thu, Mar 30, 2023 at 9:06 AM Peter Xu <peterx@redhat.com> wrote:
> >
> > Dump a summary after running whatever test specified.  Useful for human
> > runners to identify any kind of failures (besides exit code).
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> > index c0f93b668c0c..9cc33984aa9f 100644
> > --- a/tools/testing/selftests/mm/run_vmtests.sh
> > +++ b/tools/testing/selftests/mm/run_vmtests.sh
> > @@ -5,6 +5,9 @@
> >  # Kselftest framework requirement - SKIP code is 4.
> >  ksft_skip=4
> >
> > +count_pass=0
> > +count_fail=0
> > +count_skip=0
> >  exitcode=0
> >
> >  usage() {
> > @@ -149,11 +152,14 @@ run_test() {
> >                 "$@"
> >                 local ret=$?
> >                 if [ $ret -eq 0 ]; then
> > +                       count_pass=$(( $count_pass + 1 ))
> 
> Actually, inside $(( )) there's no need to prefix variable names with
> $ too. Running "shellcheck" over the script written this way will
> generate a warning.
> 
> Same applies below.

Sure, I'll fix.

> 
> >                         echo "[PASS]"
> >                 elif [ $ret -eq $ksft_skip ]; then
> > +                       count_skip=$(( $count_skip + 1 ))
> >                         echo "[SKIP]"
> >                         exitcode=$ksft_skip
> >                 else
> > +                       count_fail=$(( $count_fail + 1 ))
> >                         echo "[FAIL]"
> >                         exitcode=1
> >                 fi
> > @@ -279,4 +285,6 @@ CATEGORY="soft_dirty" run_test ./soft-dirty
> >  # COW tests
> >  CATEGORY="cow" run_test ./cow
> >
> > +echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}"
> > +
> >  exit $exitcode
> > --
> > 2.39.1
> >
> 
> Besides the nitpick:
> 
> Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>

Thanks!

David Hildenbrand April 3, 2023, 7:49 a.m. UTC | #3

On 31.03.23 00:28, Peter Xu wrote:
> On Thu, Mar 30, 2023 at 12:07:24PM -0700, Axel Rasmussen wrote:
>> On Thu, Mar 30, 2023 at 9:06 AM Peter Xu <peterx@redhat.com> wrote:
>>>
>>> Dump a summary after running whatever test specified.  Useful for human
>>> runners to identify any kind of failures (besides exit code).
>>>
>>> Signed-off-by: Peter Xu <peterx@redhat.com>
>>> ---
>>>   tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>
>>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
>>> index c0f93b668c0c..9cc33984aa9f 100644
>>> --- a/tools/testing/selftests/mm/run_vmtests.sh
>>> +++ b/tools/testing/selftests/mm/run_vmtests.sh
>>> @@ -5,6 +5,9 @@
>>>   # Kselftest framework requirement - SKIP code is 4.
>>>   ksft_skip=4
>>>
>>> +count_pass=0
>>> +count_fail=0
>>> +count_skip=0
>>>   exitcode=0
>>>
>>>   usage() {
>>> @@ -149,11 +152,14 @@ run_test() {
>>>                  "$@"
>>>                  local ret=$?
>>>                  if [ $ret -eq 0 ]; then
>>> +                       count_pass=$(( $count_pass + 1 ))
>>
>> Actually, inside $(( )) there's no need to prefix variable names with
>> $ too. Running "shellcheck" over the script written this way will
>> generate a warning.
>>
>> Same applies below.
> 
> Sure, I'll fix.

With that

Reviewed-by: David Hildenbrand <david@redhat.com>

Mike Rapoport April 7, 2023, 9:15 a.m. UTC | #4

On Thu, Mar 30, 2023 at 12:06:46PM -0400, Peter Xu wrote:
> Dump a summary after running whatever test specified.  Useful for human
> runners to identify any kind of failures (besides exit code).
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index c0f93b668c0c..9cc33984aa9f 100644
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -5,6 +5,9 @@
>  # Kselftest framework requirement - SKIP code is 4.
>  ksft_skip=4
> 
> +count_pass=0
> +count_fail=0
> +count_skip=0
>  exitcode=0
> 
>  usage() {
> @@ -149,11 +152,14 @@ run_test() {
>  		"$@"
>  		local ret=$?
>  		if [ $ret -eq 0 ]; then
> +			count_pass=$(( $count_pass + 1 ))
>  			echo "[PASS]"
>  		elif [ $ret -eq $ksft_skip ]; then
> +			count_skip=$(( $count_skip + 1 ))
>  			echo "[SKIP]"
>  			exitcode=$ksft_skip
>  		else
> +			count_fail=$(( $count_fail + 1 ))
>  			echo "[FAIL]"
>  			exitcode=1
>  		fi
> @@ -279,4 +285,6 @@ CATEGORY="soft_dirty" run_test ./soft-dirty
>  # COW tests
>  CATEGORY="cow" run_test ./cow
> 
> +echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}"
> +
>  exit $exitcode
> -- 
> 2.39.1
>

diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index c0f93b668c0c..9cc33984aa9f 100644
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -5,6 +5,9 @@ 
 # Kselftest framework requirement - SKIP code is 4.
 ksft_skip=4
 
+count_pass=0
+count_fail=0
+count_skip=0
 exitcode=0
 
 usage() {
@@ -149,11 +152,14 @@  run_test() {
 		"$@"
 		local ret=$?
 		if [ $ret -eq 0 ]; then
+			count_pass=$(( $count_pass + 1 ))
 			echo "[PASS]"
 		elif [ $ret -eq $ksft_skip ]; then
+			count_skip=$(( $count_skip + 1 ))
 			echo "[SKIP]"
 			exitcode=$ksft_skip
 		else
+			count_fail=$(( $count_fail + 1 ))
 			echo "[FAIL]"
 			exitcode=1
 		fi
@@ -279,4 +285,6 @@  CATEGORY="soft_dirty" run_test ./soft-dirty
 # COW tests
 CATEGORY="cow" run_test ./cow
 
+echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}"
+
 exit $exitcode