diff mbox series

.gitignore: Exclude KUnit config dot-files

Message ID 20230330112743.2331141-1-javierm@redhat.com
State New
Headers
Series .gitignore: Exclude KUnit config dot-files |

Commit Message

Javier Martinez Canillas March 30, 2023, 11:27 a.m. UTC 
  There's a rule to ignore all the dot-files (.*) but we want to exclude the
config files used by KUnit (.kunitconfig) since those are usually added to
allow executing test suites without having to enable custom config symbols.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 .gitignore | 1 +
 1 file changed, 1 insertion(+)


base-commit: ffe78bbd512166e0ef1cc4858010b128c510ed7d

Comments

Maíra Canal March 30, 2023, 11:33 a.m. UTC | #1 
Hi Javier,

On 3/30/23 08:27, Javier Martinez Canillas wrote:
> There's a rule to ignore all the dot-files (.*) but we want to exclude the
> config files used by KUnit (.kunitconfig) since those are usually added to
> allow executing test suites without having to enable custom config symbols.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

This seems like a pretty nice improvement for the KUnit development.

Reviewed-by: Maíra Canal <mcanal@igalia.com>

Best Regards,
- Maíra Canal

> ---
> 
>   .gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 70ec6037fa7a..7f86e0837909 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -103,6 +103,7 @@ modules.order
>   !.get_maintainer.ignore
>   !.gitattributes
>   !.gitignore
> +!.kunitconfig
>   !.mailmap
>   !.rustfmt.toml
>   
> 
> base-commit: ffe78bbd512166e0ef1cc4858010b128c510ed7d
Daniel Latypov March 30, 2023, 3:34 p.m. UTC | #2 
On Thu, Mar 30, 2023 at 4:27 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> There's a rule to ignore all the dot-files (.*) but we want to exclude the
> config files used by KUnit (.kunitconfig) since those are usually added to
> allow executing test suites without having to enable custom config symbols.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

FYI, Andy has a version of this patch from back in Jan here,
https://lore.kernel.org/linux-kselftest/20230127145708.12915-1-andriy.shevchenko@linux.intel.com/

I don't think anyone was adamantly opposed to it, but it's just been
sitting on the list waiting.

Daniel
Javier Martinez Canillas March 30, 2023, 4:55 p.m. UTC | #3 
Daniel Latypov <dlatypov@google.com> writes:

Hello Daniel,

> On Thu, Mar 30, 2023 at 4:27 AM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>>
>> There's a rule to ignore all the dot-files (.*) but we want to exclude the
>> config files used by KUnit (.kunitconfig) since those are usually added to
>> allow executing test suites without having to enable custom config symbols.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> FYI, Andy has a version of this patch from back in Jan here,
> https://lore.kernel.org/linux-kselftest/20230127145708.12915-1-andriy.shevchenko@linux.intel.com/
>
> I don't think anyone was adamantly opposed to it, but it's just been
> sitting on the list waiting.
>

Thanks. I missed that there was a patch posted already by Andy.

Masahiro-san,

Could you please pick that? It would not only facilitate adding new KUnit
test suites but also avoid existing reports sent by the kernel robot, i.e:

https://lore.kernel.org/linux-input/CAGS_qxot1_+J3YCykkk0H1fZM6Cn6Pv4SFT6iCf9J7td1aH9HQ@mail.gmail.com/T/#mfcce95444b2df1c8242b03b7434e7730a6087663
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index 70ec6037fa7a..7f86e0837909 100644
--- a/.gitignore
+++ b/.gitignore
@@ -103,6 +103,7 @@  modules.order
 !.get_maintainer.ignore
 !.gitattributes
 !.gitignore
+!.kunitconfig
 !.mailmap
 !.rustfmt.toml