diff mbox series

[v2,1/2] hwmon: (coretemp) Delete tjmax debug message

Message ID 20230330103346.6044-1-rui.zhang@intel.com
State New
Headers
Series [v2,1/2] hwmon: (coretemp) Delete tjmax debug message |

Commit Message

Zhang, Rui March 30, 2023, 10:33 a.m. UTC 
  After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic
tjmax"), tjmax value is retrieved from MSR every time the temperature is
read.
This means that, with debug message enabled, the tjmax debug message is
printed out for every single temperature read for any CPU. This spams
the syslog.

Ideally, as tjmax is package scope unique, the debug message should show
once when tjmax is changed for one package. But this requires inventing
some new per-package data in the coretemp driver, and this is overkill.

To keep the code simple, delete the tjmax debug message.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/hwmon/coretemp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Guenter Roeck April 7, 2023, 4 p.m. UTC | #1 
On Thu, Mar 30, 2023 at 06:33:45PM +0800, Zhang Rui wrote:
> After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic
> tjmax"), tjmax value is retrieved from MSR every time the temperature is
> read.
> This means that, with debug message enabled, the tjmax debug message is
> printed out for every single temperature read for any CPU. This spams
> the syslog.
> 
> Ideally, as tjmax is package scope unique, the debug message should show
> once when tjmax is changed for one package. But this requires inventing
> some new per-package data in the coretemp driver, and this is overkill.
> 
> To keep the code simple, delete the tjmax debug message.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/coretemp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 30d77f451937..fe3d4d0dcbed 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
>  		 * If the TjMax is not plausible, an assumption
>  		 * will be used
>  		 */
> -		if (val) {
> -			dev_dbg(dev, "TjMax is %d degrees C\n", val);
> +		if (val)
>  			return val * 1000;
> -		}
>  	}
>  
>  	if (force_tjmax) {
diff mbox series

Patch

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 30d77f451937..fe3d4d0dcbed 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -286,10 +286,8 @@  static int get_tjmax(struct temp_data *tdata, struct device *dev)
 		 * If the TjMax is not plausible, an assumption
 		 * will be used
 		 */
-		if (val) {
-			dev_dbg(dev, "TjMax is %d degrees C\n", val);
+		if (val)
 			return val * 1000;
-		}
 	}
 
 	if (force_tjmax) {