Message ID | 20230330095941.428122-3-francesco@dolcini.it |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1016501vqo; Thu, 30 Mar 2023 03:14:07 -0700 (PDT) X-Google-Smtp-Source: AKy350Zz0k3yCp+6MAjg1yBmfBd2tdo0LsvgcVooeKuz9PaMYjxlWQt/l8bKayjA2p4Pk/5v1pbN X-Received: by 2002:a17:906:44b:b0:931:624b:680c with SMTP id e11-20020a170906044b00b00931624b680cmr23374451eja.29.1680171246919; Thu, 30 Mar 2023 03:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680171246; cv=none; d=google.com; s=arc-20160816; b=Toaq8I8BCjXCHIXwgixXhpcD0VP+q5aH5UX2C4B8j90tNBLjAKgc8dOAmuqI3nT83y MZMVpAQgoL8v0aN9BbnqBGyyS+ta1UIDsnMva96jDJwpB3wBWj4bVOxWkYeb5kvw52zR urgZm+rU/SlH64My4kGpU2wpzc4hVPiBYbFjF9S00WbQvaJxmsSOCvp6PjXxELj51zf+ KUWOEt+2zRQhd6mVtMc0cNCfdpK28mop0153kAOd6pY3B/19msyNr7b8XcxyjMNAcku1 oQQa3or9PwYfbkQMgIyD9K/GXg4CatJdfsu3aP1YGLJW+l3DMNjhPith3KG8UtU9YllQ 7BQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=f5SHOq7v4DKQ0EXI0GfgrVVX6lOxfTJ2iQTkcpAn230=; b=u8j6Vrd/zZM/euPS80yBKzlEExoA0LBp74wuBBqrGILQLl9ns6kAPZ+bdlPfZVlRVv w4Wq8Kd4b8AXSzkO0yTTnvNJx8+njFv1S1TEEZ6TFBMjgzvOITlOK5qV0+XeG8ppYcmI v8ORSynd610EQ/iHRC2BESmzQou5GzbSw5/Itcdm/WZA8bOIn1yRKX6f+WARYqgbXHDE LZX4EidQ4M6iFyxZaNHOKdeHDyor33+9kg4HQx8o1Xcuaze2F9cIU82rxWFMAyHV3ucR FcbtI8EWmLsbUTlBQEkK8A1cpBAO5OMXkdbiEbtIsiIdfT6tEJwvsv4D7/qt+eaUavBk 3PLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020a170906914e00b0093331b35aaasi27206140ejw.813.2023.03.30.03.13.42; Thu, 30 Mar 2023 03:14:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjC3KAA (ORCPT <rfc822;rua109.linux@gmail.com> + 99 others); Thu, 30 Mar 2023 06:00:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbjC3J7v (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 30 Mar 2023 05:59:51 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 532C01BC; Thu, 30 Mar 2023 02:59:50 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 493E420F59; Thu, 30 Mar 2023 11:59:48 +0200 (CEST) From: Francesco Dolcini <francesco@dolcini.it> To: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Peter Ujfalusi <peter.ujfalusi@ti.com>, devicetree@vger.kernel.org Cc: Francesco Dolcini <francesco.dolcini@toradex.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Date: Thu, 30 Mar 2023 11:59:37 +0200 Message-Id: <20230330095941.428122-3-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761787245538119221?= X-GMAIL-MSGID: =?utf-8?q?1761787245538119221?= |
Series |
drm/bridge: tc358768: Improve parallel RGB input configuration
|
|
Commit Message
Francesco Dolcini
March 30, 2023, 9:59 a.m. UTC
From: Francesco Dolcini <francesco.dolcini@toradex.com> Add TC9594, from the software point of view this is identical to TC358768 with the main difference being automotive qualified. Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Comments
On 30/03/2023 11:59, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add TC9594, from the software point of view this is identical to > TC358768 with the main difference being automotive qualified. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > index d6dac186ac59..8f22093b61ae 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > @@ -4,19 +4,20 @@ > $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge > +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge > > maintainers: > - Peter Ujfalusi <peter.ujfalusi@ti.com> > > description: | > - The TC358768/TC358778 is bridge device which converts RGB to DSI. > + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. > > properties: > compatible: > enum: > - toshiba,tc358768 > - toshiba,tc358778 > + - toshiba,tc9594 If it is the same, why they are not compatible? I got only three patches out of six, thus I cannot check by myself. Please explain. Best regards, Krzysztof
On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: > On 30/03/2023 11:59, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Add TC9594, from the software point of view this is identical to > > TC358768 with the main difference being automotive qualified. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index d6dac186ac59..8f22093b61ae 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -4,19 +4,20 @@ > > $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge > > +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge > > > > maintainers: > > - Peter Ujfalusi <peter.ujfalusi@ti.com> > > > > description: | > > - The TC358768/TC358778 is bridge device which converts RGB to DSI. > > + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. > > > > properties: > > compatible: > > enum: > > - toshiba,tc358768 > > - toshiba,tc358778 > > + - toshiba,tc9594 > > If it is the same, why they are not compatible? I assume I am not understanding something very basic ... The register description and SW functionality of all these 3 parts is identical. How should be the compatible described in the DT schema in this case? > I got only three patches out of six, thus I cannot check by myself. Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ Do you want to me to send the whole series and not just the DT binding next time? Happy to do it, if you prefer. Francesco
On 31/03/2023 11:30, Francesco Dolcini wrote: > On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: >> On 30/03/2023 11:59, Francesco Dolcini wrote: >>> From: Francesco Dolcini <francesco.dolcini@toradex.com> >>> >>> Add TC9594, from the software point of view this is identical to >>> TC358768 with the main difference being automotive qualified. >>> >>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> >>> --- >>> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> index d6dac186ac59..8f22093b61ae 100644 >>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> @@ -4,19 +4,20 @@ >>> $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# >>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>> >>> -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge >>> +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge >>> >>> maintainers: >>> - Peter Ujfalusi <peter.ujfalusi@ti.com> >>> >>> description: | >>> - The TC358768/TC358778 is bridge device which converts RGB to DSI. >>> + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. >>> >>> properties: >>> compatible: >>> enum: >>> - toshiba,tc358768 >>> - toshiba,tc358778 >>> + - toshiba,tc9594 >> >> If it is the same, why they are not compatible? > > I assume I am not understanding something very basic ... > > The register description and SW functionality of all these 3 parts is > identical. > > How should be the compatible described in the DT schema in this case? Look at any board compatibles for example. > > >> I got only three patches out of six, thus I cannot check by myself. > > Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ > > Do you want to me to send the whole series and not just the DT binding > next time? Happy to do it, if you prefer. So NAK on 4th patch. Don't grow device ID tables needlessly. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index d6dac186ac59..8f22093b61ae 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -4,19 +4,20 @@ $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge maintainers: - Peter Ujfalusi <peter.ujfalusi@ti.com> description: | - The TC358768/TC358778 is bridge device which converts RGB to DSI. + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. properties: compatible: enum: - toshiba,tc358768 - toshiba,tc358778 + - toshiba,tc9594 reg: maxItems: 1