[for-next,25/25] tracing: Unbreak user events

Message ID 20230329194554.139185152@goodmis.org
State New
Headers
Series tracing: Updates for 6.4 |

Commit Message

Steven Rostedt March 29, 2023, 7:45 p.m. UTC
  From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The user events was added a bit prematurely, and there were a few kernel
developers that had issues with it. The API also needed a bit of work to
make sure it would be stable. It was decided to make user events "broken"
until this was settled. Now it has a new API that appears to be as stable
as it will be without the use of a crystal ball. It's being used within
Microsoft as is, which means the API has had some testing in real world
use cases. It went through many discussions in the bi-weekly tracing
meetings, and there's been no more comments about updates.

I feel this is good to go.

Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/trace/Kconfig | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Steven Rostedt March 29, 2023, 8:29 p.m. UTC | #1
I forgot to Cc Beau on this.

-- Steve

On Wed, 29 Mar 2023 15:45:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> 
> The user events was added a bit prematurely, and there were a few kernel
> developers that had issues with it. The API also needed a bit of work to
> make sure it would be stable. It was decided to make user events "broken"
> until this was settled. Now it has a new API that appears to be as stable
> as it will be without the use of a crystal ball. It's being used within
> Microsoft as is, which means the API has had some testing in real world
> use cases. It went through many discussions in the bi-weekly tracing
> meetings, and there's been no more comments about updates.
> 
> I feel this is good to go.
> 
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
>  kernel/trace/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index c7020e071bf9..8cf97fa4a4b3 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -792,7 +792,6 @@ config USER_EVENTS
>  	bool "User trace events"
>  	select TRACING
>  	select DYNAMIC_EVENTS
> -	depends on BROKEN || COMPILE_TEST # API needs to be straighten out
>  	help
>  	  User trace events are user-defined trace events that
>  	  can be used like an existing kernel trace event.  User trace
  

Patch

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index c7020e071bf9..8cf97fa4a4b3 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -792,7 +792,6 @@  config USER_EVENTS
 	bool "User trace events"
 	select TRACING
 	select DYNAMIC_EVENTS
-	depends on BROKEN || COMPILE_TEST # API needs to be straighten out
 	help
 	  User trace events are user-defined trace events that
 	  can be used like an existing kernel trace event.  User trace