diff mbox series

mwifiex: remove unused evt_buf variable

Message ID 20230329131444.1809018-1-trix@redhat.com
State New
Headers
Series mwifiex: remove unused evt_buf variable |

Commit Message

Tom Rix March 29, 2023, 1:14 p.m. UTC 
  clang with W=1 reports
drivers/net/wireless/marvell/mwifiex/11h.c:198:6: error: variable
  'evt_buf' set but not used [-Werror,-Wunused-but-set-variable]
        u8 *evt_buf;
            ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/wireless/marvell/mwifiex/11h.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Simon Horman March 29, 2023, 1:44 p.m. UTC | #1 
On Wed, Mar 29, 2023 at 09:14:44AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/wireless/marvell/mwifiex/11h.c:198:6: error: variable
>   'evt_buf' set but not used [-Werror,-Wunused-but-set-variable]
>         u8 *evt_buf;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Kalle Valo March 29, 2023, 4:16 p.m. UTC | #2 
Tom Rix <trix@redhat.com> writes:

> clang with W=1 reports
> drivers/net/wireless/marvell/mwifiex/11h.c:198:6: error: variable
>   'evt_buf' set but not used [-Werror,-Wunused-but-set-variable]
>         u8 *evt_buf;
>             ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

There should be "wifi:" in title, but I can add that during commit.
Kalle Valo March 31, 2023, 2:54 p.m. UTC | #3 
Tom Rix <trix@redhat.com> wrote:

> clang with W=1 reports
> drivers/net/wireless/marvell/mwifiex/11h.c:198:6: error: variable
>   'evt_buf' set but not used [-Werror,-Wunused-but-set-variable]
>         u8 *evt_buf;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Patch applied to wireless-next.git, thanks.

074d0a1ae1fe wifi: mwifiex: remove unused evt_buf variable
diff mbox series

Patch

diff --git a/drivers/net/wireless/marvell/mwifiex/11h.c b/drivers/net/wireless/marvell/mwifiex/11h.c
index b0c40a776a2e..2ea03725f188 100644
--- a/drivers/net/wireless/marvell/mwifiex/11h.c
+++ b/drivers/net/wireless/marvell/mwifiex/11h.c
@@ -195,7 +195,6 @@  int mwifiex_11h_handle_chanrpt_ready(struct mwifiex_private *priv,
 {
 	struct host_cmd_ds_chan_rpt_event *rpt_event;
 	struct mwifiex_ie_types_chan_rpt_data *rpt;
-	u8 *evt_buf;
 	u16 event_len, tlv_len;
 
 	rpt_event = (void *)(skb->data + sizeof(u32));
@@ -208,8 +207,6 @@  int mwifiex_11h_handle_chanrpt_ready(struct mwifiex_private *priv,
 		return -1;
 	}
 
-	evt_buf = (void *)&rpt_event->tlvbuf;
-
 	while (event_len >= sizeof(struct mwifiex_ie_types_header)) {
 		rpt = (void *)&rpt_event->tlvbuf;
 		tlv_len = le16_to_cpu(rpt->header.len);
@@ -231,7 +228,6 @@  int mwifiex_11h_handle_chanrpt_ready(struct mwifiex_private *priv,
 			break;
 		}
 
-		evt_buf += (tlv_len + sizeof(rpt->header));
 		event_len -= (tlv_len + sizeof(rpt->header));
 	}