diff mbox series

[1/2] arm64: dts: ti: k3-j721e-main: Switch MAIN R5F clusters to Split-mode

Message ID 20230329063728.14126-2-a-nandan@ti.com
State New
Headers
Series arm64: dts: ti: k3-j72xx-main: Switch MAIN R5F clusters to Split-mode |

Commit Message

Apurva Nandan March 29, 2023, 6:37 a.m. UTC 
  From: Suman Anna <s-anna@ti.com>

J721E SoCs have two R5F clusters in the MAIN domain, and both of these
are configured for LockStep mode at the moment. Switch both of these R5F
clusters to Split mode by default to maximize the number of R5F cores.
The MCU R5F cluster continues to be in the preferred LockStep mode.

Note that this configuration is the default for remoteproc mode (kernel
driver boots the R5F processors). These will be overridden for early-booted
remoteprocs through the corresponding IPC-only support in the K3 R5F
remoteproc driver.

Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Nishanth Menon March 29, 2023, 12:48 p.m. UTC | #1 
On 12:07-20230329, Apurva Nandan wrote:
> From: Suman Anna <s-anna@ti.com>
> 
> J721E SoCs have two R5F clusters in the MAIN domain, and both of these
> are configured for LockStep mode at the moment. Switch both of these R5F
> clusters to Split mode by default to maximize the number of R5F cores.
> The MCU R5F cluster continues to be in the preferred LockStep mode.
> 
> Note that this configuration is the default for remoteproc mode (kernel
> driver boots the R5F processors). These will be overridden for early-booted
> remoteprocs through the corresponding IPC-only support in the K3 R5F
> remoteproc driver.
> 

This looks like a firmware specific behavior, best done in overlay along
with any custom memory map controls you may have to do for that specific
firmware.

If this is indeed a fixes, the commit message needs to clearly indicate
why this is a fix and use the Fixes tag to propogate the fixes.

> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index c935622f0102..31dadbdc0d5a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1722,7 +1722,7 @@ watchdog1: watchdog@2210000 {
>  
>  	main_r5fss0: r5fss@5c00000 {
>  		compatible = "ti,j721e-r5fss";
> -		ti,cluster-mode = <1>;
> +		ti,cluster-mode = <0>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
> @@ -1762,7 +1762,7 @@ main_r5fss0_core1: r5f@5d00000 {
>  
>  	main_r5fss1: r5fss@5e00000 {
>  		compatible = "ti,j721e-r5fss";
> -		ti,cluster-mode = <1>;
> +		ti,cluster-mode = <0>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index c935622f0102..31dadbdc0d5a 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1722,7 +1722,7 @@  watchdog1: watchdog@2210000 {
 
 	main_r5fss0: r5fss@5c00000 {
 		compatible = "ti,j721e-r5fss";
-		ti,cluster-mode = <1>;
+		ti,cluster-mode = <0>;
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
@@ -1762,7 +1762,7 @@  main_r5fss0_core1: r5f@5d00000 {
 
 	main_r5fss1: r5fss@5e00000 {
 		compatible = "ti,j721e-r5fss";
-		ti,cluster-mode = <1>;
+		ti,cluster-mode = <0>;
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x5e00000 0x00 0x5e00000 0x20000>,