From patchwork Wed Mar 29 19:17:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 76774 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp644462vqo; Wed, 29 Mar 2023 12:41:45 -0700 (PDT) X-Google-Smtp-Source: AKy350Zca4sopYLqILtrSEfQBceZ2BGimHVlaarHa06VFvc1xROSxsgXsk+xOPVjg/lrgLD4bGkz X-Received: by 2002:a17:907:3e21:b0:930:f953:9614 with SMTP id hp33-20020a1709073e2100b00930f9539614mr27906063ejc.1.1680118905662; Wed, 29 Mar 2023 12:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680118905; cv=none; d=google.com; s=arc-20160816; b=OWFcZLwoW7D8KHwBccpaZgCi5H609QBgsmkeo4ApBEz69tmo91ixGImV91KqsjE/f+ sNrJag1d8RfLJn+1IXHOr8NVRAvBXM76U0x6xjETJkqqCX7/MgaTLLXkXzp//R7oZJPu BEsThQdWI57CNmOXHQaZTJs4fTFRh6GxVlimgeAg7CAy2yUab9zXOeqJTHgbYm3cjjr+ iBhdzJ5X8CJH5Tx71ovNUwhgmNuNPTBf0325oOFTGWRDQnwTK+wOuMVljkvop3d+blqs UniAZnP4r3ML1cucYW6/epJPGiA2Aj7Wj9ABPgBM1GSD7kl0bO7K4Tk5Sjkb6quxAC8k qQjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=PkKk7Qpt0miI3NiUcSnncqHdyr3DuNCBLMRDZMN+mTU=; b=PSyvLzVZexdDdGYXbWnf1zeb2IvcxHq9RSXH3cRFf67+fB1eLXARxtXiaUqBcu3WqA v2nNgqh8pVCdodWO8INYUkbzPxoCVtbjfOHGn3oUX+JOFkcWplHQIFrp6ANmDzyPodY6 VpmKnzlK7GfQVhvSaZyUHSrfGVtjwasGUtzRP2XIgtgbjgAWdMRMvFwCQS8ZXTlbyert fRbd4i6FR5NXcTBgEsT6BQQMKIjFO3rfy/87ccNSWZApE/ECvHOUNUarbX6Td/UTofec Xhfa44l6LOQLCNXQ8/y0TRmZxoqrcAbOGGFEf1w7ubBYq8LS3AetqSzh0+gJQsxZBQ0F SeHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=enBcjGxx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz31-20020a1709077d9f00b0093defbd6280si17401146ejc.1031.2023.03.29.12.41.20; Wed, 29 Mar 2023 12:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=enBcjGxx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbjC2TSB (ORCPT + 99 others); Wed, 29 Mar 2023 15:18:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbjC2TRx (ORCPT ); Wed, 29 Mar 2023 15:17:53 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51F906A4D for ; Wed, 29 Mar 2023 12:17:43 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id s20so17278049ljp.1 for ; Wed, 29 Mar 2023 12:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680117461; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PkKk7Qpt0miI3NiUcSnncqHdyr3DuNCBLMRDZMN+mTU=; b=enBcjGxxUnor9oWLRKL39mGkXt0uM4ukXO4TmIUsx8QDTVJHE+WtDZJp8K6XZtoUsO TtPTRxWK2LFhLrFf4LbFuqwmGw457e0bhK7OydymVlxIrOBf48dOQvOGlTqCzguFflOD YeyL8hWsKo5R0OyIMLU63dzzDWsGQ+Ham8ad67fdl6G+QEbuZp79MnA80woYVwVd5fMF r1slPiC7RNS6x3IwlPQqR7CVKKBuK5VloT4SKHBNqUs9EGlMN7THx2mC1SdSaBCajuH1 uUWVG2VleI+tiKgTLS7u+YD4KkyBxjGZqlhzYA8LomlrT+FeMM+t5OxMTSNk6FtSYYEN ZvRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680117461; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PkKk7Qpt0miI3NiUcSnncqHdyr3DuNCBLMRDZMN+mTU=; b=uosC5AlU0ZS0VvS/1IIz1TfUmfjST8mmLdmZuYQinxG+N/D2iWigaoUDJcHcs89RV0 TstvepobDX+2uoIqsEz53MbQRFnYDIcq3LLJ1COKgYRAdOd0jU7m556JmNd1cRduHM92 9OUOblaSoeOYF1cSeLyVaLl2WNabu+gEgH24kWkIpVq78KIPTIAI2RXdytgFFOhyje4o jZrWNyVYBCAU0ZY6k6/aZ8EK6gQFcUN7+nExt+1R9aG71KaudpQcRQocmOlwxkrcE4Kw 8ecM8RjbUzZm1/VMEyWifwf1ECj0qA3h0+neERI4yzFeceVFwwkOTYkfbGG30xOs5v5L hyKg== X-Gm-Message-State: AAQBX9cS/gtdo2XpNR7mtL20FWEMekQPiIsoS+jMUNOQO23ag4A1Pn7G L+xPCiULEy3Qq8aGKzkI4Aa5rw== X-Received: by 2002:a2e:9bcf:0:b0:29e:a3a0:ee2f with SMTP id w15-20020a2e9bcf000000b0029ea3a0ee2fmr5997809ljj.30.1680117461681; Wed, 29 Mar 2023 12:17:41 -0700 (PDT) Received: from [192.168.1.101] (abxj225.neoplus.adsl.tpnet.pl. [83.9.3.225]) by smtp.gmail.com with ESMTPSA id f4-20020a2e3804000000b0029ad1fc89b3sm5189658lja.60.2023.03.29.12.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 12:17:41 -0700 (PDT) From: Konrad Dybcio Date: Wed, 29 Mar 2023 21:17:31 +0200 Subject: [PATCH 4/4] arm64: dts: qcom: msm8916: Improve GPU OPP table MIME-Version: 1.0 Message-Id: <20230329-topic-adreno_opp-v1-4-24d34ac6f007@linaro.org> References: <20230329-topic-adreno_opp-v1-0-24d34ac6f007@linaro.org> In-Reply-To: <20230329-topic-adreno_opp-v1-0-24d34ac6f007@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Jordan Crouse , Srinivas Kandagatla , Vivek Gautam , Vinod Koul , Rob Clark , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1680117452; l=1898; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=JPOS4C7Jq8MAmse1/02vKyaIWx2AGQSTrD2cYU4Vq9M=; b=lR/hlBWa2ERR2A1gCrnw36uoxaK8g9TG5iXuPzYclbj1Ce9GkiXJWntiYjP8oOqkHpGQkzk4jdjf xNIJmF5aCXtrCkWWqIkgo6zRBmnrYl36cNeRr/WMJC811dC8QWzk X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761732361607908847?= X-GMAIL-MSGID: =?utf-8?q?1761732361607908847?= Add required-opps to ensure reasonable power domain levels are voted for (currently we've been piggybacking off of miracles and MDP votes), add missing frequencies and add newlines between each subnode. Fixes: 61b83be9117c ("arm64: dts: qcom: msm8916: Add gpu support") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 639b158b4fbe..13bd0c647c1d 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -1287,18 +1287,31 @@ gpu@1c00000 { <&gcc GCC_BIMC_GFX_CLK>, <&gcc GCC_BIMC_GPU_CLK>, <&gcc GFX3D_CLK_SRC>; - power-domains = <&gcc OXILI_GDSC>; + power-domains = <&rpmpd MSM8916_VDDCX>; operating-points-v2 = <&gpu_opp_table>; iommus = <&gpu_iommu 1>, <&gpu_iommu 2>; gpu_opp_table: opp-table { compatible = "operating-points-v2"; + opp-27000000 { + opp-hz = /bits/ 64 <27000000>; + required-opps = <&rpmpd_opp_svs_krait>; + }; + + opp-200000000 { + opp-hz = /bits/ 64 <200000000>; + required-opps = <&rpmpd_opp_svs_soc>; + }; + + opp-310000000 { + opp-hz = /bits/ 64 <310000000>; + required-opps = <&rpmpd_opp_nom>; + }; + opp-400000000 { opp-hz = /bits/ 64 <400000000>; - }; - opp-19200000 { - opp-hz = /bits/ 64 <19200000>; + required-opps = <&rpmpd_opp_super_turbo>; }; }; }; @@ -1368,6 +1381,7 @@ gpu_iommu: iommu@1f08000 { clocks = <&gcc GCC_SMMU_CFG_CLK>, <&gcc GCC_GFX_TCU_CLK>; clock-names = "iface", "bus"; + power-domains = <&gcc OXILI_GDSC>; qcom,iommu-secure-id = <18>; /* GFX3D_USER */