| Message ID | 20230328053853.23159-1-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1992521vqo;
Mon, 27 Mar 2023 22:54:07 -0700 (PDT)
X-Google-Smtp-Source:
AKy350YYZnwGkxSKJ4MI5tErgKu3lxwMrEqoVlJgs4xT+f7hYNyXBE+WS1wKzI0U3hUqI4LwJ0IC
X-Received: by 2002:a17:902:ce83:b0:19e:ad18:da5c with SMTP id
f3-20020a170902ce8300b0019ead18da5cmr17767682plg.37.1679982846912;
Mon, 27 Mar 2023 22:54:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679982846; cv=none;
d=google.com; s=arc-20160816;
b=JocoKz4kNSw6XVQJoMh15WZ4qiFIame0wsit1zTLz1jHQS8otKgi68hJKAv5rFrEp5
IhfrHDmIk2Iu0zvDYcrtBR3l4nvxlNczn/6Lcs4mKit01wTzTvNoAy06y4SiZeQI7E09
rdk7ks/pF4FfqoqbfZFyc/sXjKBeMUq5xNgdYD2v5hYk/S4ejbaImovH9gX7YyXGIsVQ
4HAUZA2iNquhAmCt2hMPPghCK/QXppI65gkAnzTSmiui6B8jSguNqlCZ8gurAaHahHtL
7nT/XLxxLU8QAzyo+yiLt9hJDF0LiVxyqOUdxq7GgGOBE3CDxKYhXxXBXiUK6Ytg4PQ7
v6hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=SzQ0xUiMiySKiDi/Sql5TnvouoT1QDKXxVb/2v8ihQ0=;
b=fiOdA9dLkpnDg12IcoPWCGt3lmId6/t/BuIRCOJXxkBj/1pOLNCPHjgzNbtq+xbAmA
MwilZFlI0hiwjL63l65Hya+Tfx3cXDBQP51XBmqX7k07M2R6zYLvexE6XbyxQcMPzXNs
J3VQbakZ3lOS/v7LZdqivIv2F48c+zwMLxzF6ERlXu47BfoAqlBUt5aMZm89kDuIlkry
mDO8EPrxWx0TkVP6RDYvxco30YbKotYJDI7pM2s+dUAEovpwJdLcP6aB6WQDs16NSOcG
v5ZD4O3XZbmiL1r8hz4qP3QiFyQTzzxFOAS2hdfei2Wxj2qNX/3GtLwMS6tBjmwXn+co
qgAQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
d12-20020a170902cecc00b001a1e4051dbbsi8965326plg.31.2023.03.27.22.53.54;
Mon, 27 Mar 2023 22:54:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231913AbjC1FjC (ORCPT <rfc822;kartikey406@gmail.com>
+ 99 others); Tue, 28 Mar 2023 01:39:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58458 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231244AbjC1FjA (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 28 Mar 2023 01:39:00 -0400
Received: from out30-133.freemail.mail.aliyun.com
(out30-133.freemail.mail.aliyun.com [115.124.30.133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 284E6210E;
Mon, 27 Mar 2023 22:38:57 -0700 (PDT)
X-Alimail-AntiSpam:
AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Verphm-_1679981934;
Received: from localhost(mailfrom:yang.lee@linux.alibaba.com
fp:SMTPD_---0Verphm-_1679981934)
by smtp.aliyun-inc.com;
Tue, 28 Mar 2023 13:38:55 +0800
From: Yang Li <yang.lee@linux.alibaba.com>
To: krzysztof.kozlowski@linaro.org
Cc: kyungmin.park@samsung.com, myungjoo.ham@samsung.com,
cw00.choi@samsung.com, alim.akhtar@samsung.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>
Subject: [PATCH -next] devfreq: exynos-ppmu: Use
devm_platform_get_and_ioremap_resource()
Date: Tue, 28 Mar 2023 13:38:53 +0800
Message-Id: <20230328053853.23159-1-yang.lee@linux.alibaba.com>
X-Mailer: git-send-email 2.20.1.7.g153144c
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-8.0 required=5.0 tests=ENV_AND_HDR_SPF_MATCH,
RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761589693499643198?=
X-GMAIL-MSGID: =?utf-8?q?1761589693499643198?=
|
| Series |
[-next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()
|
|
Commit Message
Yang Li
March 28, 2023, 5:38 a.m. UTC
According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/devfreq/event/exynos-ppmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On 28/03/2023 07:38, Yang Li wrote: > According to commit 890cc39a8799 ("drivers: provide > devm_platform_get_and_ioremap_resource()"), convert I don't understand why do you reference this commit. There is no bug introduced there, there is nothing related to this driver. > platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. Best regards, Krzysztof
Hi, On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote: > On 28/03/2023 07:38, Yang Li wrote: > > According to commit 890cc39a8799 ("drivers: provide > > devm_platform_get_and_ioremap_resource()"), convert > > I don't understand why do you reference this commit. There is no bug > introduced there, there is nothing related to this driver. > > > platform_get_resource(), devm_ioremap_resource() to a single > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > what this function does. I've seen Yang has sent many of these cleanups, perhaps he can write something like: " Commit 890cc39a8799 ("drivers: provide devm_platform_get_and_ioremap_resource()") introduces the devm_platform_get_and_ioremap_resource() function which combines both platform_get_resource() and devm_ioremap_resource() into a single call. Update the code to use the new combined function instead of the separate calls. " With that Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi
On 28/03/2023 11:53, Andi Shyti wrote: > Hi, > > On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote: >> On 28/03/2023 07:38, Yang Li wrote: >>> According to commit 890cc39a8799 ("drivers: provide >>> devm_platform_get_and_ioremap_resource()"), convert >> >> I don't understand why do you reference this commit. There is no bug >> introduced there, there is nothing related to this driver. >> >>> platform_get_resource(), devm_ioremap_resource() to a single >>> call to devm_platform_get_and_ioremap_resource(), as this is exactly >>> what this function does. > > I've seen Yang has sent many of these cleanups, perhaps he can > write something like: > > " > Commit 890cc39a8799 ("drivers: provide > devm_platform_get_and_ioremap_resource()") introduces the > devm_platform_get_and_ioremap_resource() function which combines > both platform_get_resource() and devm_ioremap_resource() into a > single call. I don't think we need to reference that commit at all. It does not matter when the API was introduced and just makes commit msg unnecessary long. Instead the commit msg should shortly say why this change is needed or even worth accepting. > > Update the code to use the new combined function instead of the > separate calls. Best regards, Krzysztof
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index a443e7c42daf..896a6cc93b00 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -621,8 +621,7 @@ static int exynos_ppmu_parse_dt(struct platform_device *pdev, } /* Maps the memory mapped IO to control PPMU register */ - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(base)) return PTR_ERR(base);