| Message ID | 20230328-topic-msgram_mpm-v1-1-1b788a5f5a33@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2097829vqo;
Tue, 28 Mar 2023 03:07:23 -0700 (PDT)
X-Google-Smtp-Source:
AKy350bRyhJsD/JP8Rvjnkmm81vf042IA4jR5zVnAYQ1qEAK7mZ6NopoF95tM6Z/tFs71IYkeHBt
X-Received: by 2002:a17:906:3193:b0:932:1af9:7386 with SMTP id
19-20020a170906319300b009321af97386mr14722493ejy.27.1679998042790;
Tue, 28 Mar 2023 03:07:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679998042; cv=none;
d=google.com; s=arc-20160816;
b=gbJggTquwbf0AAP902Gq6TG8ISBwnOyN3eegrdWoAO0f46S8sQ0hbyhBNWNTbTi3GQ
HXQVKsS59ktR20Y4YvSp+UgE1BSn6dsFGhOmrKP9qOa3pU7RNHgK0pBJCkf8Vjik0xEh
T0yQHExC6bj5Om1viVmIVQwTBNPAB87fZq2LUYFbRlDoVUfQ03vRZelx26B/vN81L+q5
QzDwiPn1MdsL08zEm3u/jC7BfjdYI+Q+lzNLxNbrF98mnUHxJmRR90h3vK1s7ZXF4CRQ
1ahuPM2wilfR3GHaKx5ES+EC+UxrZ/C36EdXEFereVIJmym2evWQaIESfqcp2erLxvi0
UxcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:cc:to:in-reply-to:references:message-id
:content-transfer-encoding:mime-version:subject:date:from
:dkim-signature;
bh=0PzeyQrd2Tc1EuOfrldCPoi2vXLAKnhW3XMPQDwN2ac=;
b=kh5Ejdg6pD9Qh4yWe9VNWfLKjoqGEkUz5pDxnoSHjwjo80lhPLGxLnKC95IxZ2Fctn
flEIUt0ZiX7K2NoadmyUyrWWmXwNF9rHB4Y0b49jZs/fK5SP9LQ49MoLYhw92lACNvag
9Tiws6XOHffCZOuur9En3lKVPeZ3gYWi7VDAMUN/h8mTBKstqawcFL5JE1UGgu+FqcSG
9OrLe3ots9LETY4a8ywe0SMnlOOpnCeM1iDqBNltiHYR0DK7v7qyj8455BgtovDb9kT8
AMesCZI7C/CO7KZ6DP6BXrg1BY1/fj4tkEEcpxtLzS5oAhWHYfkqGu0xzEpusC2/mkna
Xj+w==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=f4c1QRz0;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
o6-20020a17090611c600b008c7986cbd76si27781336eja.745.2023.03.28.03.06.59;
Tue, 28 Mar 2023 03:07:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=f4c1QRz0;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232777AbjC1KDS (ORCPT <rfc822;kartikey406@gmail.com>
+ 99 others); Tue, 28 Mar 2023 06:03:18 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53584 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231238AbjC1KDG (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 28 Mar 2023 06:03:06 -0400
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
[IPv6:2a00:1450:4864:20::12b])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A59996184
for <linux-kernel@vger.kernel.org>;
Tue, 28 Mar 2023 03:03:03 -0700 (PDT)
Received: by mail-lf1-x12b.google.com with SMTP id h25so15048830lfv.6
for <linux-kernel@vger.kernel.org>;
Tue, 28 Mar 2023 03:03:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1679997782;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=0PzeyQrd2Tc1EuOfrldCPoi2vXLAKnhW3XMPQDwN2ac=;
b=f4c1QRz0gcjGtyirFi0ANq0c/1qKueB5uUwVlvypcnBvwqg8GWZIngXHoI6g7W0VLr
wnxQLYQKSK7Rv98k1xeV8aZcCTY+0CjQXvB20yPQRAVl3fyfNyOe79jUZwUAZ//jaKb1
CUyzsYWFFLKBFB7dGe+8j+2J42ODchwmo3TQ6Y2ZsJ6piJDYP2+XrLpXaUKB3fiaHSRX
kxR/ctPJG+JSHkgVgOYRcDH0GqB4+O9z109PcrwBDy7m+LojQVe+m2dXgkUMwOpTkmys
rljRgZZgXJkGLfDF3uFg8r64xK1tqd/YcfFwLhz/xy+Dg2QsTN/g17dAypWNJwPOU4oF
VMPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1679997782;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=0PzeyQrd2Tc1EuOfrldCPoi2vXLAKnhW3XMPQDwN2ac=;
b=K2xVzhAK5ZfBp9ff4yfwFQhxllgYjR1qvC7XuSTvA9efI6QHXFS8YyDSC7EZFYqzSA
WupRmiiEAR66t6bRmyCFkEhK/9lRPelYnu4J9V5KnHGWDGSrpig3rY9ymahOl8+tLQI3
pIy/R/jVKcsPGppOdZ7xOr0ZmYuTnL8b1Aqe7CU049YRS3An7Ft82NmRaYxezDJQFsyJ
JJSi+7vJZCWT4oBv+AZzt2m74H/youq7gbMENcQfFwtbtoHuC77I5Z3S+XHUGUsR9vcA
xJNqYnLVh9fGlVdwGmmEPuy/fVdbSuZ0sspPkqZdXnvbNQjyjYAkSVBB0M9/VkmsYU01
ymig==
X-Gm-Message-State: AAQBX9eR3RK4hoHmLG+WcjHOuPYvHp+Y/BosWOjSCyXuTwJXKv7DVThy
o5uaGDFf3KP0iVxFSHIepk+Sgdf9mfvcStvqudo=
X-Received: by 2002:ac2:5963:0:b0:4d5:ae35:b221 with SMTP id
h3-20020ac25963000000b004d5ae35b221mr4284717lfp.34.1679997782048;
Tue, 28 Mar 2023 03:03:02 -0700 (PDT)
Received: from [192.168.1.101] (abxj225.neoplus.adsl.tpnet.pl. [83.9.3.225])
by smtp.gmail.com with ESMTPSA id
f10-20020ac24e4a000000b004db3e330dcesm5008471lfr.178.2023.03.28.03.03.01
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 28 Mar 2023 03:03:01 -0700 (PDT)
From: Konrad Dybcio <konrad.dybcio@linaro.org>
Date: Tue, 28 Mar 2023 12:02:52 +0200
Subject: [PATCH 1/2] dt-bindings: interrupt-controller: mpm: Allow passing
reg through phandle
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20230328-topic-msgram_mpm-v1-1-1b788a5f5a33@linaro.org>
References: <20230328-topic-msgram_mpm-v1-0-1b788a5f5a33@linaro.org>
In-Reply-To: <20230328-topic-msgram_mpm-v1-0-1b788a5f5a33@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>
X-Mailer: b4 0.12.2
X-Developer-Signature: v=1; a=ed25519-sha256; t=1679997779; l=1381;
i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id;
bh=C4N0Ev8VKX3zoI5LrzMOtOGVDcPvF0sVmEyLrmGffDM=;
b=5VTz0TXYou6dESAd20JbdSqHQfvEqtSex/DVC7nsLbDDDFk1MRXmIhegfP3UUOj0Hwa28Li2VIg9
7jVFDEIBCvVhPHyP1gldQPvO0g3ZxbeD9i8Zi4xH2OVWQZcnicj1
X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519;
pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms=
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761605627819644216?=
X-GMAIL-MSGID: =?utf-8?q?1761605627819644216?=
|
| Series |
Resolve MPM register space situation
|
|
Commit Message
Konrad Dybcio
March 28, 2023, 10:02 a.m. UTC
Due to the wild nature of the Qualcomm RPM Message RAM, we can't really
use 'reg' to point to the MPM's slice of Message RAM without cutting into
an already-defined RPM MSG RAM node used for GLINK and SMEM.
Document passing the register space as a slice of SRAM through the
qcom,rpm-msg-ram property. This also makes 'reg' no longer required.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On Tue, Mar 28, 2023 at 12:02:52PM +0200, Konrad Dybcio wrote: > Due to the wild nature of the Qualcomm RPM Message RAM, we can't really > use 'reg' to point to the MPM's slice of Message RAM without cutting into > an already-defined RPM MSG RAM node used for GLINK and SMEM. > > Document passing the register space as a slice of SRAM through the > qcom,rpm-msg-ram property. This also makes 'reg' no longer required. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > index 509d20c091af..77fe5e0b378f 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > @@ -30,6 +30,11 @@ properties: > description: > Specifies the base address and size of vMPM registers in RPM MSG RAM. > > + qcom,rpm-msg-ram: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the APSS MPM slice of the RPM Message RAM > + > interrupts: > maxItems: 1 > description: > @@ -64,7 +69,6 @@ properties: > > required: > - compatible > - - reg It's not my call, but I wonder if we need to maintain the 'reg' ABI at all, as there is no DTS landed so far. In either case, I suggest we update the example to adopt the new way. Shawn > - interrupts > - mboxes > - interrupt-controller > > -- > 2.40.0 >
On 28/03/2023 12:02, Konrad Dybcio wrote: > Due to the wild nature of the Qualcomm RPM Message RAM, we can't really > use 'reg' to point to the MPM's slice of Message RAM without cutting into > an already-defined RPM MSG RAM node used for GLINK and SMEM. > > Document passing the register space as a slice of SRAM through the > qcom,rpm-msg-ram property. This also makes 'reg' no longer required. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > index 509d20c091af..77fe5e0b378f 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > @@ -30,6 +30,11 @@ properties: > description: > Specifies the base address and size of vMPM registers in RPM MSG RAM. > > + qcom,rpm-msg-ram: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the APSS MPM slice of the RPM Message RAM > + > interrupts: > maxItems: 1 > description: > @@ -64,7 +69,6 @@ properties: > > required: > - compatible > - - reg Either: 1. make reg deprecated and require qcom,rpm-msg-ram or 2. you need oneOf:required for reg and qcom,rpm-msg-ram > - interrupts > - mboxes > - interrupt-controller > Best regards, Krzysztof
On 29.03.2023 10:27, Krzysztof Kozlowski wrote: > On 28/03/2023 12:02, Konrad Dybcio wrote: >> Due to the wild nature of the Qualcomm RPM Message RAM, we can't really >> use 'reg' to point to the MPM's slice of Message RAM without cutting into >> an already-defined RPM MSG RAM node used for GLINK and SMEM. >> >> Document passing the register space as a slice of SRAM through the >> qcom,rpm-msg-ram property. This also makes 'reg' no longer required. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> index 509d20c091af..77fe5e0b378f 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> @@ -30,6 +30,11 @@ properties: >> description: >> Specifies the base address and size of vMPM registers in RPM MSG RAM. >> >> + qcom,rpm-msg-ram: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to the APSS MPM slice of the RPM Message RAM >> + >> interrupts: >> maxItems: 1 >> description: >> @@ -64,7 +69,6 @@ properties: >> >> required: >> - compatible >> - - reg > > Either: > 1. make reg deprecated and require qcom,rpm-msg-ram > or > 2. you need oneOf:required for reg and qcom,rpm-msg-ram Right, let's go with 1. Konrad > >> - interrupts >> - mboxes >> - interrupt-controller >> > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml index 509d20c091af..77fe5e0b378f 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml @@ -30,6 +30,11 @@ properties: description: Specifies the base address and size of vMPM registers in RPM MSG RAM. + qcom,rpm-msg-ram: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the APSS MPM slice of the RPM Message RAM + interrupts: maxItems: 1 description: @@ -64,7 +69,6 @@ properties: required: - compatible - - reg - interrupts - mboxes - interrupt-controller