From patchwork Mon Mar 27 18:16:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 75616 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1716916vqo; Mon, 27 Mar 2023 11:44:08 -0700 (PDT) X-Google-Smtp-Source: AKy350bAGjAmspUOFgbPYTtHer3eAdYQG4Tfw9euYRYjM6OyZh0h36v+rwU3xdfFGPMOyBhlh6/4 X-Received: by 2002:aa7:c915:0:b0:4fd:2674:4ff2 with SMTP id b21-20020aa7c915000000b004fd26744ff2mr14070025edt.11.1679942648730; Mon, 27 Mar 2023 11:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679942648; cv=none; d=google.com; s=arc-20160816; b=mH/Oq+eY10yztozFweofc+rTomFCZ/ct1VkXRfokTsgwYDn8iEWi1dXl1HFvmV2wFX G973XcfE9BkMQMU5zrb6Q4mhu2zYORCgdR3YfR6orRxDFv+FbADzAQmqTG7o5laNcJdl NsTJsoJKgzu+czXBnPi0RwjojJkeHwVA0XGoQkrpCUR6bE4+TrWGUOrrJToK3dB45i9h l9RGruGkMdHJvhmDNse0btyCi0kGlGVNdj9U6HEA5nIgjl1s/8YruXTihn2+4fvynQKF JcGeRIU77GNZAxvQ/Kd1ySJ9ClLqU4x2Cp0TdG6PSwoyflip+ggTx1nTyWPViZanojz0 0x7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gcEYCPEwYdmtRMP4lGXFZqWyc63g+86RobAwaQ/GDQo=; b=XSlghpxxoBYom0naH0BFJ1ITRXSNAd67uD/Fqq7sQ/i29I6TN811nS2dTjAn2HsnDR IWvLvrWIfbPJw691d2KJwTIE3GKXgm2Phvi6/fHj2WmfMPj1cblbEX0d00UYE6B4YsCy uSnty1JhCwEAfgN5cTQnP1MBax6bOo8io1goOxcnYjbQD1Rlqj0NLhkZxe6FrdgMYPn7 5hlBRbXEIE1I5Yzl5fy+Nw1dquqGWPammlK5DNYoH6luTJqk//60E9f8wgYaFCUssd2J yt9bOk1aToTxhDAOdz17vujkqWO+WaFqogY9FFK+D683rH08Iq/ZTLxtLHxqA1zpofyr ORfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="CvlUsE/u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020aa7cfcc000000b004fd2d153c51si29727560edy.273.2023.03.27.11.43.45; Mon, 27 Mar 2023 11:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="CvlUsE/u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232186AbjC0SQR (ORCPT + 99 others); Mon, 27 Mar 2023 14:16:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbjC0SQP (ORCPT ); Mon, 27 Mar 2023 14:16:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82DD03A81 for ; Mon, 27 Mar 2023 11:16:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94BC5B818AB for ; Mon, 27 Mar 2023 18:16:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ABABC4339B; Mon, 27 Mar 2023 18:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679940971; bh=zdL+k3/HodzdiDKsCUqJ/ncG7UqyOUXuharkX+zcLow=; h=From:To:Cc:Subject:Date:From; b=CvlUsE/ur0tboElKU6eL5mxsD6spgitv88oe/0jq9Kj2Rus+RyRoeHzd2dY5KValB YAtfBpPENsPYo6hyXSPyN9gqsNVG6x+aDoI67NJlBB5He3bP6irbz3rZcH7G72FSbF MuVLp77uf+hhqMXQTYUMI9EE2Va+g/0U2Srl4gVs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, kernel test robot Subject: [PATCH] powerpc/fsl: fix compiler warning in fsl_wakeup_sys_init() Date: Mon, 27 Mar 2023 20:16:06 +0200 Message-Id: <20230327181606.1424846-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1498; i=gregkh@linuxfoundation.org; h=from:subject; bh=zdL+k3/HodzdiDKsCUqJ/ncG7UqyOUXuharkX+zcLow=; b=owGbwMvMwCRo6H6F97bub03G02pJDCmKd1PEzCpzpPdXvExbrvBGNNHU64CndspJde0le3miT yzd8sK+I5aFQZCJQVZMkeXLNp6j+ysOKXoZ2p6GmcPKBDKEgYtTACYyZQbDgml9rFfN3XKLl/Bc Unw3z4TruvLSiQwLtp/fVzNN0pfz85+QPf/TlV5UnFrzBQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761547542469507507?= X-GMAIL-MSGID: =?utf-8?q?1761547542469507507?= Commit c93bd175414a ("powerpc/fsl: move to use bus_get_dev_root()") changed to use bus_get_dev_root() but didn't consider that the function can fail and return an uninitialized value of ret (hint, the function can never fail, but the compiler doesn't know that.) Fix this up by setting ret to -EINVAL just in case something really goes wrong with the call to bus_get_dev_root(). Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Fixes: c93bd175414a ("powerpc/fsl: move to use bus_get_dev_root()") Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303280045.4oaaezcn-lkp@intel.com/ Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c b/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c index 147b5d8bb904..ce6c739c51e5 100644 --- a/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c +++ b/arch/powerpc/sysdev/fsl_mpic_timer_wakeup.c @@ -117,7 +117,7 @@ static struct device_attribute mpic_attributes = __ATTR(timer_wakeup, 0644, static int __init fsl_wakeup_sys_init(void) { struct device *dev_root; - int ret; + int ret = -EINVAL; fsl_wakeup = kzalloc(sizeof(struct fsl_mpic_timer_wakeup), GFP_KERNEL); if (!fsl_wakeup)