From patchwork Mon Mar 27 14:21:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 75501 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1565799vqo; Mon, 27 Mar 2023 07:47:11 -0700 (PDT) X-Google-Smtp-Source: AKy350aQiNmX8SX70cz9JPk7q98AnUMJP0eRXTKor8cuMv6KYxWHddrK4sYk6S2hdNgXexnPj9Qs X-Received: by 2002:a17:907:d047:b0:945:2f54:5eae with SMTP id vb7-20020a170907d04700b009452f545eaemr2987537ejc.77.1679928431015; Mon, 27 Mar 2023 07:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679928431; cv=none; d=google.com; s=arc-20160816; b=AYDAP8K6d9qwnVpkZmocAHeSUDKFAgFuF+1A6iSY/9NPioww9l6UG1UGJ/mYeAnmJb qdyjZJjBrcw2Kl3uz09mQIyggcitETllgR3lgmo28CdvBbnDAv00GrI6i0I5XT1hALRv AAD9eRCaDkTtzMbHzJUnVs9U35QryctF5oLKS4NsUYmAGE+8+scQMn53csn6JcMtHDIW Zq4eU2+gNgjDCYt/SmKRcsnbrM2YPJmm2luviKIYzh4evoTvtvChgqcrFoE7J/kHsjrT KEKz3ilZ4EWl2SOP2hIvWxeNeo/DymuTZO6Xr+vsIswA/5S7Znl/qjlgEFGMG6fvAoPx MSUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=gFaxqRFIyhSZshPbsXa7V3/MnHbXQkvs1SE+2DDrqLQ=; b=OCx5PGR9dBc8w0FA+Vgx8gj/Mxzgcuow0O6PNXCUL93LK461X01vyTw+jlWkJ1MXxq uWoimdLEnNi/Cc9qDmdg2o4fB+zdQuodUTAEks+KSpQAXRJRy/b/gf1Hhk7sFNcSPh2a 0nbpF+IV2Yy5lAvw7UEHZFWOs6DIT1e6Y7QF/FTmuCj5Ih2SKYpUUHkkZuNX2CEfwoMv Zo8zGRS7PfOWNOmBBxonCUoTeHyQKEJe5y6X0iWhdxNgR0HUeFUthseKVwTxHU33UWau PDTIwYmk/FO8mtG+XKIQTH2zfqwsLew/hHEz5lrwKE78BjOi7gU9jc97RZyKH8DZ4BmO nB6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bo22-20020a0564020b3600b004bdf14718c0si26987874edb.99.2023.03.27.07.46.47; Mon, 27 Mar 2023 07:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233034AbjC0OYP (ORCPT + 99 others); Mon, 27 Mar 2023 10:24:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232132AbjC0OXs (ORCPT ); Mon, 27 Mar 2023 10:23:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B6697D8E for ; Mon, 27 Mar 2023 07:22:14 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgnja-0008Hj-Kt; Mon, 27 Mar 2023 16:22:06 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgnjY-0076IK-7Q; Mon, 27 Mar 2023 16:22:04 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgnjW-00Fkik-PV; Mon, 27 Mar 2023 16:22:02 +0200 From: Oleksij Rempel To: Wei Fang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Shenwei Wang , Clark Wang , NXP Linux Team , Amit Cohen , Gal Pressman , Alexandru Tachici , Piergiorgio Beruto , Willem de Bruijn , Vladimir Oltean Subject: [PATCH net-next v2 1/8] net: phy: Add driver-specific get/set_eee support for non-standard PHYs Date: Mon, 27 Mar 2023 16:21:55 +0200 Message-Id: <20230327142202.3754446-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230327142202.3754446-1-o.rempel@pengutronix.de> References: <20230327142202.3754446-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761532634145993733?= X-GMAIL-MSGID: =?utf-8?q?1761532634145993733?= Not all PHYs are implemented fully according to the IEEE 802.3 specification and cannot be handled by the generic phy_ethtool_get/set_eee() functions. To address this, this commit adds driver-specific get/set_eee support, enabling better handling of such PHYs. This is particularly important for handling PHYs with SmartEEE support, which requires specialized management. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/phy/phy.c | 10 ++++++++-- include/linux/phy.h | 5 +++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 0c0df38cd1ab..103484c24437 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1568,7 +1568,10 @@ int phy_ethtool_get_eee(struct phy_device *phydev, struct ethtool_eee *data) return -EIO; mutex_lock(&phydev->lock); - ret = genphy_c45_ethtool_get_eee(phydev, data); + if (phydev->drv->get_eee) + ret = phydev->drv->get_eee(phydev, data); + else + ret = genphy_c45_ethtool_get_eee(phydev, data); mutex_unlock(&phydev->lock); return ret; @@ -1590,7 +1593,10 @@ int phy_ethtool_set_eee(struct phy_device *phydev, struct ethtool_eee *data) return -EIO; mutex_lock(&phydev->lock); - ret = genphy_c45_ethtool_set_eee(phydev, data); + if (phydev->drv->set_eee) + ret = phydev->drv->set_eee(phydev, data); + else + ret = genphy_c45_ethtool_set_eee(phydev, data); mutex_unlock(&phydev->lock); return ret; diff --git a/include/linux/phy.h b/include/linux/phy.h index fefd5091bc24..07cebf110aa6 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1056,6 +1056,11 @@ struct phy_driver { /** @get_plca_status: Return the current PLCA status info */ int (*get_plca_status)(struct phy_device *dev, struct phy_plca_status *plca_st); + + /** @get_eee: Return the current EEE configuration */ + int (*get_eee)(struct phy_device *phydev, struct ethtool_eee *e); + /** @set_eee: Set the EEE configuration */ + int (*set_eee)(struct phy_device *phydev, struct ethtool_eee *e); }; #define to_phy_driver(d) container_of(to_mdio_common_driver(d), \ struct phy_driver, mdiodrv)