| Message ID | 20230327094742.38856-3-christophe.kerello@foss.st.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1395338vqo;
Mon, 27 Mar 2023 03:10:20 -0700 (PDT)
X-Google-Smtp-Source:
AKy350ZXgKJubafYjXbke8TyBAkpncIxiAn/nZ8nrk9tB+1oxlbXs+ThU5MyilPLduJYBGYmKzgZ
X-Received: by 2002:a17:907:c25:b0:8b2:d30:e722 with SMTP id
ga37-20020a1709070c2500b008b20d30e722mr16734428ejc.3.1679911820553;
Mon, 27 Mar 2023 03:10:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679911820; cv=none;
d=google.com; s=arc-20160816;
b=apxfgTz3bpn8jnWzW6mw8yS396Na0x20VmctG8lxkIaM5BNDBkGXUEkDzQmQDJxX+W
8FJp0xwILXK1FOth1TEWwg3Cu1aF5KmCEOtLAUPnJyPoZ1y/aJH6NOE0ybo1K07kU4Kn
AJVtNk98vkI5MKgHTC67IxATwC5QFV7TyQARGCjVIsULonskWhrQXPtoECla0212ffSp
cM4DLNTuBVPQGGOoXA1VCHXC6/UO64NwDC2ThTMWd4PdlmeN65+SpcuAbDxi32TaTrkf
ENwhmIpv4FBw1YNLtdJr+yrJ/n2mzxzOPBXZKZgVgr3kfY98FS30pjg58oeIsRDZIctB
w8kQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=qc0y4lAt9GdcmkSaVA/yJM1SimYJoRCkG1QZdOU2rfQ=;
b=yaOUYUxLTpwpa4Y9QFWK7VYNaO83rhN34WDByY0agHfA6frybK/IcxPsyKQxKGwLO5
o7ne0Yh/VkVHt71NR1AikJzF8u1b4eSIiSgoBu/KbfirX9psQalk/cITaRbpmOFRN2G9
e64BEoXY0ukFKtISd1vMhgGrCSTsuA5CpszGZO62AXoJaJP/zpwxFyzP0mTBkOiX0D8M
B8Bu1O+wSH3AXsQEfyjR8UFb74dFqQuSTJz9whwmfdoNDlZrp976INL+9xTgFcFm7eR+
yv62lZKK5FRMpVsUcofUlfYJIG4vjRFox+0CDaAy8p+c+1tsDwrC8/GDKhglnzOZE03M
LJJQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@foss.st.com header.s=selector1 header.b=6LhYbiIN;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
k23-20020a1709067ad700b0092aa2875a02si24962890ejo.193.2023.03.27.03.09.56;
Mon, 27 Mar 2023 03:10:20 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@foss.st.com header.s=selector1 header.b=6LhYbiIN;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232716AbjC0JtB (ORCPT <rfc822;makky5685@gmail.com> + 99 others);
Mon, 27 Mar 2023 05:49:01 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43812 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231196AbjC0Jsz (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 27 Mar 2023 05:48:55 -0400
Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com
[91.207.212.93])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13264272C
for <linux-kernel@vger.kernel.org>;
Mon, 27 Mar 2023 02:48:53 -0700 (PDT)
Received: from pps.filterd (m0046660.ppops.net [127.0.0.1])
by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
32R9EokW009540;
Mon, 27 Mar 2023 11:48:39 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=selector1;
bh=qc0y4lAt9GdcmkSaVA/yJM1SimYJoRCkG1QZdOU2rfQ=;
b=6LhYbiINfXFB2MQn17wpiu3dm3tvDMi40VQ4E/3J/lraYCIYhNZH35mJ36t5W6zsTlpt
sQ1fLf9C5tf8BKjzq8CXOyOSEItC8Rb3k+2FygHfQvvfHL18Zz21tzhslGbORadQlLIh
4soVMbdVNeifyvs4WzRG68KyEW6GFg1xhfsl7z1gtYuI+be0KuGVgtqB0w+Js7187/ns
FCU56LujAdTzHxONjVVLJKFjbuQtT4uRtHGCvDmIZWhohILZdTMBYloHaqn+NdDZxkHW
I7wcNHj6JRSG8MSMst56OwRHogoWQv6dq+5Hgo28qx2SnPgW96R2c3cYZ1HhLVi/1695 IQ==
Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])
by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3pk5xk9fvu-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Mon, 27 Mar 2023 11:48:39 +0200
Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])
by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C5F0A10002A;
Mon, 27 Mar 2023 11:48:38 +0200 (CEST)
Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71])
by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id
C0701212FAC;
Mon, 27 Mar 2023 11:48:38 +0200 (CEST)
Received: from localhost (10.48.0.175) by SHFDAG1NODE3.st.com (10.75.129.71)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 27 Mar
2023 11:48:38 +0200
From: Christophe Kerello <christophe.kerello@foss.st.com>
To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>
CC: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
Christophe Kerello <christophe.kerello@foss.st.com>
Subject: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of
checking tRC_min
Date: Mon, 27 Mar 2023 11:47:42 +0200
Message-ID: <20230327094742.38856-3-christophe.kerello@foss.st.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230327094742.38856-1-christophe.kerello@foss.st.com>
References: <20230327094742.38856-1-christophe.kerello@foss.st.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.48.0.175]
X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com
(10.75.129.71)
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
definitions=2023-03-24_11,2023-03-24_01,2023-02-09_01
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761515217259653597?=
X-GMAIL-MSGID: =?utf-8?q?1761515217259653597?=
|
| Series |
mtd: rawnand: stm32_fmc2: do not support EDO mode
|
|
Commit Message
Christophe Kerello
March 27, 2023, 9:47 a.m. UTC
This patch is using timings.mode value instead of checking tRC_min timing
for EDO mode support.
Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 3/27/23 10:47, Christophe Kerello wrote: > This patch is using timings.mode value instead of checking tRC_min timing > for EDO mode support. > Fixes and Cc to stable here too, as you'd like to have this backported as well, don't you? > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 3abb63d00a0b..9e74bcd90aaa 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > if (IS_ERR(sdrt)) > return PTR_ERR(sdrt); > > - if (sdrt->tRC_min < 30000) > + if (conf->timings.mode > 3) > return -EOPNOTSUPP; > > if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)
Hi Tudor, tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: > On 3/27/23 10:47, Christophe Kerello wrote: > > This patch is using timings.mode value instead of checking tRC_min timing > > for EDO mode support. > > > > Fixes and Cc to stable here too, as you'd like to have this backported > as well, don't you? Actually the reason why Christophe split this into two patches is because timings.mode was introduced rather lately, he wanted the same patch to apply on all stable kernels, he actually asked for that split and I agreed (another solution would have been to send this current patch to Linus and have the other version sent to stable, but it requires a bit of scheduling on both ends). Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t > > > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > > > --- > > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > > index 3abb63d00a0b..9e74bcd90aaa 100644 > > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > > @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > > if (IS_ERR(sdrt)) > > return PTR_ERR(sdrt); > > > > - if (sdrt->tRC_min < 30000) > > + if (conf->timings.mode > 3) > > return -EOPNOTSUPP; > > > > if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) Thanks, Miquèl
On 3/27/23 11:43, Miquel Raynal wrote: > Hi Tudor, > > tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: > >> On 3/27/23 10:47, Christophe Kerello wrote: >>> This patch is using timings.mode value instead of checking tRC_min timing >>> for EDO mode support. >>> >> >> Fixes and Cc to stable here too, as you'd like to have this backported >> as well, don't you? > > Actually the reason why Christophe split this into two patches is > because timings.mode was introduced rather lately, he wanted the same > patch to apply on all stable kernels, he actually asked for that split > and I agreed (another solution would have been to send this current > patch to Linus and have the other version sent to stable, but it > requires a bit of scheduling on both ends). > > Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t Right, I understood that from the beginning. If it were to me, I would Cc: stable@vger.kernel.org #v5.4+ for the first patch and Cc: stable@vger.kernel.org #v5.10+ for the second. So first would be alone just in v5.4, and starting with v5.10 we'll have both and we'll mimic what we currently have in upstream mainline. > >> >>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> >> >> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> >> >>> --- >>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>> index 3abb63d00a0b..9e74bcd90aaa 100644 >>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, >>> if (IS_ERR(sdrt)) >>> return PTR_ERR(sdrt); >>> >>> - if (sdrt->tRC_min < 30000) >>> + if (conf->timings.mode > 3) >>> return -EOPNOTSUPP; >>> >>> if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) > > > Thanks, > Miquèl
Hello Miquel, On 3/27/23 13:06, Tudor Ambarus wrote: > > > On 3/27/23 11:43, Miquel Raynal wrote: >> Hi Tudor, >> >> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: >> >>> On 3/27/23 10:47, Christophe Kerello wrote: >>>> This patch is using timings.mode value instead of checking tRC_min timing >>>> for EDO mode support. >>>> >>> >>> Fixes and Cc to stable here too, as you'd like to have this backported >>> as well, don't you? >> >> Actually the reason why Christophe split this into two patches is >> because timings.mode was introduced rather lately, he wanted the same >> patch to apply on all stable kernels, he actually asked for that split >> and I agreed (another solution would have been to send this current >> patch to Linus and have the other version sent to stable, but it >> requires a bit of scheduling on both ends). >> >> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t > > Right, I understood that from the beginning. If it were to me, I would > Cc: stable@vger.kernel.org #v5.4+ for the first patch and > Cc: stable@vger.kernel.org #v5.10+ for the second. > > So first would be alone just in v5.4, and starting with v5.10 we'll have > both and we'll mimic what we currently have in upstream mainline. > I can send a V3 with cc tag added as per Tudor's suggestion. Or cc tag will be added when the patches will be applied? Regards, Christophe Kerello. >> >>> >>>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> >>> >>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> >>> >>>> --- >>>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> index 3abb63d00a0b..9e74bcd90aaa 100644 >>>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, >>>> if (IS_ERR(sdrt)) >>>> return PTR_ERR(sdrt); >>>> >>>> - if (sdrt->tRC_min < 30000) >>>> + if (conf->timings.mode > 3) >>>> return -EOPNOTSUPP; >>>> >>>> if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) >> >> >> Thanks, >> Miquèl
Hi Christophe, christophe.kerello@foss.st.com wrote on Tue, 28 Mar 2023 09:27:55 +0200: > Hello Miquel, > > On 3/27/23 13:06, Tudor Ambarus wrote: > > > > > > On 3/27/23 11:43, Miquel Raynal wrote: > >> Hi Tudor, > >> > >> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: > >> > >>> On 3/27/23 10:47, Christophe Kerello wrote: > >>>> This patch is using timings.mode value instead of checking tRC_min timing > >>>> for EDO mode support. > >>>> >>> > >>> Fixes and Cc to stable here too, as you'd like to have this backported > >>> as well, don't you? > >> > >> Actually the reason why Christophe split this into two patches is > >> because timings.mode was introduced rather lately, he wanted the same > >> patch to apply on all stable kernels, he actually asked for that split > >> and I agreed (another solution would have been to send this current > >> patch to Linus and have the other version sent to stable, but it > >> requires a bit of scheduling on both ends). > >> > >> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t > > > > Right, I understood that from the beginning. If it were to me, I would > > Cc: stable@vger.kernel.org #v5.4+ for the first patch and > > Cc: stable@vger.kernel.org #v5.10+ for the second. > > > > So first would be alone just in v5.4, and starting with v5.10 we'll have > > both and we'll mimic what we currently have in upstream mainline. > > > > I can send a V3 with cc tag added as per Tudor's suggestion. > Or cc tag will be added when the patches will be applied? I'll handle it, no problem. Is it fine if I send this as part of the next merge window or do you expect this fix to be applied earlier? I just sent my fixes PR on Monday morning. > > Regards, > Christophe Kerello. > > >> > >>> > >>>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > >>> > >>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > >>> > >>>> --- > >>>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > >>>> index 3abb63d00a0b..9e74bcd90aaa 100644 > >>>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > >>>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > >>>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > >>>> if (IS_ERR(sdrt)) > >>>> return PTR_ERR(sdrt); > >>>> >>>> - if (sdrt->tRC_min < 30000) > >>>> + if (conf->timings.mode > 3) > >>>> return -EOPNOTSUPP; > >>>> >>>> if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) > >> > >> > >> Thanks, > >> Miquèl Thanks, Miquèl
Hi Miquel, On 3/28/23 09:56, Miquel Raynal wrote: > Hi Christophe, > > christophe.kerello@foss.st.com wrote on Tue, 28 Mar 2023 09:27:55 +0200: > >> Hello Miquel, >> >> On 3/27/23 13:06, Tudor Ambarus wrote: >>> >>> >>> On 3/27/23 11:43, Miquel Raynal wrote: >>>> Hi Tudor, >>>> >>>> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: >>>> >>>>> On 3/27/23 10:47, Christophe Kerello wrote: >>>>>> This patch is using timings.mode value instead of checking tRC_min timing >>>>>> for EDO mode support. >>>>>> >>> >>>>> Fixes and Cc to stable here too, as you'd like to have this backported >>>>> as well, don't you? >>>> >>>> Actually the reason why Christophe split this into two patches is >>>> because timings.mode was introduced rather lately, he wanted the same >>>> patch to apply on all stable kernels, he actually asked for that split >>>> and I agreed (another solution would have been to send this current >>>> patch to Linus and have the other version sent to stable, but it >>>> requires a bit of scheduling on both ends). >>>> >>>> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t >>> >>> Right, I understood that from the beginning. If it were to me, I would >>> Cc: stable@vger.kernel.org #v5.4+ for the first patch and >>> Cc: stable@vger.kernel.org #v5.10+ for the second. >>> >>> So first would be alone just in v5.4, and starting with v5.10 we'll have >>> both and we'll mimic what we currently have in upstream mainline. >>> >> >> I can send a V3 with cc tag added as per Tudor's suggestion. >> Or cc tag will be added when the patches will be applied? > > I'll handle it, no problem. Is it fine if I send this as part of the > next merge window or do you expect this fix to be applied earlier? I > just sent my fixes PR on Monday morning. > Yes, it is fine. This patch set can be applied on next merge window. Regards, Christophe Kerello. >> >> Regards, >> Christophe Kerello. >> >>>> >>>>> >>>>>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> >>>>> >>>>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> >>>>> >>>>>> --- >>>>>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>>>> index 3abb63d00a0b..9e74bcd90aaa 100644 >>>>>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>>>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>>>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, >>>>>> if (IS_ERR(sdrt)) >>>>>> return PTR_ERR(sdrt); >>>>>> >>>> - if (sdrt->tRC_min < 30000) >>>>>> + if (conf->timings.mode > 3) >>>>>> return -EOPNOTSUPP; >>>>>> >>>> if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) >>>> >>>> >>>> Thanks, >>>> Miquèl > > > Thanks, > Miquèl
Hi Christophe, christophe.kerello@foss.st.com wrote on Tue, 28 Mar 2023 09:27:55 +0200: > Hello Miquel, > > On 3/27/23 13:06, Tudor Ambarus wrote: > > > > > > On 3/27/23 11:43, Miquel Raynal wrote: > >> Hi Tudor, > >> > >> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: > >> > >>> On 3/27/23 10:47, Christophe Kerello wrote: > >>>> This patch is using timings.mode value instead of checking tRC_min timing > >>>> for EDO mode support. > >>>> >>> > >>> Fixes and Cc to stable here too, as you'd like to have this backported > >>> as well, don't you? > >> > >> Actually the reason why Christophe split this into two patches is > >> because timings.mode was introduced rather lately, he wanted the same > >> patch to apply on all stable kernels, he actually asked for that split > >> and I agreed (another solution would have been to send this current > >> patch to Linus and have the other version sent to stable, but it > >> requires a bit of scheduling on both ends). > >> > >> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t > > > > Right, I understood that from the beginning. If it were to me, I would > > Cc: stable@vger.kernel.org #v5.4+ for the first patch and > > Cc: stable@vger.kernel.org #v5.10+ for the second. > > > > So first would be alone just in v5.4, and starting with v5.10 we'll have > > both and we'll mimic what we currently have in upstream mainline. > > > > I can send a V3 with cc tag added as per Tudor's suggestion. > Or cc tag will be added when the patches will be applied? Actually I have other fixes to queue early next week, so can you please send a v3 with the tags discussed with Tudor? Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 3abb63d00a0b..9e74bcd90aaa 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, if (IS_ERR(sdrt)) return PTR_ERR(sdrt); - if (sdrt->tRC_min < 30000) + if (conf->timings.mode > 3) return -EOPNOTSUPP; if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)