Message ID | 20230327094742.38856-2-christophe.kerello@foss.st.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1386937vqo; Mon, 27 Mar 2023 02:52:00 -0700 (PDT) X-Google-Smtp-Source: AKy350aO4qff7N9V+SgxFMcoKQstTlbxWpsIMo1jxWSYs8f9ca8MfTRRk6lzJqqy+LI+jYxd7K0g X-Received: by 2002:a17:906:2350:b0:8a9:e330:3a23 with SMTP id m16-20020a170906235000b008a9e3303a23mr10831063eja.26.1679910719931; Mon, 27 Mar 2023 02:51:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679910719; cv=none; d=google.com; s=arc-20160816; b=bkMzsKzw8IJk3dROgEEPvnrhjz1Ob8x2Fe/PdC6Zq5hLZJJUQm9zG0iNLMjCJMCAYT GwpbtGZScAUPwjCs9vopzH4kbx1XdkIv242CHonvOVapanC844E3v8GkU8eMekJCZ4mp 37zjG0ND0cr2l6s6Apwxo6r613B8qZbOoeqOxxcVRXCA2thgO/nosjp5ZoglSON1Jyox 5Ne3+uvp4wX7MYYy8ELIruNhR2V460UqBdFiIiU/f9jhvBQB/BWnfJH/oWltBhsMbXSX 2b2rrppaJRZOtcW5Bdp6KvsNYidhjJrvKAOeh5aZAOyo9Gg6Y64fEUsRcfkiiv53crmq nhzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WYV7EBAofXJyjzZBSfwpOR5v4z00FX931Kh4b0ja95g=; b=mBBzdgHqX1jKhSSFKqQQEHMpRzJLVLk9iz+oLO9tSZxPThb8uuctJzk2/n/f0MHlkf V/9mmZMUXE4mHWC/FSIgfEu6EOSkn0z0YWGA5Zx+K4SNXWoqtK4Udnz5JJ2GTYTKLnLh pLncnI5l7dRagWNk+YiyjSrGyQpsHjMO4WeZsgAuVpfAcKgPIzrZFfwnBzy7rqXv5mnf HCGis7dHM3Qc8mvqUdxqXvys8VnB7gwU5JE7r7Cd0VHR6WuTT/EWcqfdcDkuKugWeRam AghDBGAk2p6Wh7DSejRN2eVev9BYcqL58Qe8R6jjxizMh4hoKY2oC4dPFmONmsjBjgxu KWpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=mSHycwxz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o26-20020a170906861a00b009332ffacd59si11116405ejx.765.2023.03.27.02.51.36; Mon, 27 Mar 2023 02:51:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=mSHycwxz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232665AbjC0Js7 (ORCPT <rfc822;makky5685@gmail.com> + 99 others); Mon, 27 Mar 2023 05:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231740AbjC0Jsy (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 27 Mar 2023 05:48:54 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3716E1984 for <linux-kernel@vger.kernel.org>; Mon, 27 Mar 2023 02:48:53 -0700 (PDT) Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32R8IUGG005717; Mon, 27 Mar 2023 11:48:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=WYV7EBAofXJyjzZBSfwpOR5v4z00FX931Kh4b0ja95g=; b=mSHycwxz/M4wDaKtWXw9Z3IVed4FlmVQ6GoYzw7//rWelMxMz/3+WMymg3WmLLdpcwnT qzDFPsw27345E3DOOIHlgJExjay4+sKlpH1dM9L51UZHMwwtudOVC9UBMI+qowmYthhU foXNNIoj4MMKnGq+Bu9jp8vySRWt0BJKdCLjsmcqICfSi4ae1n7D5dRkNoIEkNgKHwOi AdiNbJMId8s6KKCD1+ZuaIC0KtN9ejKIteBlJ4kFoa5xG22gzfsPXi4bdh8AmdC6B9SU j4XI+MLcyP4jTLrEnBoKtHOlblQaOq/X49kbN623WINryfOHdWP7zIU2SopDktwLwiWd vA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3phsr59ygq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Mar 2023 11:48:35 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4DC9D10002A; Mon, 27 Mar 2023 11:48:35 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 481C6212FAB; Mon, 27 Mar 2023 11:48:35 +0200 (CEST) Received: from localhost (10.48.0.175) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 27 Mar 2023 11:48:35 +0200 From: Christophe Kerello <christophe.kerello@foss.st.com> To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> CC: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, Christophe Kerello <christophe.kerello@foss.st.com> Subject: [PATCH v2 1/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Date: Mon, 27 Mar 2023 11:47:41 +0200 Message-ID: <20230327094742.38856-2-christophe.kerello@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230327094742.38856-1-christophe.kerello@foss.st.com> References: <20230327094742.38856-1-christophe.kerello@foss.st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.48.0.175] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-24_01,2023-02-09_01 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761514056803125890?= X-GMAIL-MSGID: =?utf-8?q?1761514062628091758?= |
Series |
mtd: rawnand: stm32_fmc2: do not support EDO mode
|
|
Commit Message
Christophe Kerello
March 27, 2023, 9:47 a.m. UTC
FMC2 controller does not support EDO mode (timings mode 4 and 5).
Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver")
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++
1 file changed, 3 insertions(+)
Comments
Hi, On 3/27/23 10:47, Christophe Kerello wrote: > FMC2 controller does not support EDO mode (timings mode 4 and 5). > commit subject and message should be in imperative mood, so I would change the commit subject to "mtd: rawnand: stm32_fmc2: Remove unsupported EDO mode" and the message to something like "Remove the EDO mode support from as the FMC2 controller does not support the feature." Extra points if you describe what happened when you used timings mode 4 and 5 with the current version of the driver. Miquel, could you add Cc to stable when applying? Cc: stable@vger.kernel.org > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver") Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 5d627048c420..3abb63d00a0b 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > if (IS_ERR(sdrt)) > return PTR_ERR(sdrt); > > + if (sdrt->tRC_min < 30000) > + return -EOPNOTSUPP; > + > if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) > return 0; >
Hi Tudor, tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:29:56 +0100: > Hi, > > On 3/27/23 10:47, Christophe Kerello wrote: > > FMC2 controller does not support EDO mode (timings mode 4 and 5). > > > > commit subject and message should be in imperative mood, so I would > change the commit subject to "mtd: rawnand: stm32_fmc2: Remove > unsupported EDO mode" and the message to something like "Remove the EDO > mode support from as the FMC2 controller does not support the feature." > Extra points if you describe what happened when you used timings mode 4 > and 5 with the current version of the driver. > > Miquel, could you add Cc to stable when applying? > Cc: stable@vger.kernel.org Yes, absolutely. > > > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver") > > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > > > --- > > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > > index 5d627048c420..3abb63d00a0b 100644 > > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > > @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > > if (IS_ERR(sdrt)) > > return PTR_ERR(sdrt); > > > > + if (sdrt->tRC_min < 30000) > > + return -EOPNOTSUPP; > > + > > if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) > > return 0; > > Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 5d627048c420..3abb63d00a0b 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, if (IS_ERR(sdrt)) return PTR_ERR(sdrt); + if (sdrt->tRC_min < 30000) + return -EOPNOTSUPP; + if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) return 0;