From patchwork Mon Mar 27 08:36:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 75305 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1359280vqo; Mon, 27 Mar 2023 01:42:58 -0700 (PDT) X-Google-Smtp-Source: AKy350Z1++kyNZP6+D4gVa8x7mT38CVHp/7o9NAXMlIRAC57qG+THJmf40diNv1nPipf4ypqtPTg X-Received: by 2002:a05:6402:31eb:b0:500:4062:99f7 with SMTP id dy11-20020a05640231eb00b00500406299f7mr11466482edb.32.1679906578590; Mon, 27 Mar 2023 01:42:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679906578; cv=none; d=google.com; s=arc-20160816; b=GHDTdTwBctCOVsyxi98DjNz3NU2oYCm/EdjnMDoJ1f6/+Bn+FfI3ISetoX0v0zYtFa VKdzPOd/acschD2wW87KErCqyGPBs4hVnm0b1xQxhVYglcQvBzdj1oMUBPFSQI8FU1mg dSMG+9swjJ4TiFt7PJ6hb5thEc3S9RX0epUC603T0F6JaChTiGRER0yzNcOEOW++QIGV YjMG4RsL0NZ6yypyK0SsBHZvLllTMJ+nRKcGgA+YuEfqAdTtlUmKjwqtkwNG0hjxzOdf 0MpGHf3hya0614xUS4XanyagLklDIbHsMdTAnbLe1twNqi0PBJfDMTtlLbTJdM9b3lza MJew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BYwAGMe1PfAGydSVqlgv0hiTKV8LxJz7Cfr4pQvks4M=; b=A0ks0ixzEb7BXEU4cLf09vc45S1RfQTT+LLYPz/pswg4Vfl+8uJV3SSlAzX97Wai4Q PE1OLr5/XcBWrKqAr+dZwS/PBoX2hGgvTbYsppXj0A7E8vwC6n0CLZpLY+ur3mfcgSc1 2qESWyvpA+puMi4B0RAp8W7jPLa+qUFwZJReNoe8+0+oTlSfziWhif9ON1zutO0udPLP DGGcDQZGTvOxXduAf7TV8g4j3OYXaQXvvueMqPC4o3U/HxJZUx4OgO9LvclTBK5vUVkt 8h7ef0SfkIe4mdhsvdHH9lojw6B+mOtAbMASBXbxitVSpm8izE/COl7gdleQ+AS9Ljkf PKIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=pnRmRrpE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z21-20020aa7cf95000000b005002d86f446si28132438edx.128.2023.03.27.01.42.35; Mon, 27 Mar 2023 01:42:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=pnRmRrpE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233253AbjC0Ilr (ORCPT + 99 others); Mon, 27 Mar 2023 04:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233152AbjC0Ikf (ORCPT ); Mon, 27 Mar 2023 04:40:35 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF1FE6A76; Mon, 27 Mar 2023 01:37:01 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FDA81F8A8; Mon, 27 Mar 2023 08:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1679906220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BYwAGMe1PfAGydSVqlgv0hiTKV8LxJz7Cfr4pQvks4M=; b=pnRmRrpElIfOGh45HyDbGyTLv5HE1XJiCA+hgB75qnV0jL4KSVd4BTS/HMLMTgZ6vr5c/q EW2BxF/x9H47o/NyMlbMwkvnqPLcy3SN0f4vddtVKFgShfc+EvOgYvcl9QnYQkD2CuiNrS 8JiD6T2Fu41dFmCAKBsZ2kYeG2PvttU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D0B913329; Mon, 27 Mar 2023 08:37:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rNmIDaxVIWS+SAAAMHmgww (envelope-from ); Mon, 27 Mar 2023 08:37:00 +0000 From: Juergen Gross To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, Jan Beulich Subject: [PATCH 2/2] xen/netback: remove not needed test in xenvif_tx_build_gops() Date: Mon, 27 Mar 2023 10:36:46 +0200 Message-Id: <20230327083646.18690-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230327083646.18690-1-jgross@suse.com> References: <20230327083646.18690-1-jgross@suse.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761509720666903364?= X-GMAIL-MSGID: =?utf-8?q?1761509720666903364?= The tests for the number of grant mapping or copy operations reaching the array size of the operations buffer at the end of the main loop in xenvif_tx_build_gops() isn't needed. The loop can handle at maximum MAX_PENDING_REQS transfer requests, as XEN_RING_NR_UNCONSUMED_REQUESTS() is taking unsent responses into consideration, too. Remove the tests. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant --- drivers/net/xen-netback/netback.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 111c179f161b..4943be4fd99d 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -1082,10 +1082,6 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, __skb_queue_tail(&queue->tx_queue, skb); queue->tx.req_cons = idx; - - if ((*map_ops >= ARRAY_SIZE(queue->tx_map_ops)) || - (*copy_ops >= ARRAY_SIZE(queue->tx_copy_ops))) - break; } return;