diff mbox series

arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support

Message ID 20230327083100.12587-1-a-nandan@ti.com
State New
Headers
Series arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support |

Commit Message

Apurva Nandan March 27, 2023, 8:31 a.m. UTC 
  Add support for eMMC card connected to main sdhci0 instance.

Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Bhavya Kapoor March 30, 2023, 6:20 a.m. UTC | #1 
On 27/03/23 14:01, Apurva Nandan wrote:
> Add support for eMMC card connected to main sdhci0 instance.
>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>

Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>

> ---
>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index 7480f37e89e8..1622a01a4667 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -21,6 +21,7 @@ chosen {
>
>   	aliases {
>   		serial2 = &main_uart8;
> +		mmc0 = &main_sdhci0;
>   		mmc1 = &main_sdhci1;
>   		i2c0 = &main_i2c0;
>   	};
> @@ -225,6 +226,14 @@ exp2: gpio@22 {
>   	};
>   };
>
> +&main_sdhci0 {
> +	/* eMMC */
> +	status = "okay";
> +	non-removable;
> +	ti,driver-strength-ohm = <50>;
> +	disable-wp;
> +};
> +
>   &main_sdhci1 {
>   	/* SD card */
>   	status = "okay";
> --
> 2.34.1
Looks correct to me.
Nishanth Menon March 30, 2023, 3:24 p.m. UTC | #2 
On 11:50-20230330, Bhavya Kapoor wrote:
> 
> On 27/03/23 14:01, Apurva Nandan wrote:
> > Add support for eMMC card connected to main sdhci0 instance.
> > 
> > Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> 
> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
> 
> > ---
> >   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > index 7480f37e89e8..1622a01a4667 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > @@ -21,6 +21,7 @@ chosen {
> > 
> >   	aliases {
> >   		serial2 = &main_uart8;
> > +		mmc0 = &main_sdhci0;
> >   		mmc1 = &main_sdhci1;
> >   		i2c0 = &main_i2c0;
> >   	};
> > @@ -225,6 +226,14 @@ exp2: gpio@22 {
> >   	};
> >   };
> > 
> > +&main_sdhci0 {
> > +	/* eMMC */
> > +	status = "okay";
> > +	non-removable;
> > +	ti,driver-strength-ohm = <50>;
> > +	disable-wp;
> > +};
> > +
> >   &main_sdhci1 {
> >   	/* SD card */
> >   	status = "okay";
> > --
> > 2.34.1
> Looks correct to me.


Don't you need pinmux?
Bhavya Kapoor March 30, 2023, 5:44 p.m. UTC | #3 
On 30/03/23 20:54, Nishanth Menon wrote:
> On 11:50-20230330, Bhavya Kapoor wrote:
>> On 27/03/23 14:01, Apurva Nandan wrote:
>>> Add support for eMMC card connected to main sdhci0 instance.
>>>
>>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
>> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
>>
>>> ---
>>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>>> index 7480f37e89e8..1622a01a4667 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>>> @@ -21,6 +21,7 @@ chosen {
>>>
>>>   	aliases {
>>>   		serial2 = &main_uart8;
>>> +		mmc0 = &main_sdhci0;
>>>   		mmc1 = &main_sdhci1;
>>>   		i2c0 = &main_i2c0;
>>>   	};
>>> @@ -225,6 +226,14 @@ exp2: gpio@22 {
>>>   	};
>>>   };
>>>
>>> +&main_sdhci0 {
>>> +	/* eMMC */
>>> +	status = "okay";
>>> +	non-removable;
>>> +	ti,driver-strength-ohm = <50>;
>>> +	disable-wp;
>>> +};
>>> +
>>>   &main_sdhci1 {
>>>   	/* SD card */
>>>   	status = "okay";
>>> --
>>> 2.34.1
>> Looks correct to me.
>
> Don't you need pinmux?
>
Hi Nishanth, pinmux is not needed since there is no mux options for emmc pins (mmc0) in datasheet.

 -> Kindly refer to datasheet for same : https://www.ti.com/lit/ds/symlink/tda4vh-q1.pdf?ts=1680197698102&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FTDA4VH-Q1%253FkeyMatch%253DTDA4VH%2BDATASHEET


Regards

~B-Kapoor
Nishanth Menon March 30, 2023, 6:27 p.m. UTC | #4 
On 23:14-20230330, Bhavya Kapoor wrote:
> 
> On 30/03/23 20:54, Nishanth Menon wrote:
> > On 11:50-20230330, Bhavya Kapoor wrote:
> >> On 27/03/23 14:01, Apurva Nandan wrote:
> >>> Add support for eMMC card connected to main sdhci0 instance.
> >>>
> >>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> >> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
> >>
> >>> ---
> >>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
> >>>   1 file changed, 9 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> index 7480f37e89e8..1622a01a4667 100644
> >>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> @@ -21,6 +21,7 @@ chosen {
> >>>
> >>>   	aliases {
> >>>   		serial2 = &main_uart8;
> >>> +		mmc0 = &main_sdhci0;
> >>>   		mmc1 = &main_sdhci1;
> >>>   		i2c0 = &main_i2c0;
> >>>   	};
> >>> @@ -225,6 +226,14 @@ exp2: gpio@22 {
> >>>   	};
> >>>   };
> >>>
> >>> +&main_sdhci0 {
> >>> +	/* eMMC */
> >>> +	status = "okay";
> >>> +	non-removable;
> >>> +	ti,driver-strength-ohm = <50>;
> >>> +	disable-wp;
> >>> +};
> >>> +
> >>>   &main_sdhci1 {
> >>>   	/* SD card */
> >>>   	status = "okay";
> >>> --
> >>> 2.34.1
> >> Looks correct to me.
> >
> > Don't you need pinmux?
> >
> Hi Nishanth, pinmux is not needed since there is no mux options for emmc pins (mmc0) in datasheet.
> 
>  -> Kindly refer to datasheet for same : https://www.ti.com/lit/ds/symlink/tda4vh-q1.pdf?ts=1680197698102&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FTDA4VH-Q1%253FkeyMatch%253DTDA4VH%2BDATASHEET

Aah, yes - thanks for clarifying.
Nishanth Menon March 30, 2023, 10:05 p.m. UTC | #5 
Hi Apurva Nandan,

On Mon, 27 Mar 2023 14:01:00 +0530, Apurva Nandan wrote:
> Add support for eMMC card connected to main sdhci0 instance.
> 
> 

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support
      commit: 891db0c48efb48c3af334006f9d7ea6a0aa49cb9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index 7480f37e89e8..1622a01a4667 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -21,6 +21,7 @@  chosen {
 
 	aliases {
 		serial2 = &main_uart8;
+		mmc0 = &main_sdhci0;
 		mmc1 = &main_sdhci1;
 		i2c0 = &main_i2c0;
 	};
@@ -225,6 +226,14 @@  exp2: gpio@22 {
 	};
 };
 
+&main_sdhci0 {
+	/* eMMC */
+	status = "okay";
+	non-removable;
+	ti,driver-strength-ohm = <50>;
+	disable-wp;
+};
+
 &main_sdhci1 {
 	/* SD card */
 	status = "okay";