From patchwork Mon Mar 27 07:58:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Xin3" X-Patchwork-Id: 75277 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1358065vqo; Mon, 27 Mar 2023 01:40:06 -0700 (PDT) X-Google-Smtp-Source: AK7set8/EMwjYOauXvydLB/yu4zjS3p4j1ZbVvvynn9xG+3EklKkFZ/Xd+zO9iSG62zCUWeO8qUa X-Received: by 2002:a05:6a20:4b16:b0:d7:4339:fad9 with SMTP id fp22-20020a056a204b1600b000d74339fad9mr8498775pzb.7.1679906406314; Mon, 27 Mar 2023 01:40:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679906406; cv=none; d=google.com; s=arc-20160816; b=R7v0HkaNzgzpytqYeHpcshujUdbWHL359yLM2Rc88085AHuZOy0G8fOMgt0gC04rCb +lIK0mOUqImKDoeZai9MlvVBXnwD6QaCbHbe4GD6vcaebhmPX0uGCbUya5VwHRUqqCbF KaPpDtwBCqx/fsB+s2FY4XOIra0Rz18kHz3uE2+Mv/uH2Z2jjcDkQG90NwHuOCSzyJB1 vkI8bHjTT4m+EpjyUu9S25FxqDdetm8LiQqSrmjn6wlsxPmxKH8zr6Fmukxf+xHVQ0jo RT/fOna+SddW4nRToJEyPj/3Q7Y1n9FICdxUE7cfjMzUTP5BsDUChDT+3hRaPRwd00H6 WPmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HXWU+EothhAOstFqFMAbdES8hja1CkXrrCI4kIOxLxM=; b=IKfO7oCRorOS5S7SW3aq8MZDmpfnqUJVKYcPpFRfWu0z7zbXIaI4/DLTDtsTKII+/e QRVKnBOKiUlcMuc9QaOe1DgVpsXftePgsaTyBPyzqRjAYe5gtp238pLm15zTUGQJGGjY ddK42MDjr2Hr8D0Ki8ihBcJ0Csx1m3vYlv6MZIIuIoysLFT5o+fGxz1FBIYg87b5+Pdn /UHMWgNFIXZvr06K1JmWL9NKoJc4+DjvXpA8i3iXsN6Eht5l44XqHtLtxxM2CB1RDEK4 2nKdbihmt3TZgClzj9jvz32heu4AXJSCyU/9mq87m0/yRSqqV+Whptu0ROGQmlb7laFc Tv7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VMbCHpXC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020aa7888b000000b00625951b2ed2si27558874pfe.49.2023.03.27.01.39.54; Mon, 27 Mar 2023 01:40:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VMbCHpXC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233101AbjC0I0N (ORCPT + 99 others); Mon, 27 Mar 2023 04:26:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233142AbjC0IY5 (ORCPT ); Mon, 27 Mar 2023 04:24:57 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E82B05BAE; Mon, 27 Mar 2023 01:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679905481; x=1711441481; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=T7eEyAoHvwiW3Acg9V6KJ8qZ7RgqMyuTGxhG3JO7gws=; b=VMbCHpXCgAVEzNVydp1vFudTY35BnyVXFoCu3v06MiC4LNVC7HRQCkvr 7wUSFG5eCZnzSg8uHUdx/9tGXR+9jNW/jSJ74k1tYeEhVK0JVzM5sRqdB 0NrmcsClK1GGvtRtjoRd+sA4TxUhRiROac7pDm8NU7bK/T0Ue9SJlM1Il BKpWcMIgTj9airG3DRPfAfe4jvbFpYAQf3CPFSnGh5kDK/Ye4aDTHIdIU ZihUMSQZ3Kl0Uco59OmzBVfygEmAFS7cJqMLOMenqTkbRO2ddxcuKCqKj lGSq9D01lkOEOL6Uju32Sq71Phx4MedQOel5itO2+RUBMCcfdQY5WQk4X A==; X-IronPort-AV: E=McAfee;i="6600,9927,10661"; a="338930340" X-IronPort-AV: E=Sophos;i="5.98,294,1673942400"; d="scan'208";a="338930340" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2023 01:24:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10661"; a="713787121" X-IronPort-AV: E=Sophos;i="5.98,294,1673942400"; d="scan'208";a="713787121" Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga008.jf.intel.com with ESMTP; 27 Mar 2023 01:24:38 -0700 From: Xin Li To: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org, andrew.cooper3@citrix.com, seanjc@google.com, pbonzini@redhat.com, ravi.v.shankar@intel.com, jiangshanlai@gmail.com, shan.kang@intel.com Subject: [PATCH v6 24/33] x86/fred: disallow the swapgs instruction when FRED is enabled Date: Mon, 27 Mar 2023 00:58:29 -0700 Message-Id: <20230327075838.5403-25-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230327075838.5403-1-xin3.li@intel.com> References: <20230327075838.5403-1-xin3.li@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761509539883743189?= X-GMAIL-MSGID: =?utf-8?q?1761509539883743189?= From: "H. Peter Anvin (Intel)" The FRED architecture establishes the full supervisor/user through: 1) FRED event delivery swaps the value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR. 2) ERETU swaps the value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR. Thus, the swapgs instruction is disallowed when FRED is enabled, otherwise it causes #UD. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/kernel/process_64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index a1aa74864c8b..2bea86073646 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -165,7 +165,8 @@ static noinstr unsigned long __rdgsbase_inactive(void) lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); gsbase = rdgsbase(); native_swapgs(); @@ -190,7 +191,8 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) { lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); wrgsbase(gsbase); native_swapgs();